)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"... if there are too many of them reported."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The goal is to maintain sane size of stats part of cbcollect dump."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The prometheus_cfg process wakes up every 10 min and performs"},{"line_number":14,"context_line":"the following steps:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"189fbbfc_405b9e96","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":66},"updated":"2020-10-16 20:14:53.000000000","message":"I\u0027d prefer to see the remainder of this commit message appear as a comment in the code. That way it can be seen by a reader of prometheus_cfg.erl without needing to figure out when these changes were introduced and tracking down the commit message.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"... if there are too many of them reported."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The goal is to maintain sane size of stats part of cbcollect dump."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The prometheus_cfg process wakes up every 10 min and performs"},{"line_number":14,"context_line":"the following steps:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"f6f8eb0d_65184a67","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":66},"in_reply_to":"189fbbfc_405b9e96","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":16,"context_line":"   from prometheus. Right now we need to know only how many samples"},{"line_number":17,"context_line":"   are reported in each scrape by each service. Prometheus keeps this"},{"line_number":18,"context_line":"   information in the scrape_samples_scraped metric."},{"line_number":19,"context_line":"2) All samples are devided into two parts: those for which the scrape"},{"line_number":20,"context_line":"   interval is static, and those for which the scrape interval can be"},{"line_number":21,"context_line":"   changed. First group is all the low cardinality metrics and"},{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"233294e4_6d150a9c","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":26},"updated":"2020-10-16 23:33:26.000000000","message":"divided","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"   from prometheus. Right now we need to know only how many samples"},{"line_number":17,"context_line":"   are reported in each scrape by each service. Prometheus keeps this"},{"line_number":18,"context_line":"   information in the scrape_samples_scraped metric."},{"line_number":19,"context_line":"2) All samples are devided into two parts: those for which the scrape"},{"line_number":20,"context_line":"   interval is static, and those for which the scrape interval can be"},{"line_number":21,"context_line":"   changed. First group is all the low cardinality metrics and"},{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"8a88348c_3df91b8f","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":26},"updated":"2020-10-16 20:14:53.000000000","message":"typo: divided","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   from prometheus. Right now we need to know only how many samples"},{"line_number":17,"context_line":"   are reported in each scrape by each service. Prometheus keeps this"},{"line_number":18,"context_line":"   information in the scrape_samples_scraped metric."},{"line_number":19,"context_line":"2) All samples are devided into two parts: those for which the scrape"},{"line_number":20,"context_line":"   interval is static, and those for which the scrape interval can be"},{"line_number":21,"context_line":"   changed. First group is all the low cardinality metrics and"},{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"6f38f50b_68c968d7","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":26},"in_reply_to":"233294e4_6d150a9c","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   from prometheus. Right now we need to know only how many samples"},{"line_number":17,"context_line":"   are reported in each scrape by each service. Prometheus keeps this"},{"line_number":18,"context_line":"   information in the scrape_samples_scraped metric."},{"line_number":19,"context_line":"2) All samples are devided into two parts: those for which the scrape"},{"line_number":20,"context_line":"   interval is static, and those for which the scrape interval can be"},{"line_number":21,"context_line":"   changed. First group is all the low cardinality metrics and"},{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"4544ebf8_0a47d2d8","line":19,"range":{"start_line":19,"start_character":19,"end_line":19,"end_character":26},"in_reply_to":"8a88348c_3df91b8f","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":20,"context_line":"   interval is static, and those for which the scrape interval can be"},{"line_number":21,"context_line":"   changed. First group is all the low cardinality metrics and"},{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"},{"line_number":23,"context_line":"   explicitly. All other samples fall to the second group."},{"line_number":24,"context_line":"3) Then it calculates how many samples can be written per second to"},{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"47c7399f_3df246d9","line":23,"range":{"start_line":23,"start_character":15,"end_line":23,"end_character":58},"updated":"2020-10-16 23:33:26.000000000","message":"So the second group is all high cardinality metrics where the scrape interval is not explicitly set.  What\u0027s an example which falls into the second group?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":20,"context_line":"   interval is static, and those for which the scrape interval can be"},{"line_number":21,"context_line":"   changed. First group is all the low cardinality metrics and"},{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"},{"line_number":23,"context_line":"   explicitly. All other samples fall to the second group."},{"line_number":24,"context_line":"3) Then it calculates how many samples can be written per second to"},{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"d4d5ef02_b8c10b6e","line":23,"range":{"start_line":23,"start_character":15,"end_line":23,"end_character":58},"in_reply_to":"47c7399f_3df246d9","updated":"2020-10-19 20:26:09.000000000","message":"high cardinality metrics where the scrape interval is not explicitly set (added it to the commit message)","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"},{"line_number":23,"context_line":"   explicitly. All other samples fall to the second group."},{"line_number":24,"context_line":"3) Then it calculates how many samples can be written per second to"},{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"},{"line_number":27,"context_line":"   number is the maximum samples rate for metrics from second group."},{"line_number":28,"context_line":"4) Now when it knows the max samples rate and the number of samples"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ec67bf6f_2d666e88","line":25,"range":{"start_line":25,"start_character":43,"end_line":25,"end_character":45},"updated":"2020-10-16 23:33:26.000000000","message":"and","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"},{"line_number":23,"context_line":"   explicitly. All other samples fall to the second group."},{"line_number":24,"context_line":"3) Then it calculates how many samples can be written per second to"},{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"},{"line_number":27,"context_line":"   number is the maximum samples rate for metrics from second group."},{"line_number":28,"context_line":"4) Now when it knows the max samples rate and the number of samples"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"58987972_f80b56b0","line":25,"range":{"start_line":25,"start_character":43,"end_line":25,"end_character":55},"updated":"2020-10-16 20:14:53.000000000","message":"and subtracts the","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"},{"line_number":23,"context_line":"   explicitly. All other samples fall to the second group."},{"line_number":24,"context_line":"3) Then it calculates how many samples can be written per second to"},{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"},{"line_number":27,"context_line":"   number is the maximum samples rate for metrics from second group."},{"line_number":28,"context_line":"4) Now when it knows the max samples rate and the number of samples"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"dae9bebd_1c12cc59","line":25,"range":{"start_line":25,"start_character":43,"end_line":25,"end_character":55},"in_reply_to":"58987972_f80b56b0","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"   the high cardinality metrics for which the scrape interval is set"},{"line_number":23,"context_line":"   explicitly. All other samples fall to the second group."},{"line_number":24,"context_line":"3) Then it calculates how many samples can be written per second to"},{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"},{"line_number":27,"context_line":"   number is the maximum samples rate for metrics from second group."},{"line_number":28,"context_line":"4) Now when it knows the max samples rate and the number of samples"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"032fb59e_84c69fe8","line":25,"range":{"start_line":25,"start_character":43,"end_line":25,"end_character":45},"in_reply_to":"ec67bf6f_2d666e88","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":23,"context_line":"   explicitly. All other samples fall to the second group."},{"line_number":24,"context_line":"3) Then it calculates how many samples can be written per second to"},{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"},{"line_number":27,"context_line":"   number is the maximum samples rate for metrics from second group."},{"line_number":28,"context_line":"4) Now when it knows the max samples rate and the number of samples"},{"line_number":29,"context_line":"   per scrape, it is easy to calculate scrape intervals for each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ff965da4_3116bc9b","line":26,"range":{"start_line":26,"start_character":46,"end_line":26,"end_character":48},"updated":"2020-10-16 23:33:26.000000000","message":"#2","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"   explicitly. All other samples fall to the second group."},{"line_number":24,"context_line":"3) Then it calculates how many samples can be written per second to"},{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"},{"line_number":27,"context_line":"   number is the maximum samples rate for metrics from second group."},{"line_number":28,"context_line":"4) Now when it knows the max samples rate and the number of samples"},{"line_number":29,"context_line":"   per scrape, it is easy to calculate scrape intervals for each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1f251c28_934debea","line":26,"range":{"start_line":26,"start_character":46,"end_line":26,"end_character":48},"in_reply_to":"ff965da4_3116bc9b","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"},{"line_number":27,"context_line":"   number is the maximum samples rate for metrics from second group."},{"line_number":28,"context_line":"4) Now when it knows the max samples rate and the number of samples"},{"line_number":29,"context_line":"   per scrape, it is easy to calculate scrape intervals for each"},{"line_number":30,"context_line":"   service."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I383dacfaf88a0ba392c97a72bd809f9428469535"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"7815a00b_0dad21c0","line":30,"range":{"start_line":28,"start_character":3,"end_line":30,"end_character":11},"updated":"2020-10-19 18:03:39.000000000","message":"Would you add an example here.  Let\u0027s say the max sample rate is 295 samples per second and the number of samples per scrape is 223.  What is the scrape interval?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"   satisfy cbcollect dump size requirement an subtracts rate of"},{"line_number":26,"context_line":"   \"static\" samples from it (first group from #1). The resulting"},{"line_number":27,"context_line":"   number is the maximum samples rate for metrics from second group."},{"line_number":28,"context_line":"4) Now when it knows the max samples rate and the number of samples"},{"line_number":29,"context_line":"   per scrape, it is easy to calculate scrape intervals for each"},{"line_number":30,"context_line":"   service."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I383dacfaf88a0ba392c97a72bd809f9428469535"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"458fa44d_f0c5769d","line":30,"range":{"start_line":28,"start_character":3,"end_line":30,"end_character":11},"in_reply_to":"7815a00b_0dad21c0","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"}],"src/prometheus_cfg.erl":[{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":34,"context_line":"            intervals_timer_ref \u003d undefined})."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"-define(RELOAD_RETRY_PERIOD, 10000)."},{"line_number":37,"context_line":"-define(DEFAULT_PROMETHEUS_TIMEOUT, 5000)."},{"line_number":38,"context_line":"-define(USERNAME, \"@prometheus\")."},{"line_number":39,"context_line":"-define(NS_TO_PROMETHEUS_USERNAME, \"ns_server\")."},{"line_number":40,"context_line":"-define(DEFAULT_HIGH_CARD_SERVICES, [index, fts, kv, cbas])."}],"source_content_type":"text/x-erlang","patch_set":17,"id":"f0482147_e12e6d85","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":42},"updated":"2020-10-16 20:14:53.000000000","message":"Add a comment about the units?  (5000 seconds? msec?).","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            intervals_timer_ref \u003d undefined})."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"-define(RELOAD_RETRY_PERIOD, 10000)."},{"line_number":37,"context_line":"-define(DEFAULT_PROMETHEUS_TIMEOUT, 5000)."},{"line_number":38,"context_line":"-define(USERNAME, \"@prometheus\")."},{"line_number":39,"context_line":"-define(NS_TO_PROMETHEUS_USERNAME, \"ns_server\")."},{"line_number":40,"context_line":"-define(DEFAULT_HIGH_CARD_SERVICES, [index, fts, kv, cbas])."}],"source_content_type":"text/x-erlang","patch_set":17,"id":"1cbabbd5_12ac026e","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":42},"in_reply_to":"f0482147_e12e6d85","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":70,"context_line":"     {token_file, \"prometheus_token\"},"},{"line_number":71,"context_line":"     {query_max_samples, 200000},"},{"line_number":72,"context_line":"     {intervals_calculation_period, 10*60*1000}, %% 10m"},{"line_number":73,"context_line":"     {cbcollect_stats_dump_max_size, 1024*1024*1024}, %% in bytes"},{"line_number":74,"context_line":"     {cbcollect_stats_min_period, 14}, %% in days"},{"line_number":75,"context_line":"     {average_sample_size, 3}, %% in bytes"},{"line_number":76,"context_line":"     {services, [{S, [{high_cardinality_enabled, true}]}"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"19d5b261_339646f7","line":73,"range":{"start_line":73,"start_character":57,"end_line":73,"end_character":65},"updated":"2020-10-16 23:33:26.000000000","message":"1GB in bytes","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":70,"context_line":"     {token_file, \"prometheus_token\"},"},{"line_number":71,"context_line":"     {query_max_samples, 200000},"},{"line_number":72,"context_line":"     {intervals_calculation_period, 10*60*1000}, %% 10m"},{"line_number":73,"context_line":"     {cbcollect_stats_dump_max_size, 1024*1024*1024}, %% in bytes"},{"line_number":74,"context_line":"     {cbcollect_stats_min_period, 14}, %% in days"},{"line_number":75,"context_line":"     {average_sample_size, 3}, %% in bytes"},{"line_number":76,"context_line":"     {services, [{S, [{high_cardinality_enabled, true}]}"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"b8193436_2d71a69b","line":73,"range":{"start_line":73,"start_character":57,"end_line":73,"end_character":65},"updated":"2020-10-16 20:14:53.000000000","message":"Replace with \"1 gigabyte\"?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"     {token_file, \"prometheus_token\"},"},{"line_number":71,"context_line":"     {query_max_samples, 200000},"},{"line_number":72,"context_line":"     {intervals_calculation_period, 10*60*1000}, %% 10m"},{"line_number":73,"context_line":"     {cbcollect_stats_dump_max_size, 1024*1024*1024}, %% in bytes"},{"line_number":74,"context_line":"     {cbcollect_stats_min_period, 14}, %% in days"},{"line_number":75,"context_line":"     {average_sample_size, 3}, %% in bytes"},{"line_number":76,"context_line":"     {services, [{S, [{high_cardinality_enabled, true}]}"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"1a8b2d78_5a77d4eb","line":73,"range":{"start_line":73,"start_character":57,"end_line":73,"end_character":65},"in_reply_to":"19d5b261_339646f7","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"     {token_file, \"prometheus_token\"},"},{"line_number":71,"context_line":"     {query_max_samples, 200000},"},{"line_number":72,"context_line":"     {intervals_calculation_period, 10*60*1000}, %% 10m"},{"line_number":73,"context_line":"     {cbcollect_stats_dump_max_size, 1024*1024*1024}, %% in bytes"},{"line_number":74,"context_line":"     {cbcollect_stats_min_period, 14}, %% in days"},{"line_number":75,"context_line":"     {average_sample_size, 3}, %% in bytes"},{"line_number":76,"context_line":"     {services, [{S, [{high_cardinality_enabled, true}]}"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"52bccc66_0c178ab9","line":73,"range":{"start_line":73,"start_character":57,"end_line":73,"end_character":65},"in_reply_to":"b8193436_2d71a69b","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    {pass, Creds} \u003d proplists:get_value(creds, NsToPrometheusAuthInfo,"},{"line_number":101,"context_line":"                                        {pass, undefined}),"},{"line_number":102,"context_line":"    AutoIntervals \u003d ns_config:search_node_with_default("},{"line_number":103,"context_line":"                      Config, stats_scrape_auto_intervals, []),"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    Settings \u003d"},{"line_number":106,"context_line":"        case Port \u003d\u003d undefined orelse Creds \u003d\u003d undefined of"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"fc273dde_ccf1ec92","line":103,"range":{"start_line":103,"start_character":30,"end_line":103,"end_character":57},"updated":"2020-10-16 20:14:53.000000000","message":"It\u0027s hard to tell from your changes what \"auto intervals\" means.  Does \"auto\" imply something beyond \"we do this regularly\"?\n\nIf this isn\u0027t a term which should be well-understood (e.g. because it is prometheus jargon) then I would add an explanatory comment and/or change \"auto intervals\" to something more intuitive.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    {pass, Creds} \u003d proplists:get_value(creds, NsToPrometheusAuthInfo,"},{"line_number":101,"context_line":"                                        {pass, undefined}),"},{"line_number":102,"context_line":"    AutoIntervals \u003d ns_config:search_node_with_default("},{"line_number":103,"context_line":"                      Config, stats_scrape_auto_intervals, []),"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    Settings \u003d"},{"line_number":106,"context_line":"        case Port \u003d\u003d undefined orelse Creds \u003d\u003d undefined of"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"1e53e649_4ba187c8","line":103,"range":{"start_line":103,"start_character":30,"end_line":103,"end_character":57},"in_reply_to":"fc273dde_ccf1ec92","updated":"2020-10-19 20:26:09.000000000","message":"I agree. I think \u0027auto\u0027 is not a correct word. I replaced it with dynamic. I also added a lot of comments. Should be clearer now.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"specs(Config) -\u003e"},{"line_number":128,"context_line":"    Settings \u003d build_settings(Config),"},{"line_number":129,"context_line":"    case proplists:get_value(enabled, Settings) of"},{"line_number":130,"context_line":"        true -\u003e"},{"line_number":131,"context_line":"            Args \u003d generate_prometheus_args(Settings),"},{"line_number":132,"context_line":"            LogFile \u003d proplists:get_value(log_file_name, Settings),"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"18dccf3b_c61bfb01","line":129,"range":{"start_line":129,"start_character":19,"end_line":129,"end_character":28},"updated":"2020-10-16 23:33:26.000000000","message":"get_bool","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"specs(Config) -\u003e"},{"line_number":128,"context_line":"    Settings \u003d build_settings(Config),"},{"line_number":129,"context_line":"    case proplists:get_value(enabled, Settings) of"},{"line_number":130,"context_line":"        true -\u003e"},{"line_number":131,"context_line":"            Args \u003d generate_prometheus_args(Settings),"},{"line_number":132,"context_line":"            LogFile \u003d proplists:get_value(log_file_name, Settings),"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"e6880dff_ff779d40","line":129,"range":{"start_line":129,"start_character":19,"end_line":129,"end_character":28},"in_reply_to":"18dccf3b_c61bfb01","updated":"2020-10-19 20:26:09.000000000","message":"This is out of this change\u0027s scope.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":230,"context_line":"    ensure_prometheus_config(Settings),"},{"line_number":231,"context_line":"    generate_prometheus_auth_info(Settings),"},{"line_number":232,"context_line":"    State \u003d"},{"line_number":233,"context_line":"        case proplists:get_value(enabled, Settings) of"},{"line_number":234,"context_line":"            true -\u003e"},{"line_number":235,"context_line":"                try_config_reload(#s{cur_settings \u003d Settings});"},{"line_number":236,"context_line":"            false -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"9c0b4876_42b6fcba","line":233,"range":{"start_line":233,"start_character":23,"end_line":233,"end_character":32},"updated":"2020-10-16 20:14:53.000000000","message":"proplists:get_bool/2 ?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":230,"context_line":"    ensure_prometheus_config(Settings),"},{"line_number":231,"context_line":"    generate_prometheus_auth_info(Settings),"},{"line_number":232,"context_line":"    State \u003d"},{"line_number":233,"context_line":"        case proplists:get_value(enabled, Settings) of"},{"line_number":234,"context_line":"            true -\u003e"},{"line_number":235,"context_line":"                try_config_reload(#s{cur_settings \u003d Settings});"},{"line_number":236,"context_line":"            false -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"39c8f046_eb0dfb02","line":233,"range":{"start_line":233,"start_character":23,"end_line":233,"end_character":32},"in_reply_to":"9c0b4876_42b6fcba","updated":"2020-10-19 20:26:09.000000000","message":"This code is removed in the following commit, so I decided to not fix it here.\nhttp://review.couchbase.org/c/ns_server/+/138280/3/src/prometheus_cfg.erl","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":329,"context_line":"                        sanitize_settings(OldSettings)]),"},{"line_number":330,"context_line":"            ensure_prometheus_config(NewSettings),"},{"line_number":331,"context_line":"            NewState \u003d"},{"line_number":332,"context_line":"                case proplists:get_value(enabled, NewSettings) of"},{"line_number":333,"context_line":"                    true -\u003e"},{"line_number":334,"context_line":"                        try_config_reload(State#s{cur_settings \u003d NewSettings});"},{"line_number":335,"context_line":"                    false -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"053834c4_cc74a0c7","line":332,"range":{"start_line":332,"start_character":31,"end_line":332,"end_character":40},"updated":"2020-10-16 20:14:53.000000000","message":"get_bool/2 ?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":329,"context_line":"                        sanitize_settings(OldSettings)]),"},{"line_number":330,"context_line":"            ensure_prometheus_config(NewSettings),"},{"line_number":331,"context_line":"            NewState \u003d"},{"line_number":332,"context_line":"                case proplists:get_value(enabled, NewSettings) of"},{"line_number":333,"context_line":"                    true -\u003e"},{"line_number":334,"context_line":"                        try_config_reload(State#s{cur_settings \u003d NewSettings});"},{"line_number":335,"context_line":"                    false -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"1409eff8_84ce18dd","line":332,"range":{"start_line":332,"start_character":31,"end_line":332,"end_character":40},"in_reply_to":"053834c4_cc74a0c7","updated":"2020-10-19 20:26:09.000000000","message":"This code is removed in the following commit, so I decided to not fix it here.\nhttp://review.couchbase.org/c/ns_server/+/138280/3/src/prometheus_cfg.erl","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":391,"context_line":"      fun ({Name, Props}) -\u003e"},{"line_number":392,"context_line":"          Addr \u003d proplists:get_value(Name, Targets),"},{"line_number":393,"context_line":"          Interval \u003d"},{"line_number":394,"context_line":"              case proplists:get_value(high_cardinality_scrape_interval, Props,"},{"line_number":395,"context_line":"                                       auto) of"},{"line_number":396,"context_line":"                  auto -\u003e"},{"line_number":397,"context_line":"                      proplists:get_value(Name, AutoIntervals, DefaultInterval);"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"7f87db09_df3689ed","line":394,"range":{"start_line":394,"start_character":39,"end_line":394,"end_character":71},"updated":"2020-10-19 18:03:39.000000000","message":"Where does this get set for non-tests?  I see it in randomly_test_calculate_dynamic_intervals but is it set elsewhere?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":391,"context_line":"      fun ({Name, Props}) -\u003e"},{"line_number":392,"context_line":"          Addr \u003d proplists:get_value(Name, Targets),"},{"line_number":393,"context_line":"          Interval \u003d"},{"line_number":394,"context_line":"              case proplists:get_value(high_cardinality_scrape_interval, Props,"},{"line_number":395,"context_line":"                                       auto) of"},{"line_number":396,"context_line":"                  auto -\u003e"},{"line_number":397,"context_line":"                      proplists:get_value(Name, AutoIntervals, DefaultInterval);"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"663aaf6d_67665a48","line":394,"range":{"start_line":394,"start_character":39,"end_line":394,"end_character":71},"in_reply_to":"7f87db09_df3689ed","updated":"2020-10-19 20:26:09.000000000","message":"It will be set by stats configuration endpoint as any other stats setting, it\u0027s not implemented yet.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":494,"context_line":"          (KV) -\u003e KV"},{"line_number":495,"context_line":"      end, Settings)."},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"restart_intervals_timer(#s{intervals_timer_ref \u003d undefined,"},{"line_number":498,"context_line":"                         cur_settings \u003d Settings} \u003d State) -\u003e"},{"line_number":499,"context_line":"    case intervals_calculation_period(Settings) of"},{"line_number":500,"context_line":"        disabled -\u003e State;"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"8be0c9f3_8ca1ea48","line":497,"updated":"2020-10-16 20:14:53.000000000","message":"While looking at this code, I had a hard time determining if there\u0027s one interval or multiple intervals.  I think that this should be stated explicitly as a comment in the code.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":494,"context_line":"          (KV) -\u003e KV"},{"line_number":495,"context_line":"      end, Settings)."},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"restart_intervals_timer(#s{intervals_timer_ref \u003d undefined,"},{"line_number":498,"context_line":"                         cur_settings \u003d Settings} \u003d State) -\u003e"},{"line_number":499,"context_line":"    case intervals_calculation_period(Settings) of"},{"line_number":500,"context_line":"        disabled -\u003e State;"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"3416b912_e88fbb57","line":497,"in_reply_to":"8be0c9f3_8ca1ea48","updated":"2020-10-19 20:26:09.000000000","message":"I renamed it and added a lot of comments. Hopefully it will help.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":503,"context_line":"            State#s{intervals_timer_ref \u003d Ref}"},{"line_number":504,"context_line":"    end;"},{"line_number":505,"context_line":"restart_intervals_timer(#s{intervals_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":506,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":507,"context_line":"    restart_intervals_timer(State#s{intervals_timer_ref \u003d undefined})."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"maybe_update_scrape_auto_intervals(Settings) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"bdb63fc2_7a05f601","line":506,"updated":"2020-10-16 23:33:26.000000000","message":"Add...\n\nmisc:flush(intervals_timer),","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":503,"context_line":"            State#s{intervals_timer_ref \u003d Ref}"},{"line_number":504,"context_line":"    end;"},{"line_number":505,"context_line":"restart_intervals_timer(#s{intervals_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":506,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":507,"context_line":"    restart_intervals_timer(State#s{intervals_timer_ref \u003d undefined})."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"maybe_update_scrape_auto_intervals(Settings) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"79fc8417_a8926065","line":506,"range":{"start_line":506,"start_character":4,"end_line":506,"end_character":8},"updated":"2020-10-16 23:33:26.000000000","message":"Don\u0027t include","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":503,"context_line":"            State#s{intervals_timer_ref \u003d Ref}"},{"line_number":504,"context_line":"    end;"},{"line_number":505,"context_line":"restart_intervals_timer(#s{intervals_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":506,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":507,"context_line":"    restart_intervals_timer(State#s{intervals_timer_ref \u003d undefined})."},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"maybe_update_scrape_auto_intervals(Settings) -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"167caf4a_e5eb3d76","line":506,"range":{"start_line":506,"start_character":4,"end_line":506,"end_character":8},"in_reply_to":"79fc8417_a8926065","updated":"2020-10-19 20:26:09.000000000","message":"Do you mean \"don\u0027t include \"misc:flush(intervals_timer)\"?\nPlease clarify","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":530,"context_line":"                        ns_config:set("},{"line_number":531,"context_line":"                          {node, node(), stats_scrape_auto_intervals},"},{"line_number":532,"context_line":"                          RoundedIntervals),"},{"line_number":533,"context_line":"                        ?log_debug(\"New scrape intervals:~n~p~n\""},{"line_number":534,"context_line":"                                   \"Previous scrape intervals: ~n~p~n\""},{"line_number":535,"context_line":"                                   \"Calculated based on scrapes info:~n~p~n\""},{"line_number":536,"context_line":"                                   \"Raw intervals:~n~p\","}],"source_content_type":"text/x-erlang","patch_set":17,"id":"8c896282_e0c96c82","line":533,"updated":"2020-10-19 18:03:39.000000000","message":"Notes:\n\n[ns_server:debug,2020-10-16T17:11:08.830-07:00,n_0@127.0.0.1:prometheus_cfg\u003c0.333.0\u003e:prometheus_cfg:maybe_update_scrape_auto_intervals:533]New scrape intervals:\n[]\nPrevious scrape intervals:\nundefined\nCalculated based on scrapes info:\n[{eventing,low_cardinality,1},\n {cbas,low_cardinality,8},\n {n1ql,low_cardinality,30},\n {index,low_cardinality,2},\n {index,high_cardinality,0},\n {kv,high_cardinality,313},\n {kv,low_cardinality,413},\n {fts,high_cardinality,0},\n {cbas,high_cardinality,0},\n {fts,low_cardinality,25},\n {xdcr,low_cardinality,0},\n {ns_server,low_cardinality,223}]\nRaw intervals:\n[]","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feb675b687ebc773f7b8d22f2fa68cfc49b091a4","unresolved":true,"context_lines":[{"line_number":545,"context_line":"            ok"},{"line_number":546,"context_line":"    end."},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"calculate_dynamic_intervals(ScrapeInfos, Settings) -\u003e"},{"line_number":549,"context_line":"    ServiceSettings \u003d proplists:get_value(services, Settings, []),"},{"line_number":550,"context_line":"    MinScrapeInterval \u003d proplists:get_value(scrape_interval, Settings),"},{"line_number":551,"context_line":"    {StaticIntSampleRates, DynamicIntTargets} \u003d"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"4c115aab_96051faf","line":548,"range":{"start_line":548,"start_character":0,"end_line":548,"end_character":27},"updated":"2020-10-16 20:14:53.000000000","message":"There\u0027s a lot going on in this function. It may take the reader a while to figure out what it is doing and what it returns.  Please consider adding a comment at the head of the function and some inline comments.  A \"-spec\" statement would be helpful here (and elsewhere too, I suspect).\n\nAside: the variable names used here are helpful in this regard.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":545,"context_line":"            ok"},{"line_number":546,"context_line":"    end."},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"calculate_dynamic_intervals(ScrapeInfos, Settings) -\u003e"},{"line_number":549,"context_line":"    ServiceSettings \u003d proplists:get_value(services, Settings, []),"},{"line_number":550,"context_line":"    MinScrapeInterval \u003d proplists:get_value(scrape_interval, Settings),"},{"line_number":551,"context_line":"    {StaticIntSampleRates, DynamicIntTargets} \u003d"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"17904719_710ed605","line":548,"range":{"start_line":548,"start_character":0,"end_line":548,"end_character":27},"in_reply_to":"227ae850_2994226f","updated":"2020-10-19 20:26:09.000000000","message":"Added specs for it and lots of comments. Hopefully it will help.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":545,"context_line":"            ok"},{"line_number":546,"context_line":"    end."},{"line_number":547,"context_line":""},{"line_number":548,"context_line":"calculate_dynamic_intervals(ScrapeInfos, Settings) -\u003e"},{"line_number":549,"context_line":"    ServiceSettings \u003d proplists:get_value(services, Settings, []),"},{"line_number":550,"context_line":"    MinScrapeInterval \u003d proplists:get_value(scrape_interval, Settings),"},{"line_number":551,"context_line":"    {StaticIntSampleRates, DynamicIntTargets} \u003d"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"227ae850_2994226f","line":548,"range":{"start_line":548,"start_character":0,"end_line":548,"end_character":27},"in_reply_to":"4c115aab_96051faf","updated":"2020-10-19 18:03:39.000000000","message":"I agree with Sam that inline comments would help.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":551,"context_line":"    {StaticIntSampleRates, DynamicIntTargets} \u003d"},{"line_number":552,"context_line":"        misc:partitionmap("},{"line_number":553,"context_line":"          fun ({_Name, low_cardinality, Num}) -\u003e"},{"line_number":554,"context_line":"                  {left, Num / MinScrapeInterval};"},{"line_number":555,"context_line":"              ({Name, high_cardinality, Num}) -\u003e"},{"line_number":556,"context_line":"                  Props \u003d proplists:get_value(Name, ServiceSettings, []),"},{"line_number":557,"context_line":"                  case proplists:get_value(high_cardinality_scrape_interval,"},{"line_number":558,"context_line":"                                           Props, auto) of"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"47a22b02_80eee96a","line":555,"range":{"start_line":554,"start_character":1,"end_line":555,"end_character":1},"updated":"2020-10-19 18:03:39.000000000","message":"If Num is 223 (which is the number of samples scraped in a minute as obtained by scrapes_info) why divide by 10?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":551,"context_line":"    {StaticIntSampleRates, DynamicIntTargets} \u003d"},{"line_number":552,"context_line":"        misc:partitionmap("},{"line_number":553,"context_line":"          fun ({_Name, low_cardinality, Num}) -\u003e"},{"line_number":554,"context_line":"                  {left, Num / MinScrapeInterval};"},{"line_number":555,"context_line":"              ({Name, high_cardinality, Num}) -\u003e"},{"line_number":556,"context_line":"                  Props \u003d proplists:get_value(Name, ServiceSettings, []),"},{"line_number":557,"context_line":"                  case proplists:get_value(high_cardinality_scrape_interval,"},{"line_number":558,"context_line":"                                           Props, auto) of"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"a04f4334_bb37a7a2","line":555,"range":{"start_line":554,"start_character":1,"end_line":555,"end_character":1},"in_reply_to":"47a22b02_80eee96a","updated":"2020-10-19 20:26:09.000000000","message":"Because I need to calculate \"samples per second\" here. I added comments for this code. Hopefully it will help.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                  {left, Num / MinScrapeInterval};"},{"line_number":555,"context_line":"              ({Name, high_cardinality, Num}) -\u003e"},{"line_number":556,"context_line":"                  Props \u003d proplists:get_value(Name, ServiceSettings, []),"},{"line_number":557,"context_line":"                  case proplists:get_value(high_cardinality_scrape_interval,"},{"line_number":558,"context_line":"                                           Props, auto) of"},{"line_number":559,"context_line":"                      auto -\u003e {right, {Name, Num}};"},{"line_number":560,"context_line":"                      I -\u003e {left, Num / I}"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"e9403870_d312a182","line":557,"range":{"start_line":557,"start_character":43,"end_line":557,"end_character":75},"updated":"2020-10-19 18:03:39.000000000","message":"Is this only for testing?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                  {left, Num / MinScrapeInterval};"},{"line_number":555,"context_line":"              ({Name, high_cardinality, Num}) -\u003e"},{"line_number":556,"context_line":"                  Props \u003d proplists:get_value(Name, ServiceSettings, []),"},{"line_number":557,"context_line":"                  case proplists:get_value(high_cardinality_scrape_interval,"},{"line_number":558,"context_line":"                                           Props, auto) of"},{"line_number":559,"context_line":"                      auto -\u003e {right, {Name, Num}};"},{"line_number":560,"context_line":"                      I -\u003e {left, Num / I}"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"c2d7bdf4_d291cd01","line":557,"range":{"start_line":557,"start_character":43,"end_line":557,"end_character":75},"in_reply_to":"e9403870_d312a182","updated":"2020-10-19 20:26:09.000000000","message":"It will be set by stats configuration endpoint as any other stats setting, it\u0027s not implemented yet.","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":566,"context_line":"    DynamicIntSamplesQuota \u003d max(TotalSamplesQuota - StaticIntTotalRate, 0),"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    DynamicIntDesiredSamplesRates \u003d"},{"line_number":569,"context_line":"        [{T, N / MinScrapeInterval} || {T, N} \u003c- DynamicIntTargets],"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    DynamicIntDesiredSamplesRatesSorted \u003d"},{"line_number":572,"context_line":"        lists:usort(fun ({T1, N1}, {T2, N2}) -\u003e {N1, T1} \u003d\u003c {N2, T2} end,"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"03c16064_f9b8f9c8","line":569,"range":{"start_line":569,"start_character":10,"end_line":569,"end_character":14},"updated":"2020-10-19 18:03:39.000000000","message":"Would you use \"Name\" and \"Num\"","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":566,"context_line":"    DynamicIntSamplesQuota \u003d max(TotalSamplesQuota - StaticIntTotalRate, 0),"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    DynamicIntDesiredSamplesRates \u003d"},{"line_number":569,"context_line":"        [{T, N / MinScrapeInterval} || {T, N} \u003c- DynamicIntTargets],"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    DynamicIntDesiredSamplesRatesSorted \u003d"},{"line_number":572,"context_line":"        lists:usort(fun ({T1, N1}, {T2, N2}) -\u003e {N1, T1} \u003d\u003c {N2, T2} end,"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"0924dcfd_5e0eeec2","line":569,"range":{"start_line":569,"start_character":10,"end_line":569,"end_character":14},"in_reply_to":"03c16064_f9b8f9c8","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":583,"context_line":"split_quota([], _Quota, Res) -\u003e Res;"},{"line_number":584,"context_line":"split_quota([{Target, Need} | Tail], Quota, Res) -\u003e"},{"line_number":585,"context_line":"    QuotaPerTarget \u003d Quota / (length(Tail) + 1),"},{"line_number":586,"context_line":"    case Need \u003c QuotaPerTarget of"},{"line_number":587,"context_line":"        true -\u003e"},{"line_number":588,"context_line":"            QuotaLeft \u003d Quota - Need,"},{"line_number":589,"context_line":"            split_quota(Tail, QuotaLeft, Res);"},{"line_number":590,"context_line":"        false -\u003e"},{"line_number":591,"context_line":"            QuotaLeft \u003d Quota - QuotaPerTarget,"},{"line_number":592,"context_line":"            split_quota(Tail, QuotaLeft, [{Target, QuotaPerTarget} | Res])"},{"line_number":593,"context_line":"    end."},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"intervals_calculation_period(Settings) -\u003e"},{"line_number":596,"context_line":"    case proplists:get_value(enabled, Settings) of"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"78aa402b_aa3f1459","line":593,"range":{"start_line":586,"start_character":1,"end_line":593,"end_character":1},"updated":"2020-10-19 18:03:39.000000000","message":"A short description would help","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":583,"context_line":"split_quota([], _Quota, Res) -\u003e Res;"},{"line_number":584,"context_line":"split_quota([{Target, Need} | Tail], Quota, Res) -\u003e"},{"line_number":585,"context_line":"    QuotaPerTarget \u003d Quota / (length(Tail) + 1),"},{"line_number":586,"context_line":"    case Need \u003c QuotaPerTarget of"},{"line_number":587,"context_line":"        true -\u003e"},{"line_number":588,"context_line":"            QuotaLeft \u003d Quota - Need,"},{"line_number":589,"context_line":"            split_quota(Tail, QuotaLeft, Res);"},{"line_number":590,"context_line":"        false -\u003e"},{"line_number":591,"context_line":"            QuotaLeft \u003d Quota - QuotaPerTarget,"},{"line_number":592,"context_line":"            split_quota(Tail, QuotaLeft, [{Target, QuotaPerTarget} | Res])"},{"line_number":593,"context_line":"    end."},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"intervals_calculation_period(Settings) -\u003e"},{"line_number":596,"context_line":"    case proplists:get_value(enabled, Settings) of"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"898f4bb7_65248428","line":593,"range":{"start_line":586,"start_character":1,"end_line":593,"end_character":1},"in_reply_to":"78aa402b_aa3f1459","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":593,"context_line":"    end."},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"intervals_calculation_period(Settings) -\u003e"},{"line_number":596,"context_line":"    case proplists:get_value(enabled, Settings) of"},{"line_number":597,"context_line":"        true -\u003e"},{"line_number":598,"context_line":"            case proplists:get_value(intervals_calculation_period, Settings) of"},{"line_number":599,"context_line":"                undefined -\u003e disabled;"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"b3ac3d62_8a0b2666","line":596,"range":{"start_line":596,"start_character":19,"end_line":596,"end_character":28},"updated":"2020-10-16 23:33:26.000000000","message":"get_bool","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":false,"context_lines":[{"line_number":593,"context_line":"    end."},{"line_number":594,"context_line":""},{"line_number":595,"context_line":"intervals_calculation_period(Settings) -\u003e"},{"line_number":596,"context_line":"    case proplists:get_value(enabled, Settings) of"},{"line_number":597,"context_line":"        true -\u003e"},{"line_number":598,"context_line":"            case proplists:get_value(intervals_calculation_period, Settings) of"},{"line_number":599,"context_line":"                undefined -\u003e disabled;"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"4695ecd3_3583d772","line":596,"range":{"start_line":596,"start_character":19,"end_line":596,"end_character":28},"in_reply_to":"b3ac3d62_8a0b2666","updated":"2020-10-19 20:26:09.000000000","message":"Done","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"627ef762f5cad3cdd07f65637f67d2760281b2e0","unresolved":true,"context_lines":[{"line_number":605,"context_line":""},{"line_number":606,"context_line":"scrapes_info(Settings) -\u003e"},{"line_number":607,"context_line":"    Query \u003d io_lib:format(\"scrape_samples_scraped[~bs:1m]\","},{"line_number":608,"context_line":"                          [?MAX_SCRAPE_INTERVAL]),"},{"line_number":609,"context_line":"    case prometheus:query(lists:flatten(Query), undefined,"},{"line_number":610,"context_line":"                          ?DEFAULT_PROMETHEUS_TIMEOUT, Settings) of"},{"line_number":611,"context_line":"        {ok, JSON} -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"ae2f6af4_6801f8a3","line":608,"range":{"start_line":608,"start_character":28,"end_line":608,"end_character":47},"updated":"2020-10-19 18:03:39.000000000","message":"So this returns the number of samples in each minute for the last 6 hours.  If we\u0027re only using the last one (down below) is it necessary to get so many?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":605,"context_line":""},{"line_number":606,"context_line":"scrapes_info(Settings) -\u003e"},{"line_number":607,"context_line":"    Query \u003d io_lib:format(\"scrape_samples_scraped[~bs:1m]\","},{"line_number":608,"context_line":"                          [?MAX_SCRAPE_INTERVAL]),"},{"line_number":609,"context_line":"    case prometheus:query(lists:flatten(Query), undefined,"},{"line_number":610,"context_line":"                          ?DEFAULT_PROMETHEUS_TIMEOUT, Settings) of"},{"line_number":611,"context_line":"        {ok, JSON} -\u003e"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"25430d7b_239e4fac","line":608,"range":{"start_line":608,"start_character":28,"end_line":608,"end_character":47},"in_reply_to":"ae2f6af4_6801f8a3","updated":"2020-10-19 20:26:09.000000000","message":"Because if some target hasn\u0027t been scraped for more the 5 minutes the \"scrape_samples_scraped\" query will return nothing for this target (because current value for this metric doesn\u0027t exist).","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":610,"context_line":"                          ?DEFAULT_PROMETHEUS_TIMEOUT, Settings) of"},{"line_number":611,"context_line":"        {ok, JSON} -\u003e"},{"line_number":612,"context_line":"            lists:map("},{"line_number":613,"context_line":"              fun ({Props}) -\u003e"},{"line_number":614,"context_line":"                  {MetricProps} \u003d proplists:get_value(\u003c\u003c\"metric\"\u003e\u003e, Props),"},{"line_number":615,"context_line":"                  TargetName \u003d proplists:get_value(\u003c\u003c\"instance\"\u003e\u003e, MetricProps),"},{"line_number":616,"context_line":"                  JobName \u003d proplists:get_value(\u003c\u003c\"job\"\u003e\u003e, MetricProps),"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"a29cb74b_cf20d514","line":613,"range":{"start_line":613,"start_character":20,"end_line":613,"end_character":25},"updated":"2020-10-16 23:33:26.000000000","message":"My notes...\n\n      {\n        \"metric\": {\n          \"__name__\": \"scrape_samples_scraped\",\n          \"instance\": \"kv\",\n          \"job\": \"general\"\n        },\n        \"values\": [\n          [\n            1602881160,\n            \"819\"\n          ],\n          [\n            1602881220,\n            \"819\"\n          ]\n        ]\n      },","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":618,"context_line":"                             \u003c\u003c\"general\"\u003e\u003e -\u003e low_cardinality;"},{"line_number":619,"context_line":"                             _ -\u003e high_cardinality"},{"line_number":620,"context_line":"                         end,"},{"line_number":621,"context_line":"                  [_, ValBin] \u003d lists:last(proplists:get_value(\u003c\u003c\"values\"\u003e\u003e,"},{"line_number":622,"context_line":"                                                               Props)),"},{"line_number":623,"context_line":"                  Num \u003d case prometheus:parse_value(ValBin) of"},{"line_number":624,"context_line":"                            %% NaN will be returned as undefined"},{"line_number":625,"context_line":"                            undefined -\u003e 0;"},{"line_number":626,"context_line":"                            %% We assume this metric should never return"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"d343b005_9f14ef68","line":623,"range":{"start_line":621,"start_character":1,"end_line":623,"end_character":0},"updated":"2020-10-16 23:33:26.000000000","message":"If we\u0027re only interested in the last value is it necessary to use ?MAX_SCRAPE_INTERVAL.  Is this needed to guarantee at least one value?","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c53d18e858cef749f2817dd05898cfaf79a2b92a","unresolved":true,"context_lines":[{"line_number":618,"context_line":"                             \u003c\u003c\"general\"\u003e\u003e -\u003e low_cardinality;"},{"line_number":619,"context_line":"                             _ -\u003e high_cardinality"},{"line_number":620,"context_line":"                         end,"},{"line_number":621,"context_line":"                  [_, ValBin] \u003d lists:last(proplists:get_value(\u003c\u003c\"values\"\u003e\u003e,"},{"line_number":622,"context_line":"                                                               Props)),"},{"line_number":623,"context_line":"                  Num \u003d case prometheus:parse_value(ValBin) of"},{"line_number":624,"context_line":"                            %% NaN will be returned as undefined"},{"line_number":625,"context_line":"                            undefined -\u003e 0;"},{"line_number":626,"context_line":"                            %% We assume this metric should never return"}],"source_content_type":"text/x-erlang","patch_set":17,"id":"8905ec46_01c9ef09","line":623,"range":{"start_line":621,"start_character":1,"end_line":623,"end_character":0},"in_reply_to":"d343b005_9f14ef68","updated":"2020-10-19 20:26:09.000000000","message":"You already asked this question. See my answer above","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ceb6cce453117c2dc0463bfb69f288f72f861ccd","unresolved":true,"context_lines":[{"line_number":638,"context_line":"    MaxSize \u003d proplists:get_value(cbcollect_stats_dump_max_size, Settings),"},{"line_number":639,"context_line":"    MinPeriod \u003d proplists:get_value(cbcollect_stats_min_period, Settings),"},{"line_number":640,"context_line":"    AverageSampleSize \u003d proplists:get_value(average_sample_size, Settings),"},{"line_number":641,"context_line":"    MaxSize / AverageSampleSize / MinPeriod / 24 / 60 / 60."},{"line_number":642,"context_line":""},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"-ifdef(TEST)."}],"source_content_type":"text/x-erlang","patch_set":17,"id":"b57e363f_9a6a1469","line":641,"updated":"2020-10-16 23:33:26.000000000","message":"1024*1024*1024 / 3 / 14 / 24 / 60 / 60 \u003d 296 samples per second","commit_id":"ddc7145df4bcd2a83214ea8e44291f7c0db57ce1"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ebd5967fe33679a6c192001a41cdb08d23198e06","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"bc0fb4fa_168ed4fc","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"updated":"2020-10-19 21:42:03.000000000","message":"Don\u0027t include \"_ \u003d\" \n\nAnd after the cancel do\n\nmisc_flush(intervals_timer),","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"833e74f7784fbf7f829ec50fa197809769555093","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"85b19ee2_681d1145","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"1b0994f2_19a32329","updated":"2020-10-20 00:45:49.000000000","message":"Dialyzer must be ok and there\u0027s these instances in ns_server which don\u0027t check.  The one in ns_orchestrator.erl is the exception.  It looks like the result of erlang:cancel_timer/1 is integer | false.\n\n$ grep erlang:cancel_timer * | grep -v andalso | grep -v case\nauto_failover.erl:    erlang:cancel_timer(Ref),\nauto_rebalance.erl:                       erlang:cancel_timer(PrevTRef),\nauto_rebalance.erl:    erlang:cancel_timer(TRef),\ndiag_handler.erl:        erlang:cancel_timer(TRef),\nmc_binary.erl:                erlang:cancel_timer(T)\nmc_binary.erl:        erlang:cancel_timer(Timer),\nmisc.erl:    erlang:cancel_timer(TRef),\nns_heart.erl:    erlang:cancel_timer(TRef),\nns_orchestrator.erl:    _ \u003d erlang:cancel_timer(TRef),\nprometheus_cfg.erl:    erlang:cancel_timer(Ref),\nsupervisor2.erl:    erlang:cancel_timer(TRef),","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"37e81be363cd0bedbfc1a919f535000a7b373590","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"55609613_b79df220","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"2c642b3c_a903e969","updated":"2020-10-20 23:37:04.000000000","message":"https://medium.com/@jgefroh/why-consistency-is-one-of-the-top-indicators-of-good-code-352ba5d62020","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"268594271cb6daf508328a7e0d83969a00bd7f13","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"2c642b3c_a903e969","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"42a052cd_ce8e8a2e","updated":"2020-10-20 18:26:21.000000000","message":"This looks a bit like a cargo cult to me.\nI already provided the reasons why I wrote it that way, but I will do it again:\nBy using \"_ \u003d\" I explicitly show that I expect the function to return anything (not only int but false is also ok).\nPlease let me know if you have questions.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7845ab195fe74c45e8bc71bc5a5d7fd9d48a104e","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"dc37dfbd_69cb2349","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"55609613_b79df220","updated":"2020-10-20 23:50:54.000000000","message":"Thank you for the link. I think I already explained why I wrote it the way wrote it. If you don\u0027t see any problems with the code could you please \u0027+2\u0027?","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"11d268f5faa916649938fe8a6945e7b604ea22c1","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"1b0994f2_19a32329","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"71ace35d_6ec1e49c","updated":"2020-10-20 00:00:32.000000000","message":"I don\u0027t expect it return ok so I use \"_ \u003d\" to explicitly show that. Dialyzer should complain about because the return value is ignored (it did it before, not sure if does it now). Anyway I don\u0027t think it does nothing.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"80280720060452ae8ed1446e64b355dbe43998fb","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"9e551604_edc84120","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"85b19ee2_681d1145","updated":"2020-10-20 01:32:34.000000000","message":"It doesn\u0027t seem convincing to me. It is perfectly legal to write that. Moreover, it\u0027s better to write it like that in this particular case.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"77ce44006091807c4cfb1a5856c84bc504b9b536","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"42a052cd_ce8e8a2e","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"9e551604_edc84120","updated":"2020-10-20 15:56:50.000000000","message":"Consistency within the component.  Otherwise folks wonder why one of many cases is handled differently.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"afc28b98555565d9e6b360b505e4f1bb3a8696d9","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"cd5e4b3b_af2ea213","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"bc0fb4fa_168ed4fc","updated":"2020-10-19 22:03:32.000000000","message":"Do you mind providing reasons why you think I need to do that?","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5b35cf909d721a92bb0ee0f243f9138bb1b7e9d0","unresolved":true,"context_lines":[{"line_number":521,"context_line":"            State#s{intervals_calc_timer_ref \u003d Ref}"},{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"71ace35d_6ec1e49c","line":524,"range":{"start_line":524,"start_character":4,"end_line":524,"end_character":6},"in_reply_to":"cd5e4b3b_af2ea213","updated":"2020-10-19 22:30:19.000000000","message":"The \"_ \u003d\" doesn\u0027t do anything.  And to be consistent with the rest of ns_server.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5b35cf909d721a92bb0ee0f243f9138bb1b7e9d0","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"},{"line_number":528,"context_line":"%% performs the following steps:"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"4c0fe2fe_f3bc1658","line":525,"updated":"2020-10-19 22:30:19.000000000","message":"the misc_flush(intervals_calculation_timer) is needed to flush a message that was already in the mailbox when the cancel_timer was done.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"268594271cb6daf508328a7e0d83969a00bd7f13","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"},{"line_number":528,"context_line":"%% performs the following steps:"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"ac630315_ba2bd4b4","line":525,"in_reply_to":"0b09c310_9a1687a1","updated":"2020-10-20 18:26:21.000000000","message":"Thank you I understand that. Can it lead to a problem? If so, could you please explain how?","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"833e74f7784fbf7f829ec50fa197809769555093","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"},{"line_number":528,"context_line":"%% performs the following steps:"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"93e35ed5_373e1504","line":525,"in_reply_to":"149cc908_5652c022","updated":"2020-10-20 00:45:49.000000000","message":"It would result in premature handling of the message instead of after the specified time interval.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"11d268f5faa916649938fe8a6945e7b604ea22c1","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"},{"line_number":528,"context_line":"%% performs the following steps:"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"149cc908_5652c022","line":525,"in_reply_to":"4c0fe2fe_f3bc1658","updated":"2020-10-20 00:00:32.000000000","message":"Thank you I understand what flush is doing. Do have any scenarios in mind when not having it in this particular case will lead to a problem?","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7845ab195fe74c45e8bc71bc5a5d7fd9d48a104e","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"},{"line_number":528,"context_line":"%% performs the following steps:"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"1080c68c_7e51c5aa","line":525,"in_reply_to":"5810c122_f698ceac","updated":"2020-10-20 23:50:54.000000000","message":"I don\u0027t understand the reason why I should add the flush? You can\u0027t explain why I need it. If you don\u0027t see how it can lead to a problem can you please \u0027+2\u0027 the change so we can continue working?","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"80280720060452ae8ed1446e64b355dbe43998fb","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"},{"line_number":528,"context_line":"%% performs the following steps:"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"dc4c8df7_cebd0a87","line":525,"in_reply_to":"93e35ed5_373e1504","updated":"2020-10-20 01:32:34.000000000","message":"I\u0027m sorry I don\u0027t think it makes any sense to me. Can you please explain what exactly you mean? Can you describe a scenario when this code will not work?","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"37e81be363cd0bedbfc1a919f535000a7b373590","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"},{"line_number":528,"context_line":"%% performs the following steps:"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"5810c122_f698ceac","line":525,"in_reply_to":"ac630315_ba2bd4b4","updated":"2020-10-20 23:37:04.000000000","message":"I don\u0027t know if it can lead to a problem.  But things might change in the future.  I don\u0027t understand the hesitancy to adding the flush.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"77ce44006091807c4cfb1a5856c84bc504b9b536","unresolved":true,"context_lines":[{"line_number":522,"context_line":"    end;"},{"line_number":523,"context_line":"restart_intervals_calculation_timer(#s{intervals_calc_timer_ref \u003d Ref} \u003d State) -\u003e"},{"line_number":524,"context_line":"    _ \u003d erlang:cancel_timer(Ref),"},{"line_number":525,"context_line":"    restart_intervals_calculation_timer(State#s{intervals_calc_timer_ref \u003d undefined})."},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"%% The prometheus_cfg process wakes up every 10 min (it\u0027s configurable) and"},{"line_number":528,"context_line":"%% performs the following steps:"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"0b09c310_9a1687a1","line":525,"in_reply_to":"dc4c8df7_cebd0a87","updated":"2020-10-20 15:56:50.000000000","message":"I didn\u0027t say it wouldn\u0027t work...it just can immediately deliver the message if it were already queued when the cancel was done.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1e82b59c5ce15aecd1c3c07b480b8f0e4841ec17","unresolved":true,"context_lines":[{"line_number":587,"context_line":"%% endpoints for given numbers of samples that are reported by those services"},{"line_number":588,"context_line":"%% (ScrapeInfos) and stats settings."},{"line_number":589,"context_line":"%% Function returns a proplist where the key is a service name and the value is"},{"line_number":590,"context_line":"%% a scrape interval for that service (as float). If some service is missing"},{"line_number":591,"context_line":"%% in the resulting proplist, the default scrape interval should be"},{"line_number":592,"context_line":"%% used for that service."},{"line_number":593,"context_line":"-spec calculate_dynamic_intervals([{Service, Type, NumberOfSamples}],"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"5488fa64_bccc9b1e","line":590,"range":{"start_line":590,"start_character":38,"end_line":590,"end_character":48},"updated":"2020-10-19 21:54:39.000000000","message":"Is the interval returned as a float for testing purposes?  It looks like the interval is converted to an integer (using round/1) in the \"production\" code.  Would it make sense to just return it as an integer?","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aa01f62a2d29825ebfe7224f7724d3f86cd41a8f","unresolved":true,"context_lines":[{"line_number":587,"context_line":"%% endpoints for given numbers of samples that are reported by those services"},{"line_number":588,"context_line":"%% (ScrapeInfos) and stats settings."},{"line_number":589,"context_line":"%% Function returns a proplist where the key is a service name and the value is"},{"line_number":590,"context_line":"%% a scrape interval for that service (as float). If some service is missing"},{"line_number":591,"context_line":"%% in the resulting proplist, the default scrape interval should be"},{"line_number":592,"context_line":"%% used for that service."},{"line_number":593,"context_line":"-spec calculate_dynamic_intervals([{Service, Type, NumberOfSamples}],"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"8af09621_d35dd317","line":590,"range":{"start_line":590,"start_character":38,"end_line":590,"end_character":48},"in_reply_to":"5488fa64_bccc9b1e","updated":"2020-10-19 22:08:38.000000000","message":"It\u0027s converted to integers outside of this function, but for test purposes it\u0027s better to have them as floats here (it\u0027s harder to check calculation after rounding).","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f3b6601df9ba91a9ed06a5b166ff7553e13ab25d","unresolved":false,"context_lines":[{"line_number":587,"context_line":"%% endpoints for given numbers of samples that are reported by those services"},{"line_number":588,"context_line":"%% (ScrapeInfos) and stats settings."},{"line_number":589,"context_line":"%% Function returns a proplist where the key is a service name and the value is"},{"line_number":590,"context_line":"%% a scrape interval for that service (as float). If some service is missing"},{"line_number":591,"context_line":"%% in the resulting proplist, the default scrape interval should be"},{"line_number":592,"context_line":"%% used for that service."},{"line_number":593,"context_line":"-spec calculate_dynamic_intervals([{Service, Type, NumberOfSamples}],"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"897550fb_4e26c6d7","line":590,"range":{"start_line":590,"start_character":38,"end_line":590,"end_character":48},"in_reply_to":"8af09621_d35dd317","updated":"2020-10-19 22:33:01.000000000","message":"Ah, OK.","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004434,"name":"Steve Watanabe","email":"steve.watanabe@couchbase.com","username":"stevewatanabe","avatars":[{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2f7068a915b687049c6f46dbaa1d1b09.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ebd5967fe33679a6c192001a41cdb08d23198e06","unresolved":true,"context_lines":[{"line_number":583,"context_line":"            ok"},{"line_number":584,"context_line":"    end."},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"%% Pure function that calculates scrape intervals for services\u0027 high cardinality"},{"line_number":587,"context_line":"%% endpoints for given numbers of samples that are reported by those services"},{"line_number":588,"context_line":"%% (ScrapeInfos) and stats settings."},{"line_number":589,"context_line":"%% Function returns a proplist where the key is a service name and the value is"},{"line_number":590,"context_line":"%% a scrape interval for that service (as float). If some service is missing"},{"line_number":591,"context_line":"%% in the resulting proplist, the default scrape interval should be"},{"line_number":592,"context_line":"%% used for that service."},{"line_number":593,"context_line":"-spec calculate_dynamic_intervals([{Service, Type, NumberOfSamples}],"},{"line_number":594,"context_line":"                                  [Setting]) -\u003e [{Service, ScrapeInterval}] when"},{"line_number":595,"context_line":"                        Service         :: atom(),"},{"line_number":596,"context_line":"                        Type            :: low_cardinality | high_cardinality,"},{"line_number":597,"context_line":"                        NumberOfSamples :: non_neg_integer(),"},{"line_number":598,"context_line":"                        Setting         :: {Key :: atom(), Value :: term()},"},{"line_number":599,"context_line":"                        ScrapeInterval  :: float()."},{"line_number":600,"context_line":"calculate_dynamic_intervals(ScrapeInfos, Settings) -\u003e"},{"line_number":601,"context_line":"    ServiceSettings \u003d proplists:get_value(services, Settings, []),"},{"line_number":602,"context_line":"    MinScrapeInterval \u003d proplists:get_value(scrape_interval, Settings),"},{"line_number":603,"context_line":"    %% Split all reporting targets into two lists"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"c3f326eb_6e60ef63","line":600,"range":{"start_line":586,"start_character":0,"end_line":600,"end_character":0},"updated":"2020-10-19 21:42:03.000000000","message":"Nice","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1e82b59c5ce15aecd1c3c07b480b8f0e4841ec17","unresolved":true,"context_lines":[{"line_number":626,"context_line":"    %% This is how many samples can be reported per seconds by targets with"},{"line_number":627,"context_line":"    %% dynamic scrape intervals"},{"line_number":628,"context_line":"    DynamicIntSamplesQuota \u003d max(TotalSamplesQuota - StaticIntTotalRate, 0),"},{"line_number":629,"context_line":"    %% This is how many sameples per second each service wants to report"},{"line_number":630,"context_line":"    DynamicIntDesiredSamplesRates \u003d"},{"line_number":631,"context_line":"        [{Name, Num / MinScrapeInterval} || {Name, Num} \u003c- DynamicIntTargets],"},{"line_number":632,"context_line":"    %% The same as above but sorted by the second tuple element"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"ec5979a4_7fcb552e","line":629,"range":{"start_line":629,"start_character":24,"end_line":629,"end_character":32},"updated":"2020-10-19 21:54:39.000000000","message":"Nit: typo: \"samples\".","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004560,"name":"Sam Cramer","email":"sam.cramer@couchbase.com","username":"samcramer","avatars":[{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/9053e3c8a02dd81f3658a38a2d1f6802.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f3b6601df9ba91a9ed06a5b166ff7553e13ab25d","unresolved":false,"context_lines":[{"line_number":626,"context_line":"    %% This is how many samples can be reported per seconds by targets with"},{"line_number":627,"context_line":"    %% dynamic scrape intervals"},{"line_number":628,"context_line":"    DynamicIntSamplesQuota \u003d max(TotalSamplesQuota - StaticIntTotalRate, 0),"},{"line_number":629,"context_line":"    %% This is how many sameples per second each service wants to report"},{"line_number":630,"context_line":"    DynamicIntDesiredSamplesRates \u003d"},{"line_number":631,"context_line":"        [{Name, Num / MinScrapeInterval} || {Name, Num} \u003c- DynamicIntTargets],"},{"line_number":632,"context_line":"    %% The same as above but sorted by the second tuple element"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"51adb187_e9d61acc","line":629,"range":{"start_line":629,"start_character":24,"end_line":629,"end_character":32},"in_reply_to":"3214a333_3750ee61","updated":"2020-10-19 22:33:01.000000000","message":"Done","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aa01f62a2d29825ebfe7224f7724d3f86cd41a8f","unresolved":true,"context_lines":[{"line_number":626,"context_line":"    %% This is how many samples can be reported per seconds by targets with"},{"line_number":627,"context_line":"    %% dynamic scrape intervals"},{"line_number":628,"context_line":"    DynamicIntSamplesQuota \u003d max(TotalSamplesQuota - StaticIntTotalRate, 0),"},{"line_number":629,"context_line":"    %% This is how many sameples per second each service wants to report"},{"line_number":630,"context_line":"    DynamicIntDesiredSamplesRates \u003d"},{"line_number":631,"context_line":"        [{Name, Num / MinScrapeInterval} || {Name, Num} \u003c- DynamicIntTargets],"},{"line_number":632,"context_line":"    %% The same as above but sorted by the second tuple element"}],"source_content_type":"text/x-erlang","patch_set":18,"id":"3214a333_3750ee61","line":629,"range":{"start_line":629,"start_character":24,"end_line":629,"end_character":32},"in_reply_to":"ec5979a4_7fcb552e","updated":"2020-10-19 22:08:38.000000000","message":"done","commit_id":"32de5e93457e4d6d2e8e2380423b52f14070b05d"}]}