)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e051c025ba7fac0e0dffaf44ee7197f7d5fb5079","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"MB-43196 Use existing afamily interface to connect to memcached"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we attempt to reload memcached config, we make have a situation"},{"line_number":10,"context_line":"where the address family in ns_server has changed but not propogated to"},{"line_number":11,"context_line":"memcached yet. We might failt to communicate with memcached over new address"},{"line_number":12,"context_line":"family as memcached may not be listening on the new address family."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"98bdab79_67eed418","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":51},"updated":"2020-12-16 20:06:53.000000000","message":"typo?","commit_id":"572fd3218c120279d82a3f79823c848dd8eef5e9"}],"src/memcached_config_mgr.erl":[{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e051c025ba7fac0e0dffaf44ee7197f7d5fb5079","unresolved":true,"context_lines":[{"line_number":207,"context_line":"    %% We do this because we might have changed address family in ns_server and"},{"line_number":208,"context_line":"    %% we don\u0027t want to try connecting to the address family which might not"},{"line_number":209,"context_line":"    %% exist in memcached yet."},{"line_number":210,"context_line":"    MemcachedAFamily \u003d get_required_interface(CurrentMcdConfig),"},{"line_number":211,"context_line":"    true \u003d (MemcachedAFamily \u003d/\u003d undefined),"},{"line_number":212,"context_line":"    case ns_memcached:config_validate(DifferentConfig, MemcachedAFamily) of"},{"line_number":213,"context_line":"        ok -\u003e"}],"source_content_type":"text/x-erlang","patch_set":2,"id":"de57a6bb_0b5422c3","line":210,"range":{"start_line":210,"start_character":1,"end_line":210,"end_character":64},"updated":"2020-12-16 20:06:53.000000000","message":"I suggest we also call get_required_interface with new config here (as an assert). In order to make sure it will be possible to extract afamily later.\ntrue \u003d (get_required_interface(DifferentConfig) \u003d/\u003d undefined),","commit_id":"572fd3218c120279d82a3f79823c848dd8eef5e9"}],"src/ns_memcached.erl":[{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c525f5797ad5cebdd0b0fd2af3042dbb04866f93","unresolved":true,"context_lines":[{"line_number":1192,"context_line":"                                                 {sndbuf, ?SNDBUF}]),"},{"line_number":1193,"context_line":"                           case RV of"},{"line_number":1194,"context_line":"                               {ok, S} -\u003e {ok, S};"},{"line_number":1195,"context_line":"                               _ -\u003e Acc ++ [{AFamily, RV}]"},{"line_number":1196,"context_line":"                           end"},{"line_number":1197,"context_line":"                   end, [], AFamilys),"},{"line_number":1198,"context_line":""}],"source_content_type":"text/x-erlang","patch_set":3,"id":"b78bfd19_94b2d8ec","line":1195,"range":{"start_line":1195,"start_character":36,"end_line":1195,"end_character":58},"updated":"2020-12-18 01:14:07.000000000","message":"Nit: Doesn\u0027t really matter much in this particular case, but still I think it makes sense to do it right when there no reason not to do so :)\n[{AFamily, RV} | Acc]","commit_id":"ec733c055780ca0d86c7e02b1be9964e6af58f26"},{"author":{"_account_id":1004230,"name":"Abhijeeth Nuthan","email":"abhijeeth.nuthan@couchbase.com","username":"anuthan","avatars":[{"url":"https://www.gravatar.com/avatar/e4f8fd65f9bf0cd26808047635c1be62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e4f8fd65f9bf0cd26808047635c1be62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e4f8fd65f9bf0cd26808047635c1be62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e4f8fd65f9bf0cd26808047635c1be62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"87fdfa904b7a8b07ddf19ee20758ced44aedd92f","unresolved":false,"context_lines":[{"line_number":1192,"context_line":"                                                 {sndbuf, ?SNDBUF}]),"},{"line_number":1193,"context_line":"                           case RV of"},{"line_number":1194,"context_line":"                               {ok, S} -\u003e {ok, S};"},{"line_number":1195,"context_line":"                               _ -\u003e Acc ++ [{AFamily, RV}]"},{"line_number":1196,"context_line":"                           end"},{"line_number":1197,"context_line":"                   end, [], AFamilys),"},{"line_number":1198,"context_line":""}],"source_content_type":"text/x-erlang","patch_set":3,"id":"b8289938_0f164e8f","line":1195,"range":{"start_line":1195,"start_character":36,"end_line":1195,"end_character":58},"in_reply_to":"b78bfd19_94b2d8ec","updated":"2020-12-18 01:27:07.000000000","message":"Done","commit_id":"ec733c055780ca0d86c7e02b1be9964e6af58f26"},{"author":{"_account_id":1004257,"name":"Timofey Barmin","email":"timofey.barmin@couchbase.com","username":"timofey-barmin","avatars":[{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3d67f253451b9d3d488bd28a7020b53.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c525f5797ad5cebdd0b0fd2af3042dbb04866f93","unresolved":true,"context_lines":[{"line_number":1457,"context_line":"      end, NodeVBuckets, ?GET_KEYS_OUTER_TIMEOUT)."},{"line_number":1458,"context_line":""},{"line_number":1459,"context_line":"-spec config_validate(binary(), [inet | inet6]) -\u003e ok | mc_error()."},{"line_number":1460,"context_line":"config_validate(NewConfig, AFamilys) -\u003e"},{"line_number":1461,"context_line":"    misc:executing_on_new_process("},{"line_number":1462,"context_line":"      fun () -\u003e"},{"line_number":1463,"context_line":"              {ok, Sock} \u003d connect([{retries, 1},"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"93a32812_9ebaced2","line":1460,"range":{"start_line":1460,"start_character":27,"end_line":1460,"end_character":35},"updated":"2020-12-18 01:14:07.000000000","message":"AFamilies? Here and in other places","commit_id":"ec733c055780ca0d86c7e02b1be9964e6af58f26"},{"author":{"_account_id":1004230,"name":"Abhijeeth Nuthan","email":"abhijeeth.nuthan@couchbase.com","username":"anuthan","avatars":[{"url":"https://www.gravatar.com/avatar/e4f8fd65f9bf0cd26808047635c1be62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/e4f8fd65f9bf0cd26808047635c1be62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/e4f8fd65f9bf0cd26808047635c1be62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/e4f8fd65f9bf0cd26808047635c1be62.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"87fdfa904b7a8b07ddf19ee20758ced44aedd92f","unresolved":false,"context_lines":[{"line_number":1457,"context_line":"      end, NodeVBuckets, ?GET_KEYS_OUTER_TIMEOUT)."},{"line_number":1458,"context_line":""},{"line_number":1459,"context_line":"-spec config_validate(binary(), [inet | inet6]) -\u003e ok | mc_error()."},{"line_number":1460,"context_line":"config_validate(NewConfig, AFamilys) -\u003e"},{"line_number":1461,"context_line":"    misc:executing_on_new_process("},{"line_number":1462,"context_line":"      fun () -\u003e"},{"line_number":1463,"context_line":"              {ok, Sock} \u003d connect([{retries, 1},"}],"source_content_type":"text/x-erlang","patch_set":3,"id":"6e18d342_b037a313","line":1460,"range":{"start_line":1460,"start_character":27,"end_line":1460,"end_character":35},"in_reply_to":"93a32812_9ebaced2","updated":"2020-12-18 01:27:07.000000000","message":"Done","commit_id":"ec733c055780ca0d86c7e02b1be9964e6af58f26"}]}