)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c97dc60212fb8e94c73665b27f4efe908a83a2de","unresolved":true,"context_lines":[{"line_number":55,"context_line":"16:03:37 \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":"16:03:37 \u003d\u003d\u003d          Run unit tests              \u003d\u003d\u003d"},{"line_number":57,"context_line":"16:03:37 \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":"16:03:37 # make test ARGS\u003d-j3 --output-on-failure --no-compress-output -T Test --exclude-regex a^ --tests-regex \"ns_test.\""},{"line_number":59,"context_line":"16:03:37 Running tests..."},{"line_number":60,"context_line":"16:03:37    Site: f58292625dac"},{"line_number":61,"context_line":"16:03:37    Build name: Linux-g++"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"068d8e4c_e7b52b48","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":29},"updated":"2024-10-16 13:17:52.000000000","message":"CV parallelism was set to 3. Could be tweak as necessary. Observed no sporadic failures in CV so far, will run multiple times.","commit_id":"7af1b357378f6e5d5aca6b86b2fa2d2001379b37"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"398026c154fb623d1613fdc660579d3fe036f261","unresolved":true,"context_lines":[{"line_number":55,"context_line":"16:03:37 \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":"16:03:37 \u003d\u003d\u003d          Run unit tests              \u003d\u003d\u003d"},{"line_number":57,"context_line":"16:03:37 \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":"16:03:37 # make test ARGS\u003d-j3 --output-on-failure --no-compress-output -T Test --exclude-regex a^ --tests-regex \"ns_test.\""},{"line_number":59,"context_line":"16:03:37 Running tests..."},{"line_number":60,"context_line":"16:03:37    Site: f58292625dac"},{"line_number":61,"context_line":"16:03:37    Build name: Linux-g++"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"045e442f_0092d344","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":29},"in_reply_to":"068d8e4c_e7b52b48","updated":"2024-10-21 07:23:11.000000000","message":"Observed one sporadic failures. Won\u0027t change CV for the time being anyways.","commit_id":"7af1b357378f6e5d5aca6b86b2fa2d2001379b37"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"23cc29632bd50f870994b5cec5c061237fa9d091","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"886ac21f_6daa160d","updated":"2023-10-26 09:27:36.000000000","message":"make ns-test-ben-h","commit_id":"a58c8e105300da11bd05cdec88700adeb20f5d09"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8f9148c9453ef4a3788e9292f72a7b06f00e3e55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c0163004_a8221ff4","updated":"2023-10-27 08:07:38.000000000","message":"make ns-test-ben-h","commit_id":"a58c8e105300da11bd05cdec88700adeb20f5d09"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e6629beddf158ea05e1dd796941169ee4c0515eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1bf336c0_56409e70","updated":"2023-10-27 08:06:10.000000000","message":"make ns_test_ben_h","commit_id":"a58c8e105300da11bd05cdec88700adeb20f5d09"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7030ccfada250f793fd15acb992cd397accdbe99","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9d8b1cb1_e35d07eb","updated":"2024-05-09 15:13:54.000000000","message":"Tried this again and found that it reliably makes my laptop incredibly unresponsive, and it won\u0027t recover til I reboot.","commit_id":"9665d8c9da076853dae0ed8438f67ec940f7c942"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3a2537651f6c9c73ca15a98e71944591cd827d90","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a8435043_cf0ca1fc","in_reply_to":"9d8b1cb1_e35d07eb","updated":"2024-10-16 13:13:52.000000000","message":"Unsure what was going on here. Have not observed any issues recently and this is optional.","commit_id":"9665d8c9da076853dae0ed8438f67ec940f7c942"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"81fe5a037e046ee103b3da5e2489f9dfd685abe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"01e8a3fa_4791a0e6","in_reply_to":"a8435043_cf0ca1fc","updated":"2024-10-16 13:14:08.000000000","message":"Resolving","commit_id":"9665d8c9da076853dae0ed8438f67ec940f7c942"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ed977c017c745844b858a1fd26ece4caf0232fc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"65b53b01_9b73b19b","updated":"2024-10-15 16:20:53.000000000","message":"make ns_test_ben_h","commit_id":"63edd3b5d515d87c6d31f045818db7993eeaba7e"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ad71e66af419382b4d199a561db5db278713a6ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1d7deba9_2a6bd532","updated":"2024-10-17 10:48:19.000000000","message":"Deleting restriction check on master...","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"46c9193247f9753af24ad31f781558e67b743974","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":22,"id":"98ece0cd_f60818df","in_reply_to":"1d7deba9_2a6bd532","updated":"2024-10-17 11:00:55.000000000","message":"It was just a crash caused by issues connecting to github\n```\n07:41:21 ERROR: Error fetching remote repo \u0027origin\u0027\n07:41:21 hudson.plugins.git.GitException: Failed to fetch from https://github.com/couchbase/build-tools\n07:41:21 \tat PluginClassLoader for git//hudson.plugins.git.GitSCM.fetchFrom(GitSCM.java:997)\n07:41:21 \tat PluginClassLoader for git//hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1239)\n07:41:21 \tat PluginClassLoader for git//hudson.plugins.git.GitSCM._checkout(GitSCM.java:1310)\n07:41:21 \tat PluginClassLoader for git//hudson.plugins.git.GitSCM.checkout(GitSCM.java:1277)\n07:41:21 \tat hudson.scm.SCM.checkout(SCM.java:540)\n07:41:21 \tat hudson.model.AbstractProject.checkout(AbstractProject.java:1247)\n07:41:21 \tat hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:649)\n07:41:21 \tat jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:85)\n07:41:21 \tat hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:521)\n07:41:21 \tat hudson.model.Run.execute(Run.java:1894)\n07:41:21 \tat hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:44)\n07:41:21 \tat hudson.model.ResourceController.execute(ResourceController.java:101)\n07:41:21 \tat hudson.model.Executor.run(Executor.java:446)\n07:41:21 Caused by: hudson.plugins.git.GitException: Command \"git fetch --tags --force --progress -- https://github.com/couchbase/build-tools +refs/heads/*:refs/remotes/origin/*\" returned status code 128:\n07:41:21 stdout: \n07:41:21 stderr: ssh: connect to host github.com port 22: Connection timed out\n07:41:21 fatal: Could not read from remote repository.\n```","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3095e5c70bc798a95839cd7884ed39975b08850e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"2060ecd0_f5a5c650","in_reply_to":"98ece0cd_f60818df","updated":"2024-10-17 12:57:15.000000000","message":"Acknowledged","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"398026c154fb623d1613fdc660579d3fe036f261","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"e0c6313b_b94feaca","updated":"2024-10-21 07:23:11.000000000","message":"make ns_test","commit_id":"79902986e76b6c62f1e96834ec9966261d1301f2"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2e17af9a53375350bc3e4143a185bf2ab899f6d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"a2e56e09_ab8958ae","updated":"2024-10-18 10:49:22.000000000","message":"make ns_test_ben_h","commit_id":"79902986e76b6c62f1e96834ec9966261d1301f2"}],"CMakeLists.txt":[{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ecd68b021f8f023432af65a627de022918e5b36f","unresolved":true,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        get_filename_component(NAME_NO_EXT ${FILE} NAME_WLE)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        message(${FILE})"},{"line_number":268,"context_line":"        message(${NAME_NO_EXT})"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        if (NOT ${MATCH} EQUAL -1)"},{"line_number":271,"context_line":"            message(\"${NAME_NO_EXT} found a test macro\")"}],"source_content_type":"text/x-cmake","patch_set":11,"id":"758c0dfe_f22458d5","line":268,"range":{"start_line":267,"start_character":0,"end_line":268,"end_character":31},"updated":"2023-12-01 15:54:15.000000000","message":"need to remove these debug things","commit_id":"8ac9de7d8d520e6cd7f930317bdfa12eb35ed409"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1b2056cb4e2bfa4ec1c79762e7a3a3d7960c129e","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        get_filename_component(NAME_NO_EXT ${FILE} NAME_WLE)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        message(${FILE})"},{"line_number":268,"context_line":"        message(${NAME_NO_EXT})"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        if (NOT ${MATCH} EQUAL -1)"},{"line_number":271,"context_line":"            message(\"${NAME_NO_EXT} found a test macro\")"}],"source_content_type":"text/x-cmake","patch_set":11,"id":"3ed99103_8e682f2f","line":268,"range":{"start_line":267,"start_character":0,"end_line":268,"end_character":31},"in_reply_to":"758c0dfe_f22458d5","updated":"2023-12-01 16:37:28.000000000","message":"Done","commit_id":"8ac9de7d8d520e6cd7f930317bdfa12eb35ed409"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7c6169339f470818d9f5760b943802bbdf45c684","unresolved":true,"context_lines":[{"line_number":251,"context_line":"    file(GLOB_RECURSE ERL_FILES"},{"line_number":252,"context_line":"            ${CMAKE_CURRENT_SOURCE_DIR}/src"},{"line_number":253,"context_line":"            CONFIGURE_DEPENDS"},{"line_number":254,"context_line":"            src/*.erl)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    foreach(FILE ${ERL_FILES})"},{"line_number":257,"context_line":"        file(READ ${FILE} TMPTXT)"}],"source_content_type":"text/x-cmake","patch_set":13,"id":"3bf4f5d0_d903b7cf","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":5},"updated":"2023-12-04 14:45:21.000000000","message":"What about tests in the deps and tests directories? Does ns_test already run any of those?","commit_id":"9665d8c9da076853dae0ed8438f67ec940f7c942"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2f7501e27276279e493a50b96cbac71c3b96bc45","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    file(GLOB_RECURSE ERL_FILES"},{"line_number":252,"context_line":"            ${CMAKE_CURRENT_SOURCE_DIR}/src"},{"line_number":253,"context_line":"            CONFIGURE_DEPENDS"},{"line_number":254,"context_line":"            src/*.erl)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    foreach(FILE ${ERL_FILES})"},{"line_number":257,"context_line":"        file(READ ${FILE} TMPTXT)"}],"source_content_type":"text/x-cmake","patch_set":13,"id":"2d806aff_c911c668","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":5},"in_reply_to":"04548a50_cdad96ee","updated":"2024-10-16 13:20:17.000000000","message":"Acknowledged","commit_id":"9665d8c9da076853dae0ed8438f67ec940f7c942"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3a2537651f6c9c73ca15a98e71944591cd827d90","unresolved":true,"context_lines":[{"line_number":251,"context_line":"    file(GLOB_RECURSE ERL_FILES"},{"line_number":252,"context_line":"            ${CMAKE_CURRENT_SOURCE_DIR}/src"},{"line_number":253,"context_line":"            CONFIGURE_DEPENDS"},{"line_number":254,"context_line":"            src/*.erl)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    foreach(FILE ${ERL_FILES})"},{"line_number":257,"context_line":"        file(READ ${FILE} TMPTXT)"}],"source_content_type":"text/x-cmake","patch_set":13,"id":"04548a50_cdad96ee","line":254,"range":{"start_line":254,"start_character":0,"end_line":254,"end_character":5},"in_reply_to":"3bf4f5d0_d903b7cf","updated":"2024-10-16 13:13:52.000000000","message":"Updated with rebar changes, it should pick up all erl files in apps now","commit_id":"9665d8c9da076853dae0ed8438f67ec940f7c942"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"06894ba39d57a14dcfbbe5462b954f0325aecd9b","unresolved":true,"context_lines":[{"line_number":267,"context_line":"function(discover_eunit_tests)"},{"line_number":268,"context_line":"    message(\"Discovering erlang files for eunit tests\")"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    ## Pull out all the .erl files from ns_server/src."},{"line_number":271,"context_line":"    ## CMake doesn\u0027t recommend using GLOB to do this, not all build systems"},{"line_number":272,"context_line":"    ## support GLOB/CONFIGURE_DEPENDS to re-run the cmake step when we add a"},{"line_number":273,"context_line":"    ## new file that matches the GLOB expression, but both make and ninja do"}],"source_content_type":"text/x-cmake","patch_set":22,"id":"1a6a3bcb_8e5a9254","line":270,"range":{"start_line":270,"start_character":40,"end_line":270,"end_character":53},"updated":"2024-10-17 11:44:36.000000000","message":"Doesn\u0027t exist","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eab74230ffaeefd3a1159dc02dc78f637bc04951","unresolved":false,"context_lines":[{"line_number":267,"context_line":"function(discover_eunit_tests)"},{"line_number":268,"context_line":"    message(\"Discovering erlang files for eunit tests\")"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    ## Pull out all the .erl files from ns_server/src."},{"line_number":271,"context_line":"    ## CMake doesn\u0027t recommend using GLOB to do this, not all build systems"},{"line_number":272,"context_line":"    ## support GLOB/CONFIGURE_DEPENDS to re-run the cmake step when we add a"},{"line_number":273,"context_line":"    ## new file that matches the GLOB expression, but both make and ninja do"}],"source_content_type":"text/x-cmake","patch_set":22,"id":"7104af64_c4885976","line":270,"range":{"start_line":270,"start_character":40,"end_line":270,"end_character":53},"in_reply_to":"1a6a3bcb_8e5a9254","updated":"2024-10-17 12:57:06.000000000","message":"Done","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"06894ba39d57a14dcfbbe5462b954f0325aecd9b","unresolved":true,"context_lines":[{"line_number":274,"context_line":"    ## and I believe those are the only ones that we use at the moment. This"},{"line_number":275,"context_line":"    ## isn\u0027t the only place that we do this either..."},{"line_number":276,"context_line":"    file(GLOB_RECURSE ERL_FILES"},{"line_number":277,"context_line":"            ${CMAKE_CURRENT_SOURCE_DIR}/src"},{"line_number":278,"context_line":"            CONFIGURE_DEPENDS"},{"line_number":279,"context_line":"            apps/*.erl)"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-cmake","patch_set":22,"id":"5a10efb1_35565bd7","line":277,"range":{"start_line":277,"start_character":0,"end_line":277,"end_character":2},"updated":"2024-10-17 11:44:36.000000000","message":"This line doesn\u0027t seem to mean anything according to the cmake docs: https://web.archive.org/web/20241008154047/https://cmake.org/cmake/help/latest/command/file.html (cmake.org is down, so archive.org it is)","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eab74230ffaeefd3a1159dc02dc78f637bc04951","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    ## and I believe those are the only ones that we use at the moment. This"},{"line_number":275,"context_line":"    ## isn\u0027t the only place that we do this either..."},{"line_number":276,"context_line":"    file(GLOB_RECURSE ERL_FILES"},{"line_number":277,"context_line":"            ${CMAKE_CURRENT_SOURCE_DIR}/src"},{"line_number":278,"context_line":"            CONFIGURE_DEPENDS"},{"line_number":279,"context_line":"            apps/*.erl)"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-cmake","patch_set":22,"id":"7ae696b3_ee181791","line":277,"range":{"start_line":277,"start_character":0,"end_line":277,"end_character":2},"in_reply_to":"5a10efb1_35565bd7","updated":"2024-10-17 12:57:06.000000000","message":"Done","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"06894ba39d57a14dcfbbe5462b954f0325aecd9b","unresolved":true,"context_lines":[{"line_number":287,"context_line":"        string(FIND \"${TMPTXT}\""},{"line_number":288,"context_line":"                    \"-include_lib(\\\"eunit/include/eunit.hrl\\\").\" MATCH)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        get_filename_component(NAME_NO_EXT ${FILE} NAME_WLE)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if (NOT ${MATCH} EQUAL -1)"},{"line_number":293,"context_line":"            SET(TEST_FILTER ${NAME_NO_EXT})"}],"source_content_type":"text/x-cmake","patch_set":22,"id":"3a68a6ba_8be0b54f","line":290,"range":{"start_line":290,"start_character":8,"end_line":290,"end_character":30},"updated":"2024-10-17 11:44:36.000000000","message":"Why is this not within the subsequent if block?","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eab74230ffaeefd3a1159dc02dc78f637bc04951","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        string(FIND \"${TMPTXT}\""},{"line_number":288,"context_line":"                    \"-include_lib(\\\"eunit/include/eunit.hrl\\\").\" MATCH)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        get_filename_component(NAME_NO_EXT ${FILE} NAME_WLE)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if (NOT ${MATCH} EQUAL -1)"},{"line_number":293,"context_line":"            SET(TEST_FILTER ${NAME_NO_EXT})"}],"source_content_type":"text/x-cmake","patch_set":22,"id":"c20076c3_326e4e91","line":290,"range":{"start_line":290,"start_character":8,"end_line":290,"end_character":30},"in_reply_to":"3a68a6ba_8be0b54f","updated":"2024-10-17 12:57:06.000000000","message":"Done","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"}],"apps/ns_server/test/t.erl":[{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eab74230ffaeefd3a1159dc02dc78f637bc04951","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    X -\u003e X"},{"line_number":197,"context_line":"                end;"},{"line_number":198,"context_line":"            _ -\u003e"},{"line_number":199,"context_line":"                atom_to_list(Filter)"},{"line_number":200,"context_line":"        end,"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    FullWildcard \u003d"}],"source_content_type":"text/x-erlang","patch_set":22,"id":"29d3e447_e7690bf4","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":36},"updated":"2024-10-17 12:57:06.000000000","message":"@peter.searby@couchbase.com\n\nI checked this and it works with:\n\nT_WILDCARD\u003dfailover_tests ninja ns_test\nT_WILDCARD\u003d\"failover_tests\" ninja ns_test\nninja ns_test_failover_tests\n\nNot doing atom_to_list breaks the latter.","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5ab94214a46d777bf2e923616ab63a85dbb45d6a","unresolved":true,"context_lines":[{"line_number":196,"context_line":"                    X -\u003e X"},{"line_number":197,"context_line":"                end;"},{"line_number":198,"context_line":"            _ -\u003e"},{"line_number":199,"context_line":"                atom_to_list(Filter)"},{"line_number":200,"context_line":"        end,"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    FullWildcard \u003d"}],"source_content_type":"text/x-erlang","patch_set":22,"id":"d36bd3bb_c81d1fa2","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":36},"in_reply_to":"29d3e447_e7690bf4","updated":"2024-10-17 13:54:43.000000000","message":"Please add a comment explaining why","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d21fd8c14de24d55436c5a70bd0609dd3b713c56","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    X -\u003e X"},{"line_number":197,"context_line":"                end;"},{"line_number":198,"context_line":"            _ -\u003e"},{"line_number":199,"context_line":"                atom_to_list(Filter)"},{"line_number":200,"context_line":"        end,"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    FullWildcard \u003d"}],"source_content_type":"text/x-erlang","patch_set":22,"id":"7d8e3efd_60f39f15","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":36},"in_reply_to":"d36bd3bb_c81d1fa2","updated":"2024-10-17 14:54:31.000000000","message":"Done","commit_id":"2c45bc6c20bcce808179abe7c87201960600605f"},{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d21fd8c14de24d55436c5a70bd0609dd3b713c56","unresolved":true,"context_lines":[{"line_number":196,"context_line":"                    X -\u003e X"},{"line_number":197,"context_line":"                end;"},{"line_number":198,"context_line":"            _ -\u003e"},{"line_number":199,"context_line":"                %% Filter when passed from the command line is a file name, and"},{"line_number":200,"context_line":"                %% we aren\u0027t quoting/escaping it. Makes all of our filenames be"},{"line_number":201,"context_line":"                %% valid atoms seems reasonable."},{"line_number":202,"context_line":"                atom_to_list(Filter)"},{"line_number":203,"context_line":"        end,"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-erlang","patch_set":24,"id":"acbf5885_72d7a582","line":201,"range":{"start_line":199,"start_character":56,"end_line":201,"end_character":48},"updated":"2024-10-17 14:54:31.000000000","message":"```suggestion\n                %% Filter when passed from the command line is a file name, and\n                %% we aren\u0027t quoting/escaping it, so it comes as an atom.\n                %% Making all of our filenames valid atoms is reasonable.\n```","commit_id":"76bef7444b4d1943e18d9ddede46962fc47deed5"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aec780f571830edf9b2a674742e2637688c49fea","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    X -\u003e X"},{"line_number":197,"context_line":"                end;"},{"line_number":198,"context_line":"            _ -\u003e"},{"line_number":199,"context_line":"                %% Filter when passed from the command line is a file name, and"},{"line_number":200,"context_line":"                %% we aren\u0027t quoting/escaping it. Makes all of our filenames be"},{"line_number":201,"context_line":"                %% valid atoms seems reasonable."},{"line_number":202,"context_line":"                atom_to_list(Filter)"},{"line_number":203,"context_line":"        end,"},{"line_number":204,"context_line":""}],"source_content_type":"text/x-erlang","patch_set":24,"id":"bab1a6bf_0cf40a1b","line":201,"range":{"start_line":199,"start_character":56,"end_line":201,"end_character":48},"in_reply_to":"acbf5885_72d7a582","updated":"2024-10-17 14:58:50.000000000","message":"Done","commit_id":"76bef7444b4d1943e18d9ddede46962fc47deed5"}],"test/t.erl":[{"author":{"_account_id":1005031,"name":"Peter Searby","email":"peter.searby@couchbase.com","username":"Peter-Searby","avatars":[{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/5ea8069e83878adbf5005ffb143d522a.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"33975edad7f7afdf04374a14ec33aaa5626a676a","unresolved":true,"context_lines":[{"line_number":196,"context_line":"                    X -\u003e X"},{"line_number":197,"context_line":"                end;"},{"line_number":198,"context_line":"            _ -\u003e"},{"line_number":199,"context_line":"                atom_to_list(Filter)"},{"line_number":200,"context_line":"        end,"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    FullWildcard \u003d"}],"source_content_type":"text/x-erlang","patch_set":11,"id":"f632bb11_39b19d57","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":36},"updated":"2023-12-01 15:42:46.000000000","message":"I take it this fixes an existing bug?\nI can\u0027t see any other change in this patch which would necessitate this change, but perhaps I\u0027m missing something?","commit_id":"8ac9de7d8d520e6cd7f930317bdfa12eb35ed409"},{"author":{"_account_id":1004341,"name":"Ben Huddleston","email":"ben.huddleston@couchbase.com","username":"BenHuddleston","avatars":[{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ccb3e7e3b52c3d14e759d1b4c0507a3b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1b2056cb4e2bfa4ec1c79762e7a3a3d7960c129e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                    X -\u003e X"},{"line_number":197,"context_line":"                end;"},{"line_number":198,"context_line":"            _ -\u003e"},{"line_number":199,"context_line":"                atom_to_list(Filter)"},{"line_number":200,"context_line":"        end,"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    FullWildcard \u003d"}],"source_content_type":"text/x-erlang","patch_set":11,"id":"83ac50fa_d679b56f","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":36},"in_reply_to":"f632bb11_39b19d57","updated":"2023-12-01 16:37:28.000000000","message":"Yeah, fixes an issue with the original implementation of this code. I want to pass file names as atoms here, it\u0027s easier than escaping them in the cmake, but the filter needs to be a string/list.","commit_id":"8ac9de7d8d520e6cd7f930317bdfa12eb35ed409"}]}