)]}'
{"id":"php-ext-couchbase~22255","triplet_id":"php-ext-couchbase~master~I3558aef0d1fd8d071c5c7fd3f9e86b1c424affb4","project":"php-ext-couchbase","branch":"master","hashtags":[],"change_id":"I3558aef0d1fd8d071c5c7fd3f9e86b1c424affb4","subject":"PCBC-140 FDs not being closed on destruction","status":"MERGED","created":"2012-11-04 18:45:49.000000000","updated":"2012-11-04 19:19:05.000000000","submitted":"2012-11-04 19:19:05.000000000","submitter":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4a6176bb55bbc3da45eb9879f71283f12cb12e5f","_number":22255,"virtual_id_number":22255,"owner":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"date":"2012-11-04 19:19:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":1,"date":"2012-11-04 19:19:05.000000000","_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000201,"name":"Sergey Avseyev","email":"sergey.avseyev@gmail.com","username":"avsej","avatars":[{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2012-11-04 19:19:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"date":"2012-11-04 19:19:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000201,"name":"Sergey Avseyev","email":"sergey.avseyev@gmail.com","username":"avsej","avatars":[{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000201,"name":"Sergey Avseyev","email":"sergey.avseyev@gmail.com","username":"avsej","avatars":[{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000201,"name":"Sergey Avseyev","email":"sergey.avseyev@gmail.com","username":"avsej","avatars":[{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-04 18:46:42.000000000","updated_by":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2012-11-04 18:46:47.000000000","updated_by":{"_account_id":1000201,"name":"Sergey Avseyev","email":"sergey.avseyev@gmail.com","username":"avsej","avatars":[{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000201,"name":"Sergey Avseyev","email":"sergey.avseyev@gmail.com","username":"avsej","avatars":[{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dd70f9d8cc5f9ee488d68e7a787ba526.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2012-11-04 19:08:26.000000000","updated_by":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"f29646257d1dfe6635750374031df2828b990969","author":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:04:55.000000000","message":"Patch Set 1: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ba9f7ef246576534d15d9b1a8eb3f6231c6fc76a","author":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:05:52.000000000","message":"Patch Set 1:\n\n(btw. I don\u0027t understand why we\u0027re trying to create our own io ops here... We should be able to use a default one, _AND_ set the entire library in sync mode.. that would make the code a lot simpler...","accounts_in_message":[],"_revision_number":1},{"id":"e4a407df0ee6053e885d935fb78bae59cbbaebdd","author":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:06:26.000000000","message":"Patch Set 1: Verified\n\n","accounts_in_message":[],"_revision_number":1},{"id":"6fd6247d4c122df7b1703e09c86305d1018e61f3","author":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:07:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"3e884fc987f1dc11746988e6fa78fb6ebae1d98b","author":{"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:07:26.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"8c70a46504adea9ba0d49a3f4f7e6023b203f38e","author":{"_account_id":1000002,"name":"Trond Norbye","display_name":"Trond","email":"trond.norbye@couchbase.com","username":"trond","avatars":[{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/1521a1fa74885ab7b9748113afe689cc.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:08:26.000000000","message":"Patch Set 2: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ceb537298e6ab755c59174c5416e4b9bffd50c88","author":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:09:21.000000000","message":"Patch Set 2: Verified\n\nTrond, yeah I agree with that too (see my comments on the bug), but there\u0027s too much code which depends on it, and I don\u0027t want to change up the code here too much.\n\nWe\u0027ll fix this up in a later commit","accounts_in_message":[],"_revision_number":2},{"id":"dfdb32ef92e449f668b862184aa6160703a4c4b7","author":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:11:33.000000000","message":"Patch Set 2:\n\nWe also have some kind of \u0027lazy get\u0027 which would require callbacks. I\u0027m not sure who uses it really, but it\u0027s part of the API; see the *_delayed methods.","accounts_in_message":[],"_revision_number":2},{"id":"4a6176bb55bbc3da45eb9879f71283f12cb12e5f","author":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2012-11-04 19:19:05.000000000","message":"Change has been successfully cherry-picked as e292062f0428cbe81bd6a72bb44c8a3af93d04e8","accounts_in_message":[],"_revision_number":2}],"current_revision_number":3,"current_revision":"e292062f0428cbe81bd6a72bb44c8a3af93d04e8","revisions":{"5f52a1242572420b23d4ef4bfe4092a0f3b222a5":{"kind":"REWORK","_number":1,"created":"2012-11-04 18:45:49.000000000","uploader":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/55/22255/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/php-ext-couchbase","ref":"refs/changes/55/22255/1","commands":{"Branch":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/1 \u0026\u0026 git checkout -b change-22255 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/1","Reset To":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"070d2c4d0fce8bdb55aa412d7a7f5ce04a8889e4","subject":"Fixup constants in test due to changes in libcouchbase"}],"author":{"name":"Mark Nunberg","email":"mnunberg@haskalah.org","date":"2012-11-04 18:44:46.000000000","tz":-480},"committer":{"name":"Mark Nunberg","email":"mnunberg@haskalah.org","date":"2012-11-04 18:44:46.000000000","tz":-480},"subject":"Mark the self-created iops structure as needing cleanup by lcb","message":"Mark the self-created iops structure as needing cleanup by lcb\n\nThis avoids fd leaks.\n\n(indentation for the entire file is messed up and will be fixed in later\ncommits)\n\nChange-Id: I3558aef0d1fd8d071c5c7fd3f9e86b1c424affb4\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"070d2c4d0fce8bdb55aa412d7a7f5ce04a8889e4","is_merged_in_target_branch":true,"change_id":"I72a319c3667e98ea2646a2f244e9d82df7d5c29d","change_number":22212,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"93b0e87aab6177e92dcc6b5cc11a94f5f81b73d0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2012-11-04 19:07:23.000000000","uploader":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/55/22255/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/php-ext-couchbase","ref":"refs/changes/55/22255/2","commands":{"Branch":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/2 \u0026\u0026 git checkout -b change-22255 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/2","Reset To":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"070d2c4d0fce8bdb55aa412d7a7f5ce04a8889e4","subject":"Fixup constants in test due to changes in libcouchbase"}],"author":{"name":"Mark Nunberg","email":"mnunberg@haskalah.org","date":"2012-11-04 18:44:46.000000000","tz":-480},"committer":{"name":"Mark Nunberg","email":"mnunberg@haskalah.org","date":"2012-11-04 19:06:33.000000000","tz":-480},"subject":"PCBC-140 FDs not being closed on destruction","message":"PCBC-140 FDs not being closed on destruction\n\nMark the self-created iops structure as needing cleanup by lcb\nThis avoids the fd leaks.\n\n(indentation for the entire file is messed up and will be fixed in later\ncommits)\n\nChange-Id: I3558aef0d1fd8d071c5c7fd3f9e86b1c424affb4\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"070d2c4d0fce8bdb55aa412d7a7f5ce04a8889e4","is_merged_in_target_branch":true,"change_id":"I72a319c3667e98ea2646a2f244e9d82df7d5c29d","change_number":22212,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"e292062f0428cbe81bd6a72bb44c8a3af93d04e8":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2012-11-04 19:19:05.000000000","uploader":{"_account_id":1000292,"name":"Mark Nunberg","email":"mark.nunberg@couchbase.com","username":"mnunberg","avatars":[{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ea97d1987ed08d8e48e394afae24c122.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/55/22255/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/php-ext-couchbase","ref":"refs/changes/55/22255/3","commands":{"Branch":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/3 \u0026\u0026 git checkout -b change-22255 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/3","Reset To":"git fetch https://review.couchbase.org/php-ext-couchbase refs/changes/55/22255/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"070d2c4d0fce8bdb55aa412d7a7f5ce04a8889e4","subject":"Fixup constants in test due to changes in libcouchbase"}],"author":{"name":"Mark Nunberg","email":"mnunberg@haskalah.org","date":"2012-11-04 18:44:46.000000000","tz":-480},"committer":{"name":"Mordechai Nunberg","email":"mnunberg@haskalah.org","date":"2012-11-04 19:19:05.000000000","tz":0},"subject":"PCBC-140 FDs not being closed on destruction","message":"PCBC-140 FDs not being closed on destruction\n\nMark the self-created iops structure as needing cleanup by lcb\nThis avoids the fd leaks.\n\n(indentation for the entire file is messed up and will be fixed in later\ncommits)\n\nChange-Id: I3558aef0d1fd8d071c5c7fd3f9e86b1c424affb4\nReviewed-on: http://review.couchbase.org/22255\nReviewed-by: Trond Norbye \u003ctrond.norbye@gmail.com\u003e\nTested-by: Mordechai Nunberg \u003cmnunberg@haskalah.org\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"070d2c4d0fce8bdb55aa412d7a7f5ce04a8889e4","is_merged_in_target_branch":true,"change_id":"I72a319c3667e98ea2646a2f244e9d82df7d5c29d","change_number":22212,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}