)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"298558cae108f238360bfa854a50a37aa2424ef1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f4f01c10_b90728a0","updated":"2026-03-20 14:24:23.000000000","message":"You are completely on wrong track\nbucket._system._query we auto create primary index when _query collection present and no primary index.\nSome 7.6.x before we use #primary and then we switched ix_system_query\nwhen upgrade some reason detection not right we endup recreate one more\nIn datastore/couchbase/ check _BUCKET_SYSTEM_PRIM_INDEX around those calls and see","commit_id":"6875f8f7403d2be9af41473131a9cb6de1d66ae4"},{"author":{"_account_id":1000457,"name":"Wayne Siu","email":"wayne@couchbase.com","username":"waynesiu","avatars":[{"url":"https://www.gravatar.com/avatar/c0994de42034e4173d3df112ada61fe8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c0994de42034e4173d3df112ada61fe8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c0994de42034e4173d3df112ada61fe8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c0994de42034e4173d3df112ada61fe8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"32cae1d46ab1ca124ab4c27462e9028dcd58aa33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11312e5d_de31880b","updated":"2026-03-20 16:21:00.000000000","message":"check approval","commit_id":"6875f8f7403d2be9af41473131a9cb6de1d66ae4"},{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e9c8c00cb1301d52df0d5ed021778c4b0d326cf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b41a47d_f594dff3","updated":"2026-03-20 14:33:41.000000000","message":"https://github.com/couchbase/query/blob/master/datastore/couchbase/couchbase.go#L3856\n\nAssume #primary index on bucket._system._query exist now one doing different name \nthis should unnessary\n\ncreate empty bucket\ncreate primary index on bucket._system_query;\n\ninsert few rows and with cbo create index see ix_system_query index created (we should avoid this)","commit_id":"6875f8f7403d2be9af41473131a9cb6de1d66ae4"},{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a9d74d19ee0886f172307e3cf8dbf019c47f1ad0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"299aa091_ab5cd5e0","updated":"2026-03-20 14:38:06.000000000","message":"indexer.PrimaryIndexes() use see if one different name exist and skip","commit_id":"6875f8f7403d2be9af41473131a9cb6de1d66ae4"},{"author":{"_account_id":1005423,"name":"Prashant Joshi","email":"prashant.joshi@couchbase.com","username":"joshiprashanthd","avatars":[{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3e87de05cba5b22b5f0e6a7ad8fe4069f9bbb1dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18b8c9a8_2566f028","in_reply_to":"f4f01c10_b90728a0","updated":"2026-03-20 17:02:22.000000000","message":"Sorry, I thought we want to avoid primary index creation on any collection. My bad, I should have clarified it. I am working on this right now.","commit_id":"6875f8f7403d2be9af41473131a9cb6de1d66ae4"},{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0ab0ee26dad7f1ce35a76fcbd5ee129d6b15eacb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81dca7bd_7632185c","updated":"2026-03-23 13:15:09.000000000","message":"Also make commit message short If need add empty line after first line so that it will be short 1-line","commit_id":"4e6bbe3310bd196988b70089a015eb976d6216fc"},{"author":{"_account_id":1005423,"name":"Prashant Joshi","email":"prashant.joshi@couchbase.com","username":"joshiprashanthd","avatars":[{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e3b9846130f0b89539b1709b4af746bc646b15ed","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de4f6c67_0bc81fb7","in_reply_to":"81dca7bd_7632185c","updated":"2026-03-23 14:33:54.000000000","message":"Now is it correct?","commit_id":"4e6bbe3310bd196988b70089a015eb976d6216fc"},{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"34c59aadc695d41713f00041c7aef4c82957f241","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"51c9ffb0_202e6bd5","in_reply_to":"de4f6c67_0bc81fb7","updated":"2026-03-23 14:48:58.000000000","message":"Done","commit_id":"4e6bbe3310bd196988b70089a015eb976d6216fc"}],"datastore/couchbase/couchbase.go":[{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dc354c3e748a62f2c393652962530581bd56d7d6","unresolved":true,"context_lines":[{"line_number":3551,"context_line":"\tfor _, index :\u003d range primaryIndexes {"},{"line_number":3552,"context_line":"\t\tif index !\u003d nil \u0026\u0026 index.IsPrimary() {"},{"line_number":3553,"context_line":"\t\t\t// skip creating primary index if it already exists"},{"line_number":3554,"context_line":"\t\t\treturn false, nil"},{"line_number":3555,"context_line":"\t\t}"},{"line_number":3556,"context_line":"\t}"},{"line_number":3557,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"0402a02a_6dd13971","line":3554,"updated":"2026-03-23 13:13:07.000000000","message":"return empty, nil","commit_id":"4e6bbe3310bd196988b70089a015eb976d6216fc"},{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"8b29f1a712a6824d83282572d493d8500816e1ce","unresolved":false,"context_lines":[{"line_number":3551,"context_line":"\tfor _, index :\u003d range primaryIndexes {"},{"line_number":3552,"context_line":"\t\tif index !\u003d nil \u0026\u0026 index.IsPrimary() {"},{"line_number":3553,"context_line":"\t\t\t// skip creating primary index if it already exists"},{"line_number":3554,"context_line":"\t\t\treturn false, nil"},{"line_number":3555,"context_line":"\t\t}"},{"line_number":3556,"context_line":"\t}"},{"line_number":3557,"context_line":""}],"source_content_type":"text/x-go","patch_set":3,"id":"14f6d6e2_3aa45b7d","line":3554,"in_reply_to":"0402a02a_6dd13971","updated":"2026-03-25 12:51:35.000000000","message":"Done","commit_id":"4e6bbe3310bd196988b70089a015eb976d6216fc"},{"author":{"_account_id":1004039,"name":"Bingjie Miao","email":"bingjie.miao@couchbase.com","username":"miaobingjie","avatars":[{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1901c3b129e94ad4a44321d1b3b816b1fbc6e309","unresolved":true,"context_lines":[{"line_number":3543,"context_line":"\t\treturn false, errors.NewInvalidGSIIndexerError(\"Cannot get primary index on system collection\")"},{"line_number":3544,"context_line":"\t}"},{"line_number":3545,"context_line":""},{"line_number":3546,"context_line":"\tprimaryIndexes, err :\u003d indexer3.PrimaryIndexes()"},{"line_number":3547,"context_line":"\tif err !\u003d nil {"},{"line_number":3548,"context_line":"\t\treturn false, err"},{"line_number":3549,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"227d652e_9d3f8198","line":3546,"range":{"start_line":3546,"start_character":1,"end_line":3546,"end_character":49},"updated":"2026-03-23 15:54:22.000000000","message":"We will also need to check for index state (ONLINE) before return, similar to the code at lines 3578-3591 below.\nInstead of duplicating that code, how about something like this:\nindexName :\u003d _BUCKET_SYSTEM_PRIM_INDEX\n-- get primary indexes list here\nfor _, index :\u003d range primaryIndexes {\n    if index.IsPrimary() {\n        indexName \u003d index.Name() // we don\u0027t expect more than one primary index\n        break\n    }\n}\n-- continue with remaining code in this function, expect replace the hard-coded name _BUCKET_SYSTEM_PRIM_INDEX with the new local variable indexName (maybe except line 3567, if we need to create a new primary index, use the hard-coded name).","commit_id":"922c8d70c17bb1004a940a53ca70d8d2d88349ca"},{"author":{"_account_id":1005423,"name":"Prashant Joshi","email":"prashant.joshi@couchbase.com","username":"joshiprashanthd","avatars":[{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/d61ec350c3e2fb15f25c5f8797b7b7be.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3e6c19faa3fb1ec8552af20e9bd7994d7427a77d","unresolved":false,"context_lines":[{"line_number":3543,"context_line":"\t\treturn false, errors.NewInvalidGSIIndexerError(\"Cannot get primary index on system collection\")"},{"line_number":3544,"context_line":"\t}"},{"line_number":3545,"context_line":""},{"line_number":3546,"context_line":"\tprimaryIndexes, err :\u003d indexer3.PrimaryIndexes()"},{"line_number":3547,"context_line":"\tif err !\u003d nil {"},{"line_number":3548,"context_line":"\t\treturn false, err"},{"line_number":3549,"context_line":"\t}"}],"source_content_type":"text/x-go","patch_set":5,"id":"646c2f03_0adb00d2","line":3546,"range":{"start_line":3546,"start_character":1,"end_line":3546,"end_character":49},"in_reply_to":"227d652e_9d3f8198","updated":"2026-03-24 09:36:44.000000000","message":"Acknowledged","commit_id":"922c8d70c17bb1004a940a53ca70d8d2d88349ca"}]}