)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"041f34ebae36ca9a3f2549490b83435145cc167e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12a35a27_b9f055d2","updated":"2026-03-23 13:05:50.000000000","message":"Add here too https://github.com/couchbase/n1fty/blob/master/flex/whitebox/wrap.go#L183","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"},{"author":{"_account_id":1004039,"name":"Bingjie Miao","email":"bingjie.miao@couchbase.com","username":"miaobingjie","avatars":[{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6dfd02056cca2c60cbeb6c5b99b274867508c686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e5a5927c_1a4f7484","updated":"2026-03-23 22:21:08.000000000","message":"For changing datastore interface you will also need to modify in n1fty (wrap datastore).","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"},{"author":{"_account_id":1004943,"name":"Dhanya Gowrish","email":"dhanya.gowrish@couchbase.com","username":"dhanyagowrish","avatars":[{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3e57d89960915d85d72d6f2236c9a81800f8c540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e15f0c39_8f19f217","in_reply_to":"12a35a27_b9f055d2","updated":"2026-03-24 08:31:18.000000000","message":"Thanks. Done.","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"},{"author":{"_account_id":1004943,"name":"Dhanya Gowrish","email":"dhanya.gowrish@couchbase.com","username":"dhanyagowrish","avatars":[{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3e57d89960915d85d72d6f2236c9a81800f8c540","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d6d2109_d1f299cf","in_reply_to":"e5a5927c_1a4f7484","updated":"2026-03-24 08:31:18.000000000","message":"Thanks.Done.","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"}],"datastore/file/file.go":[{"author":{"_account_id":1004039,"name":"Bingjie Miao","email":"bingjie.miao@couchbase.com","username":"miaobingjie","avatars":[{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/8415a29671dde0ccaada0a25e2bc6c0d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"60617766330ecb3e2659d5de7026312cfcb5069c","unresolved":true,"context_lines":[{"line_number":282,"context_line":"}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"func (s *store) EncryptionProvider() (datastore.EncryptionProvider, errors.Error) {"},{"line_number":285,"context_line":"\treturn \u0026datastore.NoopEncryptionProvider{}, nil"},{"line_number":286,"context_line":"}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"func (s *store) SetEncryptionProvider(datastore.EncryptionProvider) {"}],"source_content_type":"text/x-go","patch_set":2,"id":"83d57863_7717fecb","line":285,"range":{"start_line":285,"start_character":8,"end_line":285,"end_character":41},"updated":"2026-03-23 21:47:17.000000000","message":"define a const for this in datastore?","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"},{"author":{"_account_id":1004943,"name":"Dhanya Gowrish","email":"dhanya.gowrish@couchbase.com","username":"dhanyagowrish","avatars":[{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b3c398aec68f5cb9fb016b5736ffb99ec800e6b4","unresolved":false,"context_lines":[{"line_number":282,"context_line":"}"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"func (s *store) EncryptionProvider() (datastore.EncryptionProvider, errors.Error) {"},{"line_number":285,"context_line":"\treturn \u0026datastore.NoopEncryptionProvider{}, nil"},{"line_number":286,"context_line":"}"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"func (s *store) SetEncryptionProvider(datastore.EncryptionProvider) {"}],"source_content_type":"text/x-go","patch_set":2,"id":"d8b671d4_2b33faac","line":285,"range":{"start_line":285,"start_character":8,"end_line":285,"end_character":41},"in_reply_to":"83d57863_7717fecb","updated":"2026-03-24 08:30:50.000000000","message":"Done","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"}],"server/cbq-engine/main.go":[{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abc1f6d9af2acac80f49462a2e5ac33afd277d56","unresolved":true,"context_lines":[{"line_number":445,"context_line":"\tconstructor.Init(endpoint.Router(), server.Servicers(), \"\")"},{"line_number":446,"context_line":"\ttenant.Start(endpoint, *UUID, *REGULATOR_SETTINGS_FILE)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"\t// EAR TODO - un-comment the following block once ns-server begins to push the required datatypes of keys to Query"},{"line_number":449,"context_line":"\t/*"},{"line_number":450,"context_line":"\t\tencryptionMgr :\u003d keymgmt.NewEncryptionManager()"},{"line_number":451,"context_line":"\t\tdatastore.SetEncryptionProvider(encryptionMgr)"}],"source_content_type":"text/x-go","patch_set":2,"id":"a42c9231_96ea3334","line":448,"updated":"2026-03-23 13:21:27.000000000","message":"Why don\u0027t move this same place as we do TLS certificate call backs vs all callback functions here","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"},{"author":{"_account_id":1003727,"name":"Sitaram Vemulapalli","email":"sitaram.vemulapalli@couchbase.com","username":"sitaramv","avatars":[{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/772a8efba79d35c7d2e3ab25bad15dea.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1cf6d794d3c1ff461e1730804597561a9f8a6e8e","unresolved":false,"context_lines":[{"line_number":445,"context_line":"\tconstructor.Init(endpoint.Router(), server.Servicers(), \"\")"},{"line_number":446,"context_line":"\ttenant.Start(endpoint, *UUID, *REGULATOR_SETTINGS_FILE)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"\t// EAR TODO - un-comment the following block once ns-server begins to push the required datatypes of keys to Query"},{"line_number":449,"context_line":"\t/*"},{"line_number":450,"context_line":"\t\tencryptionMgr :\u003d keymgmt.NewEncryptionManager()"},{"line_number":451,"context_line":"\t\tdatastore.SetEncryptionProvider(encryptionMgr)"}],"source_content_type":"text/x-go","patch_set":2,"id":"bae53cd8_77aa0867","line":448,"in_reply_to":"51e0c032_63400ce0","updated":"2026-03-24 11:19:47.000000000","message":"Done","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"},{"author":{"_account_id":1004943,"name":"Dhanya Gowrish","email":"dhanya.gowrish@couchbase.com","username":"dhanyagowrish","avatars":[{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/fbecd60794575c727a3d5a1e994d7e66.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b3c398aec68f5cb9fb016b5736ffb99ec800e6b4","unresolved":true,"context_lines":[{"line_number":445,"context_line":"\tconstructor.Init(endpoint.Router(), server.Servicers(), \"\")"},{"line_number":446,"context_line":"\ttenant.Start(endpoint, *UUID, *REGULATOR_SETTINGS_FILE)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"\t// EAR TODO - un-comment the following block once ns-server begins to push the required datatypes of keys to Query"},{"line_number":449,"context_line":"\t/*"},{"line_number":450,"context_line":"\t\tencryptionMgr :\u003d keymgmt.NewEncryptionManager()"},{"line_number":451,"context_line":"\t\tdatastore.SetEncryptionProvider(encryptionMgr)"}],"source_content_type":"text/x-go","patch_set":2,"id":"51e0c032_63400ce0","line":448,"in_reply_to":"a42c9231_96ea3334","updated":"2026-03-24 08:30:50.000000000","message":"I kept the encryption at rest callback registration separate from TLS callback registration in order to separate the concerns. \n\nAdditionally, TLS ceritificare callback is registered after the non-secure listener is brought up.\n\nTLS callback registration - https://github.com/couchbase/query/blob/ad5e0a275bef267c477a90695818f994b109ec5e/server/cbq-engine/main.go#L456\nNon-secure listener start - https://github.com/couchbase/query/blob/ad5e0a275bef267c477a90695818f994b109ec5e/server/cbq-engine/main.go#L450\n\nBut I want to make sure that the encryption callbacks are registered before the secure and non-secure listeners are started.","commit_id":"62c731411d90606e465e39347eb87677e29b7b27"}]}