)]}'
{"src/main/java/net/spy/memcached/ops/ErrorCode.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7e79196798cf99ddcfdba6a82b6d299fdf2336f5","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  public static ErrorCode getErrorCode(byte b) {"},{"line_number":133,"context_line":"    if (b \u003d\u003d ErrorCode.SUCCESS.error) {"},{"line_number":134,"context_line":"      return ErrorCode.SUCCESS;"},{"line_number":135,"context_line":"    } else if (b \u003d\u003d ErrorCode.ERR_NOT_FOUND.error) {"},{"line_number":136,"context_line":"      return ErrorCode.ERR_NOT_FOUND;"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABmn%2F%2F%2F1s%3D","line":133,"updated":"2012-05-26 18:18:16.000000000","message":"The compiler may take care of it for you, but a switch would usually be more efficient.","commit_id":"c83bf3aa95a68cfbd64d951904cc0af9df358bd3"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b285a4ead8b25d69af9845d80a012a93f86977b7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  public static ErrorCode getErrorCode(byte b) {"},{"line_number":133,"context_line":"    if (b \u003d\u003d ErrorCode.SUCCESS.error) {"},{"line_number":134,"context_line":"      return ErrorCode.SUCCESS;"},{"line_number":135,"context_line":"    } else if (b \u003d\u003d ErrorCode.ERR_NOT_FOUND.error) {"},{"line_number":136,"context_line":"      return ErrorCode.ERR_NOT_FOUND;"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABmn%2F%2F%2Bcg%3D","line":133,"in_reply_to":"AAABmn%2F%2F%2F1Y%3D","updated":"2012-06-01 22:55:55.000000000","message":"Error is \"case expressions must be constant expressions\"\n\nIn the other Enums we do things just like this.","commit_id":"c83bf3aa95a68cfbd64d951904cc0af9df358bd3"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fd45fe3a1e83111b14ba671f49bb72cb9ac6ec9b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  public static ErrorCode getErrorCode(byte b) {"},{"line_number":133,"context_line":"    if (b \u003d\u003d ErrorCode.SUCCESS.error) {"},{"line_number":134,"context_line":"      return ErrorCode.SUCCESS;"},{"line_number":135,"context_line":"    } else if (b \u003d\u003d ErrorCode.ERR_NOT_FOUND.error) {"},{"line_number":136,"context_line":"      return ErrorCode.ERR_NOT_FOUND;"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABmn%2F%2F%2F1Y%3D","line":133,"in_reply_to":"AAABmn%2F%2F%2F1s%3D","updated":"2012-05-26 18:27:42.000000000","message":"I wanted to do this, but there was a strange compile error that wouldn\u0027t let me. I\u0027ll try one more time and let you know what there error was if I can\u0027t make it happen.","commit_id":"c83bf3aa95a68cfbd64d951904cc0af9df358bd3"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7e79196798cf99ddcfdba6a82b6d299fdf2336f5","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    }  else if (b \u003d\u003d ErrorCode.ERR_TEMP_FAIL.error) {"},{"line_number":164,"context_line":"      return ErrorCode.ERR_TEMP_FAIL;"},{"line_number":165,"context_line":"    }"},{"line_number":166,"context_line":"    return null;"},{"line_number":167,"context_line":"  }"},{"line_number":168,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABmn%2F%2F%2F1w%3D","line":166,"updated":"2012-05-26 18:18:16.000000000","message":"Are you sure we want to return null and not throw an exception?\n\nThis could easily have a unit test for known values.","commit_id":"c83bf3aa95a68cfbd64d951904cc0af9df358bd3"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fd45fe3a1e83111b14ba671f49bb72cb9ac6ec9b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    }  else if (b \u003d\u003d ErrorCode.ERR_TEMP_FAIL.error) {"},{"line_number":164,"context_line":"      return ErrorCode.ERR_TEMP_FAIL;"},{"line_number":165,"context_line":"    }"},{"line_number":166,"context_line":"    return null;"},{"line_number":167,"context_line":"  }"},{"line_number":168,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABmn%2F%2F%2F1U%3D","line":166,"in_reply_to":"AAABmn%2F%2F%2F1w%3D","updated":"2012-05-26 18:27:42.000000000","message":"I did null in case we forgot to catch something or new error code was added to memcached and we didn\u0027t catch it. I figured it might be better to let the client continue execution. An exception would cause a reconnect. I am open to changing it though if you think an exception would be better.","commit_id":"c83bf3aa95a68cfbd64d951904cc0af9df358bd3"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ba7925989f9d0f7c02b0d940bf8dfe8d4fe2cbfa","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  /**"},{"line_number":110,"context_line":"   * THIS IS A CLIENT SPECIFIC ERROR CODE."},{"line_number":111,"context_line":"   * The client recieved an unknow error code from the server."},{"line_number":112,"context_line":"   */"},{"line_number":113,"context_line":"  UNKNOWN_ERROR((byte) 0xF0),"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABmn%2F%2F%2BME%3D","line":111,"updated":"2012-06-04 02:27:23.000000000","message":"Typo.  Should be \"unknown\"","commit_id":"e3b87826fc2c931e47ef40524f745b0c82b8f18b"}],"src/main/java/net/spy/memcached/protocol/binary/OperationImpl.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7e79196798cf99ddcfdba6a82b6d299fdf2336f5","unresolved":false,"context_lines":[{"line_number":178,"context_line":"   */"},{"line_number":179,"context_line":"  protected OperationStatus getStatusForErrorCode(int errCode, byte[] errPl)"},{"line_number":180,"context_line":"    throws IOException {"},{"line_number":181,"context_line":"    switch (ErrorCode.getErrorCode((byte)errCode)) {"},{"line_number":182,"context_line":"    case SUCCESS:"},{"line_number":183,"context_line":"      return STATUS_OK;"},{"line_number":184,"context_line":"    case ERR_NOT_FOUND:"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABmn%2F%2F%2F1o%3D","line":181,"updated":"2012-05-26 18:18:16.000000000","message":"Should there be a method that just takes errCode as a byte rather than having to do this cast?\n\nPossible NPE here.","commit_id":"c83bf3aa95a68cfbd64d951904cc0af9df358bd3"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b285a4ead8b25d69af9845d80a012a93f86977b7","unresolved":false,"context_lines":[{"line_number":178,"context_line":"   */"},{"line_number":179,"context_line":"  protected OperationStatus getStatusForErrorCode(int errCode, byte[] errPl)"},{"line_number":180,"context_line":"    throws IOException {"},{"line_number":181,"context_line":"    switch (ErrorCode.getErrorCode((byte)errCode)) {"},{"line_number":182,"context_line":"    case SUCCESS:"},{"line_number":183,"context_line":"      return STATUS_OK;"},{"line_number":184,"context_line":"    case ERR_NOT_FOUND:"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABmn%2F%2F%2BcU%3D","line":181,"in_reply_to":"AAABmn%2F%2F%2F1Q%3D","updated":"2012-06-01 22:55:55.000000000","message":"ErrorCodes are shorts. I can change my code to match this.","commit_id":"c83bf3aa95a68cfbd64d951904cc0af9df358bd3"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fd45fe3a1e83111b14ba671f49bb72cb9ac6ec9b","unresolved":false,"context_lines":[{"line_number":178,"context_line":"   */"},{"line_number":179,"context_line":"  protected OperationStatus getStatusForErrorCode(int errCode, byte[] errPl)"},{"line_number":180,"context_line":"    throws IOException {"},{"line_number":181,"context_line":"    switch (ErrorCode.getErrorCode((byte)errCode)) {"},{"line_number":182,"context_line":"    case SUCCESS:"},{"line_number":183,"context_line":"      return STATUS_OK;"},{"line_number":184,"context_line":"    case ERR_NOT_FOUND:"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABmn%2F%2F%2F1Q%3D","line":181,"in_reply_to":"AAABmn%2F%2F%2F1o%3D","updated":"2012-05-26 18:27:42.000000000","message":"Not exactly sure what you mean here? Are you saying this function should be getStatusForErrorCode(byte, byte[])?","commit_id":"c83bf3aa95a68cfbd64d951904cc0af9df358bd3"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2d6fdfd57a08f91b37e68df4f5b9bc16c2743f3d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          : \"Unexpected response command value\";"},{"line_number":121,"context_line":"        keyLen \u003d decodeShort(header, 2);"},{"line_number":122,"context_line":"        // TODO: Examine extralen and datatype"},{"line_number":123,"context_line":"        errorCode \u003d (short) decodeShort(header, 6);"},{"line_number":124,"context_line":"        int bytesToRead \u003d decodeInt(header, 8);"},{"line_number":125,"context_line":"        payload \u003d new byte[bytesToRead];"},{"line_number":126,"context_line":"        responseOpaque \u003d decodeInt(header, 12);"}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABmn%2F%2F%2BL4%3D","line":123,"updated":"2012-06-04 02:38:45.000000000","message":"Weird.","commit_id":"a7bc48c6beedabfc1e442d4bd7079d4b18bd0252"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2d6fdfd57a08f91b37e68df4f5b9bc16c2743f3d","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"  protected void finishedPayload(byte[] pl) throws IOException {"},{"line_number":156,"context_line":"    OperationStatus status \u003d getStatusForErrorCode(errorCode, pl);"},{"line_number":157,"context_line":"    ErrorCode ec \u003d ErrorCode.getErrorCode(errorCode);"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    if (status \u003d\u003d null) {"},{"line_number":160,"context_line":"      handleError(OperationErrorType.SERVER, new String(pl));"}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABmn%2F%2F%2BL0%3D","line":157,"updated":"2012-06-04 02:38:45.000000000","message":"Much better.","commit_id":"a7bc48c6beedabfc1e442d4bd7079d4b18bd0252"}]}