)]}'
{"src/main/java/net/spy/memcached/MemcachedConnection.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"97580aff2dd4d3172f10d6f6f00147fbe7e70085","unresolved":false,"context_lines":[{"line_number":377,"context_line":"      getLogger().debug(\"Handling IO for:  %s (r\u003d%s, w\u003d%s, c\u003d%s, op\u003d%s)\", sk,"},{"line_number":378,"context_line":"              sk.isReadable(), sk.isWritable(), sk.isConnectable(),"},{"line_number":379,"context_line":"              sk.attachment());"},{"line_number":380,"context_line":"      if (sk.isConnectable()) {"},{"line_number":381,"context_line":"        getLogger().info(\"Connection state changed for %s\", sk);"},{"line_number":382,"context_line":"        final SocketChannel channel \u003d node.getChannel();"},{"line_number":383,"context_line":"        if (channel.finishConnect()) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAACAn%2F%2F4JM%3D","side":"PARENT","line":380,"updated":"2013-01-30 06:02:28.000000000","message":"Will we never end up back in here more than once?  I just worry that our IO thread will potentially have data unread, and the selecton key will still be \"ready\".  I don\u0027t know NIO that well though.  each belongsToCluster() invocation will be a walk of a hashmap though.","commit_id":"821844d72c47812de4823bc9632baf830e835c83"},{"author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ad478cf22170ed56011cbd0ae73b2e2ad18be7c3","unresolved":false,"context_lines":[{"line_number":377,"context_line":"      getLogger().debug(\"Handling IO for:  %s (r\u003d%s, w\u003d%s, c\u003d%s, op\u003d%s)\", sk,"},{"line_number":378,"context_line":"              sk.isReadable(), sk.isWritable(), sk.isConnectable(),"},{"line_number":379,"context_line":"              sk.attachment());"},{"line_number":380,"context_line":"      if (sk.isConnectable()) {"},{"line_number":381,"context_line":"        getLogger().info(\"Connection state changed for %s\", sk);"},{"line_number":382,"context_line":"        final SocketChannel channel \u003d node.getChannel();"},{"line_number":383,"context_line":"        if (channel.finishConnect()) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAACAn%2F%2F4IA%3D","side":"PARENT","line":380,"in_reply_to":"AAACAn%2F%2F4JM%3D","updated":"2013-01-30 09:52:06.000000000","message":"this will only run when it actually tries to connect. sk.isConnectable() returns false when connected and therefore it never reaches belongstocluster().","commit_id":"821844d72c47812de4823bc9632baf830e835c83"}],"src/test/java/net/spy/memcached/MemcachedConnectionTest.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"97580aff2dd4d3172f10d6f6f00147fbe7e70085","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    MemcachedConnection conn \u003d new MemcachedConnection("},{"line_number":59,"context_line":"      100, factory, nodes, observers, FailureMode.Retry, opfactory);"},{"line_number":60,"context_line":"    assertTrue(conn.belongsToCluster(node));"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAACAn%2F%2F4JQ%3D","line":60,"updated":"2013-01-30 06:02:28.000000000","message":"what about testing the negative case?","commit_id":"e041b6746f1aaf9e1b792ad4df392f4cfb30b9df"},{"author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ad478cf22170ed56011cbd0ae73b2e2ad18be7c3","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    MemcachedConnection conn \u003d new MemcachedConnection("},{"line_number":59,"context_line":"      100, factory, nodes, observers, FailureMode.Retry, opfactory);"},{"line_number":60,"context_line":"    assertTrue(conn.belongsToCluster(node));"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAACAn%2F%2F4H8%3D","line":60,"in_reply_to":"AAACAn%2F%2F4JQ%3D","updated":"2013-01-30 09:52:06.000000000","message":"jup, need to add it.","commit_id":"e041b6746f1aaf9e1b792ad4df392f4cfb30b9df"}]}