)]}'
{"id":"spymemcached~36219","triplet_id":"spymemcached~master~I7ebda58c2eadd62d8885e3eeac79d5a971e07979","project":"spymemcached","branch":"master","hashtags":[],"change_id":"I7ebda58c2eadd62d8885e3eeac79d5a971e07979","subject":"SPY-167: Avoid deadlock on notify listeners.","status":"MERGED","created":"2014-04-23 14:57:43.000000000","updated":"2014-05-05 15:14:17.000000000","submitted":"2014-05-05 15:14:17.000000000","submitter":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e35861d61d65a69a0932c516e186895faa481299","_number":36219,"virtual_id_number":36219,"owner":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":1,"date":"2014-05-05 15:14:17.000000000","_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":0,"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":2,"date":"2014-05-05 15:14:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-05-05 06:04:19.000000000","updated_by":{"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"},{"updated":"2014-05-05 15:13:46.000000000","updated_by":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"632aca1ddd190102b2628125bb5d356da50b561e","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-23 14:57:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"545a2570ff37217d539276fbcfa4027920f30e11","author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-23 15:08:40.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"9cd497aeb8e443b06d78be296bee2c411ece45ae","author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-23 15:09:21.000000000","message":"Patch Set 1:\n\nI\u0027m sure like you I\u0027d feel better with a test that demonstrates the fix in the situation encountered, but I don\u0027t see any harm here.","accounts_in_message":[],"_revision_number":1},{"id":"a3498ceff74b1edd6aea7bd735c9613de17d81a8","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-23 15:15:58.000000000","message":"Patch Set 1:\n\ndefinitely. I tried to reproduce it some time ago when it was reported on google code, but no luck. That\u0027s why I was \"happy\" that we saw it here again.","accounts_in_message":[],"_revision_number":1},{"id":"e49e63f1247672190f78617f34f4e2a8270bb78a","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-24 07:40:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f712bae0d25e0bcc0406848112fa73eb251066f7","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-24 07:42:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3ad4940721a1fdf4017e07c983ed1d145aaf3e2e","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-25 06:53:33.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4f407aa27a01d98ba8b67391a31e61dacba0f690","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-25 07:12:06.000000000","message":"Patch Set 5: Commit message was updated","accounts_in_message":[],"_revision_number":5},{"id":"7a9fe55365354c6547b0ce7a899f9f55a79103fb","author":{"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-04-25 07:12:10.000000000","message":"Patch Set 5:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":5},{"id":"fdb384d676caed582cb7cd52e6428415ce146a5c","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-05-05 06:04:15.000000000","message":"Patch Set 6: Commit message was updated","accounts_in_message":[],"_revision_number":6},{"id":"03604e850dfec88b95133f1cdcd261be49ff403c","author":{"_account_id":1000289,"name":"Gerrit User","email":"gerrit@couchbase.com","username":"gerrit","avatars":[{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aa6f2dbc8eea1a3e0acd444a0d96f12b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-05-05 06:04:19.000000000","message":"Patch Set 6:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":6},{"id":"f0899c0ff315d8d73d467c71471198f353448860","author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-05-05 15:00:23.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"186c00f31b3fb6cfd4b877111eb8d186e6efb518","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-05-05 15:13:31.000000000","message":"Patch Set 7: Patch Set 6 was rebased","accounts_in_message":[],"_revision_number":6},{"id":"0d69c69177e98fba431a0161e43b12e3a64076b0","author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-05-05 15:13:46.000000000","message":"Patch Set 7: Code-Review+2\n\nAutomatically re-added by Gerrit trivial rebase detection script.","accounts_in_message":[],"_revision_number":7},{"id":"b123bc819101fc1b11db90d6f7845d504438f2b1","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-05-05 15:14:16.000000000","message":"Patch Set 7: Verified+1","accounts_in_message":[],"_revision_number":7},{"id":"e35861d61d65a69a0932c516e186895faa481299","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-05-05 15:14:17.000000000","message":"Change has been successfully cherry-picked as df81f17302b520413d5e71713804efbf4f76bfa9","accounts_in_message":[],"_revision_number":8}],"current_revision_number":8,"current_revision":"df81f17302b520413d5e71713804efbf4f76bfa9","revisions":{"1ab608f63d8aeafed29c1a91afa556c13a2e638f":{"kind":"REWORK","_number":1,"created":"2014-04-23 14:57:43.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/36219/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/19/36219/1","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/1 \u0026\u0026 git checkout -b change-36219 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/19/36219/1","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f2c370fba4374a5828fcab36df45b313c62d7cf7","subject":"SPY-162: Also respect nagle setting on reconnect."}],"author":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"committer":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"subject":"Pending Verification: Widen Listener lock to avoid deadlock","message":"Pending Verification: Widen Listener lock to avoid deadlock\n\nMotivation\n----------\nBecause of how the addListener and notifyListener works, it could be that\none deadlocks each other because they are waiting on the same locks from\ndifferent threads.\n\nModifications\n-------------\nThe lock is widened to a method-wide synchronization to avoid potential\ninner-method deadlocks.\n\nResult\n------\nSince the lock is widened, there should be no inner deadlocks anymore.\n\nChange-Id: I7ebda58c2eadd62d8885e3eeac79d5a971e07979\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f2c370fba4374a5828fcab36df45b313c62d7cf7","is_merged_in_target_branch":true,"change_id":"Ic0b513b8538a39710aaf8fd0f0f699a5c561bc09","change_number":35553,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"601fb66f64a8613881fcb02795a931668c969103":{"kind":"REWORK","_number":2,"created":"2014-04-24 07:40:56.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/36219/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/19/36219/2","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/2 \u0026\u0026 git checkout -b change-36219 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/19/36219/2","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f2c370fba4374a5828fcab36df45b313c62d7cf7","subject":"SPY-162: Also respect nagle setting on reconnect."}],"author":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"committer":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-24 07:39:13.000000000","tz":120},"subject":"Pending Verification: Avoid deadlock on notify listeners.","message":"Pending Verification: Avoid deadlock on notify listeners.\n\nMotivation\n----------\nBecause of how the addListener and notifyListener works, it could be that\none deadlocks each other because they are waiting on the same locks from\ndifferent threads.\n\nModifications\n-------------\nThe listeners are copied before notified, moving it out of the synch block.\n\nResult\n------\nSince notify is not synched anymore, the lock should be not happening anymore.\n\nNote that also the listeners array is set to empty which avoid notifying listeners\nmore than once potentially.\n\nChange-Id: I7ebda58c2eadd62d8885e3eeac79d5a971e07979\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f2c370fba4374a5828fcab36df45b313c62d7cf7","is_merged_in_target_branch":true,"change_id":"Ic0b513b8538a39710aaf8fd0f0f699a5c561bc09","change_number":35553,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"7b2c89fe7ba586e70fa24d46e6de1a77366a0e7d":{"kind":"REWORK","_number":3,"created":"2014-04-24 07:42:43.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/36219/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/19/36219/3","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/3 \u0026\u0026 git checkout -b change-36219 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/19/36219/3","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f2c370fba4374a5828fcab36df45b313c62d7cf7","subject":"SPY-162: Also respect nagle setting on reconnect."}],"author":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"committer":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-24 07:42:37.000000000","tz":120},"subject":"Pending Verification: Avoid deadlock on notify listeners.","message":"Pending Verification: Avoid deadlock on notify listeners.\n\nMotivation\n----------\nBecause of how the addListener and notifyListener works, it could be that\none deadlocks each other because they are waiting on the same locks from\ndifferent threads.\n\nModifications\n-------------\nThe listeners are copied before notified, moving it out of the synch block.\n\nResult\n------\nSince notify is not synched anymore, the lock should be not happening anymore.\n\nNote that also the listeners array is set to empty which avoid notifying listeners\nmore than once potentially.\n\nChange-Id: I7ebda58c2eadd62d8885e3eeac79d5a971e07979\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f2c370fba4374a5828fcab36df45b313c62d7cf7","is_merged_in_target_branch":true,"change_id":"Ic0b513b8538a39710aaf8fd0f0f699a5c561bc09","change_number":35553,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"aee3178e162488e2cb24a1dd9cdb5059b92f37bd":{"kind":"REWORK","_number":4,"created":"2014-04-25 06:53:33.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/36219/4","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/19/36219/4","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/4 \u0026\u0026 git checkout -b change-36219 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/19/36219/4","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f2c370fba4374a5828fcab36df45b313c62d7cf7","subject":"SPY-162: Also respect nagle setting on reconnect."}],"author":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"committer":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-25 06:53:15.000000000","tz":120},"subject":"Pending Verification: Avoid deadlock on notify listeners.","message":"Pending Verification: Avoid deadlock on notify listeners.\n\nMotivation\n----------\nBecause of how the addListener and notifyListener works, it could be that\none deadlocks each other because they are waiting on the same locks from\ndifferent threads.\n\nModifications\n-------------\nThe listeners are copied before notified, moving it out of the synch block.\n\nResult\n------\nSince notify is not synched anymore, the lock should be not happening anymore.\n\nNote that also the listeners array is set to empty which avoid notifying listeners\nmore than once potentially.\n\nChange-Id: I7ebda58c2eadd62d8885e3eeac79d5a971e07979\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f2c370fba4374a5828fcab36df45b313c62d7cf7","is_merged_in_target_branch":true,"change_id":"Ic0b513b8538a39710aaf8fd0f0f699a5c561bc09","change_number":35553,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"87d21a9d60f1cdd1ca3b6c9ca2d368a42346d753":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2014-04-25 07:12:06.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/36219/5","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/19/36219/5","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/5 \u0026\u0026 git checkout -b change-36219 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/19/36219/5","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/5 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f2c370fba4374a5828fcab36df45b313c62d7cf7","subject":"SPY-162: Also respect nagle setting on reconnect."}],"author":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"committer":{"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","date":"2014-04-25 07:12:06.000000000","tz":0},"subject":"SPY-167: Avoid deadlock on notify listeners.","message":"SPY-167: Avoid deadlock on notify listeners.\n\nMotivation\n----------\nBecause of how the addListener and notifyListener works, it could be that\none deadlocks each other because they are waiting on the same locks from\ndifferent threads.\n\nModifications\n-------------\nThe listeners are copied before notified, moving it out of the synch block.\n\nResult\n------\nSince notify is not synched anymore, the lock should be not happening anymore.\n\nNote that also the listeners array is set to empty which avoid notifying listeners\nmore than once potentially.\n\nChange-Id: I7ebda58c2eadd62d8885e3eeac79d5a971e07979\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f2c370fba4374a5828fcab36df45b313c62d7cf7","is_merged_in_target_branch":true,"change_id":"Ic0b513b8538a39710aaf8fd0f0f699a5c561bc09","change_number":35553,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"6be98e198091c0d0ff8e8ba25fb6c4364980e86d":{"kind":"NO_CODE_CHANGE","_number":6,"created":"2014-05-05 06:04:14.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/36219/6","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/19/36219/6","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/6 \u0026\u0026 git checkout -b change-36219 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/19/36219/6","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/6 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"f2c370fba4374a5828fcab36df45b313c62d7cf7","subject":"SPY-162: Also respect nagle setting on reconnect."}],"author":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"committer":{"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","date":"2014-05-05 06:04:14.000000000","tz":0},"subject":"SPY-167: Avoid deadlock on notify listeners.","message":"SPY-167: Avoid deadlock on notify listeners.\n\nMotivation\n----------\nBecause of how the addListener and notifyListener works, it could be that\none deadlocks each other because they are waiting on the same locks from\ndifferent threads.\n\nModifications\n-------------\nThe listeners are copied before notified, moving it out of the synch block.\n\nResult\n------\nSince notify is not synched anymore, the lock should be not happening anymore.\n\nNote that also the listeners array is set to empty which avoid notifying listeners\nmore than once potentially.\n\nThanks to @adamhonen for pointing out the fix.\n\nChange-Id: I7ebda58c2eadd62d8885e3eeac79d5a971e07979\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f2c370fba4374a5828fcab36df45b313c62d7cf7","is_merged_in_target_branch":true,"change_id":"Ic0b513b8538a39710aaf8fd0f0f699a5c561bc09","change_number":35553,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"d56dea3eef834a889bbf5763d31081508ba6adce":{"kind":"TRIVIAL_REBASE","_number":7,"created":"2014-05-05 15:13:31.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/36219/7","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/19/36219/7","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/7 \u0026\u0026 git checkout -b change-36219 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/19/36219/7","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/7 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"386a843c57e9b61629e2d07887a0bf0eab37ad43","subject":"SPY-168: isJSONObject should handle null or empty input values."}],"author":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"committer":{"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","date":"2014-05-05 15:13:30.000000000","tz":0},"subject":"SPY-167: Avoid deadlock on notify listeners.","message":"SPY-167: Avoid deadlock on notify listeners.\n\nMotivation\n----------\nBecause of how the addListener and notifyListener works, it could be that\none deadlocks each other because they are waiting on the same locks from\ndifferent threads.\n\nModifications\n-------------\nThe listeners are copied before notified, moving it out of the synch block.\n\nResult\n------\nSince notify is not synched anymore, the lock should be not happening anymore.\n\nNote that also the listeners array is set to empty which avoid notifying listeners\nmore than once potentially.\n\nThanks to @adamhonen for pointing out the fix.\n\nChange-Id: I7ebda58c2eadd62d8885e3eeac79d5a971e07979\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"386a843c57e9b61629e2d07887a0bf0eab37ad43","is_merged_in_target_branch":true,"change_id":"Icaca2f3fef658cdb2c376b6b4dba12ae0327f240","change_number":36695,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"df81f17302b520413d5e71713804efbf4f76bfa9":{"kind":"NO_CODE_CHANGE","_number":8,"created":"2014-05-05 15:14:17.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/19/36219/8","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/19/36219/8","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/8 \u0026\u0026 git checkout -b change-36219 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/19/36219/8","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/19/36219/8 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"386a843c57e9b61629e2d07887a0bf0eab37ad43","subject":"SPY-168: isJSONObject should handle null or empty input values."}],"author":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2014-04-23 14:52:12.000000000","tz":120},"committer":{"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","date":"2014-05-05 15:14:17.000000000","tz":0},"subject":"SPY-167: Avoid deadlock on notify listeners.","message":"SPY-167: Avoid deadlock on notify listeners.\n\nMotivation\n----------\nBecause of how the addListener and notifyListener works, it could be that\none deadlocks each other because they are waiting on the same locks from\ndifferent threads.\n\nModifications\n-------------\nThe listeners are copied before notified, moving it out of the synch block.\n\nResult\n------\nSince notify is not synched anymore, the lock should be not happening anymore.\n\nNote that also the listeners array is set to empty which avoid notifying listeners\nmore than once potentially.\n\nThanks to @adamhonen for pointing out the fix.\n\nChange-Id: I7ebda58c2eadd62d8885e3eeac79d5a971e07979\nReviewed-on: http://review.couchbase.org/36219\nReviewed-by: Matt Ingenthron \u003cmatt@couchbase.com\u003e\nTested-by: Michael Nitschinger \u003cmichael.nitschinger@couchbase.com\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"386a843c57e9b61629e2d07887a0bf0eab37ad43","is_merged_in_target_branch":true,"change_id":"Icaca2f3fef658cdb2c376b6b4dba12ae0327f240","change_number":36695,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}