)]}'
{"id":"spymemcached~44144","triplet_id":"spymemcached~master~I9ae2d71ae7d3fe899bce8ec8200e215aa987400d","project":"spymemcached","branch":"master","hashtags":[],"change_id":"I9ae2d71ae7d3fe899bce8ec8200e215aa987400d","subject":"Update Spring FactoryBean to properly support isSingleton property","status":"MERGED","created":"2014-12-09 14:04:34.000000000","updated":"2014-12-10 12:03:29.000000000","submitted":"2014-12-10 12:03:29.000000000","submitter":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6c1bbfafd832a6bcff3d60cea45be3de19696515","_number":44144,"virtual_id_number":44144,"owner":{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":1,"date":"2014-12-10 12:03:29.000000000","_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2014-12-10 12:03:29.000000000","_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"value":0,"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-12-10 12:03:28.000000000","updated_by":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"b031fbf2a6131d8bcb1a21d368de4bd7ac975c10","author":{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-12-09 14:04:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"758d30efd1b2f50a5c59f7e5f889725e88182640","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-12-09 14:31:56.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nthanks for the PR! Please see my comments :) thanks again","accounts_in_message":[],"_revision_number":1},{"id":"2712b014ab2e77302eaf0825586f243072f6f253","author":{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-12-09 20:08:08.000000000","message":"Patch Set 1:\n\n(3 comments)\n\nMade some replies to your comments. I will update the code in a bit to use some additional Spring lifecycle interfaces that should clear up any hesitation on the lazy init of the client.","accounts_in_message":[],"_revision_number":1},{"id":"4fe8596f7b310ff2c5a3451cb5ae78c52556bc1e","author":{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-12-10 03:24:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6a8046ddfeeaba4b51525d99eabbe0ed77b8e460","author":{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-12-10 03:26:27.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"cb68ab65d1a7230c45a0686cb5773569b9fe52ca","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-12-10 12:03:28.000000000","message":"Patch Set 3: Verified+1 Code-Review+2\n\nMerged, thanks very much!","accounts_in_message":[],"_revision_number":3},{"id":"6c1bbfafd832a6bcff3d60cea45be3de19696515","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2014-12-10 12:03:29.000000000","message":"Change has been successfully cherry-picked as 95833c9927d9996d5f3e781f2441a7df16cb8479","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"95833c9927d9996d5f3e781f2441a7df16cb8479","revisions":{"e04e84d5d19fec6178ba0ce23db55ccaa20de542":{"kind":"REWORK","_number":1,"created":"2014-12-09 14:04:34.000000000","uploader":{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/44/44144/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/44/44144/1","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/1 \u0026\u0026 git checkout -b change-44144 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/44/44144/1","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"953c322ad254bf6f544bac6738114176040a9c6f","subject":"SPY-176: Enhance redistribution logic and avoid possible deadlocks."}],"author":{"name":"mattbertolini","email":"viper2843@gmail.com","date":"2014-12-09 14:04:03.000000000","tz":-300},"committer":{"name":"mattbertolini","email":"viper2843@gmail.com","date":"2014-12-09 14:04:03.000000000","tz":-300},"subject":"The Spring factory bean was marked as a singleton but was creating a new instance with every call to getObject(). I created an instance holder so the same reference is returned every time. This also allows the class to expose a shutdown method to appropriately shut down the client when the spring context is destroyed.","message":"The Spring factory bean was marked as a singleton but was creating a new instance with every call to getObject(). I created an instance holder so the same reference is returned every time. This also allows the class to expose a shutdown method to appropriately shut down the client when the spring context is destroyed.\n\nChange-Id: I9ae2d71ae7d3fe899bce8ec8200e215aa987400d\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"953c322ad254bf6f544bac6738114176040a9c6f","is_merged_in_target_branch":true,"change_id":"Icbc5f9e4f568ea885500e8d2baedfa989c8ef801","change_number":38669,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"97bc912819d70633fc6a5ef95c73e95f544828f1":{"kind":"REWORK","_number":2,"created":"2014-12-10 03:24:02.000000000","uploader":{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/44/44144/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/44/44144/2","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/2 \u0026\u0026 git checkout -b change-44144 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/44/44144/2","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"953c322ad254bf6f544bac6738114176040a9c6f","subject":"SPY-176: Enhance redistribution logic and avoid possible deadlocks."}],"author":{"name":"mattbertolini","email":"viper2843@gmail.com","date":"2014-12-09 14:04:03.000000000","tz":-300},"committer":{"name":"mattbertolini","email":"viper2843@gmail.com","date":"2014-12-10 03:23:27.000000000","tz":-300},"subject":"Update Spring FactoryBean to properly support isSingleton property","message":"Update Spring FactoryBean to properly support isSingleton property\n\nMotivation\n----------\nThe current MemcachedClientFactoryBean is marked as a singleton to Spring but\ndoes not respect the flag. It is creating a new instance with every call to\ngetObject(). According to the Spring Javadoc a FactoryBean marked with\nisSingleton true should always return the same reference. By doing this it\nwill also expose an ability to safely shutdown a client instance.\n\nModifications\n-------------\nThe class was updated to implement the Spring InitializingBean and\nDesposableBean interfaces. These interfaces provide the two key lifecycle\nmethods to create and shutdown the client object. The afterPropertiesSet is\ncalled after the FactoryBean is constructed and all of the properties have\nbeen set. This will create the client object and store it in a field so the\nsame reference can be returned. The destroy method is called when closing the\nSpring context. It will call the client\u0027s shutdown method. I have also added a\nnew property that allows a caller to specify the number of seconds to wait\nbefore shutting down the client. This is a well established Spring pattern\nthat is used in many of their own FactoryBean implementations.\n\nResult\n------\nA more accurate Factory bean that respects the Spring lifecycle and provides\na safe shutdown mechanism.\n\nChange-Id: I9ae2d71ae7d3fe899bce8ec8200e215aa987400d\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"953c322ad254bf6f544bac6738114176040a9c6f","is_merged_in_target_branch":true,"change_id":"Icbc5f9e4f568ea885500e8d2baedfa989c8ef801","change_number":38669,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"45ec821e44e182b8b49cbc26cd1fad2b768263d7":{"kind":"REWORK","_number":3,"created":"2014-12-10 03:26:27.000000000","uploader":{"_account_id":1002542,"name":"Matt Bertolini","email":"viper2843@gmail.com","username":"mattbertolini","avatars":[{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/2fa74c7605acd288a109ce92f83002b5.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/44/44144/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/44/44144/3","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/3 \u0026\u0026 git checkout -b change-44144 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/44/44144/3","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"953c322ad254bf6f544bac6738114176040a9c6f","subject":"SPY-176: Enhance redistribution logic and avoid possible deadlocks."}],"author":{"name":"mattbertolini","email":"viper2843@gmail.com","date":"2014-12-09 14:04:03.000000000","tz":-300},"committer":{"name":"mattbertolini","email":"viper2843@gmail.com","date":"2014-12-10 03:26:09.000000000","tz":-300},"subject":"Update Spring FactoryBean to properly support isSingleton property","message":"Update Spring FactoryBean to properly support isSingleton property\n\nMotivation\n----------\nThe current MemcachedClientFactoryBean is marked as a singleton to Spring but\ndoes not respect the flag. It is creating a new instance with every call to\ngetObject(). According to the Spring Javadoc a FactoryBean marked with\nisSingleton true should always return the same reference. By doing this it\nwill also expose an ability to safely shutdown a client instance.\n\nModifications\n-------------\nThe class was updated to implement the Spring InitializingBean and\nDesposableBean interfaces. These interfaces provide the two key lifecycle\nmethods to create and shutdown the client object. The afterPropertiesSet is\ncalled after the FactoryBean is constructed and all of the properties have\nbeen set. This will create the client object and store it in a field so the\nsame reference can be returned. The destroy method is called when closing the\nSpring context. It will call the client\u0027s shutdown method. I have also added a\nnew property that allows a caller to specify the number of seconds to wait\nbefore shutting down the client. This is a well established Spring pattern\nthat is used in many of their own FactoryBean implementations.\n\nResult\n------\nA more accurate Factory bean that respects the Spring lifecycle and provides\na safe shutdown mechanism.\n\nChange-Id: I9ae2d71ae7d3fe899bce8ec8200e215aa987400d\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"953c322ad254bf6f544bac6738114176040a9c6f","is_merged_in_target_branch":true,"change_id":"Icbc5f9e4f568ea885500e8d2baedfa989c8ef801","change_number":38669,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"95833c9927d9996d5f3e781f2441a7df16cb8479":{"kind":"REWORK","_number":4,"created":"2014-12-10 12:03:29.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/44/44144/4","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/44/44144/4","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/4 \u0026\u0026 git checkout -b change-44144 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/44/44144/4","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/44/44144/4 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"8af3ebbcc2cd74deee6e28350322dbc470f5164f","subject":"SPY-179: Reconnect has wrong ceiling, leading to very long reconnect delays."}],"author":{"name":"mattbertolini","email":"viper2843@gmail.com","date":"2014-12-09 14:04:03.000000000","tz":-300},"committer":{"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","date":"2014-12-10 12:03:29.000000000","tz":0},"subject":"Update Spring FactoryBean to properly support isSingleton property","message":"Update Spring FactoryBean to properly support isSingleton property\n\nMotivation\n----------\nThe current MemcachedClientFactoryBean is marked as a singleton to Spring but\ndoes not respect the flag. It is creating a new instance with every call to\ngetObject(). According to the Spring Javadoc a FactoryBean marked with\nisSingleton true should always return the same reference. By doing this it\nwill also expose an ability to safely shutdown a client instance.\n\nModifications\n-------------\nThe class was updated to implement the Spring InitializingBean and\nDesposableBean interfaces. These interfaces provide the two key lifecycle\nmethods to create and shutdown the client object. The afterPropertiesSet is\ncalled after the FactoryBean is constructed and all of the properties have\nbeen set. This will create the client object and store it in a field so the\nsame reference can be returned. The destroy method is called when closing the\nSpring context. It will call the client\u0027s shutdown method. I have also added a\nnew property that allows a caller to specify the number of seconds to wait\nbefore shutting down the client. This is a well established Spring pattern\nthat is used in many of their own FactoryBean implementations.\n\nResult\n------\nA more accurate Factory bean that respects the Spring lifecycle and provides\na safe shutdown mechanism.\n\nChange-Id: I9ae2d71ae7d3fe899bce8ec8200e215aa987400d\nReviewed-on: http://review.couchbase.org/44144\nReviewed-by: Michael Nitschinger \u003cmichael.nitschinger@couchbase.com\u003e\nTested-by: Michael Nitschinger \u003cmichael.nitschinger@couchbase.com\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"8af3ebbcc2cd74deee6e28350322dbc470f5164f","is_merged_in_target_branch":true,"change_id":"I0c976344d0f8e09bc041d94f3544620ef4fb3117","change_number":42925,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}