)]}'
{"src/main/java/net/spy/memcached/ConnectionFactoryBuilder.java":[{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\tprivate AuthDescriptor authDescriptor \u003d null;"},{"line_number":46,"context_line":"\tprivate long opQueueMaxBlockTime \u003d -1;"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"\tprivate int timeoutExceptionThreshold \u003d DefaultConnectionFactory.DEFAULT_MAX_TIMEOUTEXCEPTION_THRESHOLD;"},{"line_number":49,"context_line":"    private Config vBucketConfig;"},{"line_number":50,"context_line":"\t/**"},{"line_number":51,"context_line":"\t * Set the operation queue factory."}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHk%3D","line":48,"updated":"2011-06-06 21:13:57.000000000","message":"Formatting","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":217,"context_line":"\t\t}"},{"line_number":218,"context_line":"\t\treturn this;"},{"line_number":219,"context_line":"\t}"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    public Config getVBucketConfig() {"},{"line_number":222,"context_line":"        return vBucketConfig;"},{"line_number":223,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHo%3D","line":220,"updated":"2011-06-06 21:13:57.000000000","message":"Formatting","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":258,"context_line":"\t\t\t\t\tcase ARRAY_MOD:"},{"line_number":259,"context_line":"\t\t\t\t\t\treturn new ArrayModNodeLocator(nodes, getHashAlg());"},{"line_number":260,"context_line":"\t\t\t\t\tcase CONSISTENT:"},{"line_number":261,"context_line":"\t\t\t\t\t\treturn new KetamaNodeLocator(nodes, getHashAlg());"},{"line_number":262,"context_line":"                    case VBUCKET:"},{"line_number":263,"context_line":"                        return new VBucketNodeLocator(nodes, getVBucketConfig());"},{"line_number":264,"context_line":"\t\t\t\t\tdefault: throw new IllegalStateException("}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHw%3D","line":261,"updated":"2011-06-06 21:13:57.000000000","message":"Fix formatting","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":373,"context_line":"\t\t * This uses ketema\u0027s distribution algorithm, but may be used with any"},{"line_number":374,"context_line":"\t\t * hash algorithm."},{"line_number":375,"context_line":"\t\t */"},{"line_number":376,"context_line":"\t\tCONSISTENT,"},{"line_number":377,"context_line":"        /**"},{"line_number":378,"context_line":"         * VBucket support"},{"line_number":379,"context_line":"         */"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHs%3D","line":376,"updated":"2011-06-06 21:13:57.000000000","message":"Fix formatting","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"}],"src/main/java/net/spy/memcached/MemcachedConnection.java":[{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e98cb82b49060c8fde9a6038c4e9adb4afc6eb13","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\t\tnew ConcurrentLinkedQueue\u003cConnectionObserver\u003e();"},{"line_number":70,"context_line":"\tprivate final OperationFactory opFact;"},{"line_number":71,"context_line":"\tprivate final int timeoutExceptionThreshold;"},{"line_number":72,"context_line":"        private final Collection\u003cOperation\u003e retryOps;"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"\t/**"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FFA%3D","line":72,"updated":"2011-06-06 23:55:50.000000000","message":"No need to use Collection here if it\u0027s always an ArrayList, it\u0027ll be a little faster this way.","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":408,"context_line":"\t\t\t\t\tassert op \u003d\u003d currentOp"},{"line_number":409,"context_line":"\t\t\t\t\t: \"Expected to pop \" + currentOp + \" got \" + op;"},{"line_number":410,"context_line":"\t\t\t\t\tcurrentOp\u003dqa.getCurrentReadOp();"},{"line_number":411,"context_line":"\t\t\t\t} else if (currentOp.getState() \u003d\u003d OperationState.RETRY) {"},{"line_number":412,"context_line":"                    getLogger().debug("},{"line_number":413,"context_line":"                            \"Reschedule read op due to NOT_MY_VBUCKET error: %s \","},{"line_number":414,"context_line":"                            currentOp);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHg%3D","line":411,"updated":"2011-06-06 21:13:57.000000000","message":"Formatting","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":"\t\tassert o.isCancelled() || placeIn !\u003d null"},{"line_number":609,"context_line":"\t\t\t: \"No node found for key \" + key;"},{"line_number":610,"context_line":"\t\tif(placeIn !\u003d null) {"},{"line_number":611,"context_line":"            // add the vbucketIndex to the operation"},{"line_number":612,"context_line":"            if (locator instanceof VBucketNodeLocator) {"},{"line_number":613,"context_line":"                int vbucketIndex \u003d ((VBucketNodeLocator) locator).getVBucketIndex(key);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHc%3D","line":610,"updated":"2011-06-06 21:13:57.000000000","message":"Formatting","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"74f8136a03b1091482a1f7e46813cf8301795894","unresolved":false,"context_lines":[{"line_number":69,"context_line":"\t\tnew ConcurrentLinkedQueue\u003cConnectionObserver\u003e();"},{"line_number":70,"context_line":"\tprivate final OperationFactory opFact;"},{"line_number":71,"context_line":"\tprivate final int timeoutExceptionThreshold;"},{"line_number":72,"context_line":"        private final Collection\u003cOperation\u003e retryOps;"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"\t/**"}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABRn%2F%2F%2Bz8%3D","line":72,"updated":"2011-06-08 02:23:49.000000000","message":"Make an ArrayList.","commit_id":"95ace7505c56566ce28969fd1ff50710a26ff3c4"}],"src/main/java/net/spy/memcached/protocol/BaseOperationImpl.java":[{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e98cb82b49060c8fde9a6038c4e9adb4afc6eb13","unresolved":false,"context_lines":[{"line_number":36,"context_line":"\tpublic BaseOperationImpl() {"},{"line_number":37,"context_line":"\t\tsuper();"},{"line_number":38,"context_line":"\t\tcreationTime \u003d System.nanoTime();"},{"line_number":39,"context_line":"\t}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"\t/**"},{"line_number":42,"context_line":"\t * Get the operation callback associated with this operation."}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FE8%3D","side":"PARENT","line":39,"updated":"2011-06-06 23:55:50.000000000","message":"Looks like some whitespace changes  snuck in here, best to remove.","commit_id":"9eb7930c5f5b9d9fbc184db07bd3463a958fe58c"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"74f8136a03b1091482a1f7e46813cf8301795894","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\t/**"},{"line_number":42,"context_line":"\t * Get the operation callback associated with this operation."},{"line_number":43,"context_line":"\t */"},{"line_number":44,"context_line":"\tpublic final OperationCallback getCallback() {"},{"line_number":45,"context_line":"\t\treturn callback;"},{"line_number":46,"context_line":"\t}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABRn%2F%2F%2Bz4%3D","side":"PARENT","line":44,"updated":"2011-06-08 02:23:49.000000000","message":"Lots of whitespace changes here.","commit_id":"b658e4d70e240cc9fe0ec3dac53ce3365215c7f0"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"acd735550d12e35f9bdea2795af875af598b1fe4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\t/**"},{"line_number":42,"context_line":"\t * Get the operation callback associated with this operation."},{"line_number":43,"context_line":"\t */"},{"line_number":44,"context_line":"\tpublic final OperationCallback getCallback() {"},{"line_number":45,"context_line":"\t\treturn callback;"},{"line_number":46,"context_line":"\t}"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABRn%2F%2F%2Bx8%3D","side":"PARENT","line":44,"in_reply_to":"AAABRn%2F%2F%2Bz4%3D","updated":"2011-06-08 04:59:46.000000000","message":"seems to be an artifact of gerrit\u0027s view.  it\u0027s not that way in a git diff.","commit_id":"b658e4d70e240cc9fe0ec3dac53ce3365215c7f0"}],"src/main/java/net/spy/memcached/protocol/binary/OperationImpl.java":[{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":152,"context_line":"\t\t\tOperationStatus status\u003dgetStatusForErrorCode(errorCode, pl);"},{"line_number":153,"context_line":"\t\t\tif(status \u003d\u003d null) {"},{"line_number":154,"context_line":"\t\t\t\thandleError(OperationErrorType.SERVER, new String(pl));"},{"line_number":155,"context_line":"\t\t\t} else if (status \u003d\u003d NOT_MY_VBUCKET_STATUS \u0026\u0026 !getState().equals(OperationState.COMPLETE)) {"},{"line_number":156,"context_line":"                transitionState(OperationState.RETRY);"},{"line_number":157,"context_line":"                //errorCode \u003d 0;"},{"line_number":158,"context_line":"\t\t\t} else {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHU%3D","line":155,"updated":"2011-06-06 21:13:57.000000000","message":"Formatting","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":171,"context_line":"\t * @param errCode the error code"},{"line_number":172,"context_line":"\t * @return the status to return, or null if this is an exceptional case"},{"line_number":173,"context_line":"\t */"},{"line_number":174,"context_line":"\tprotected OperationStatus getStatusForErrorCode(int errCode, byte[] errPl) {"},{"line_number":175,"context_line":"        if (errCode \u003d\u003d ERR_NOT_MY_VBUCKET) {"},{"line_number":176,"context_line":"            return NOT_MY_VBUCKET_STATUS;"},{"line_number":177,"context_line":"        }"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHQ%3D","line":174,"updated":"2011-06-06 21:13:57.000000000","message":"Formatting","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e98cb82b49060c8fde9a6038c4e9adb4afc6eb13","unresolved":false,"context_lines":[{"line_number":268,"context_line":"\t\tbb.putShort((short)keyBytes.length);"},{"line_number":269,"context_line":"\t\tbb.put((byte)extraLen);"},{"line_number":270,"context_line":"\t\tbb.put((byte)0); // data type"},{"line_number":271,"context_line":"\t\tbb.putShort((short) this.vbucket); // reserved"},{"line_number":272,"context_line":"\t\tbb.putInt(keyBytes.length + val.length + extraLen);"},{"line_number":273,"context_line":"\t\tbb.putInt(opaque);"},{"line_number":274,"context_line":"\t\tbb.putLong(cas);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FE4%3D","line":271,"updated":"2011-06-06 23:55:50.000000000","message":"this. isn\u0027t necessary here.","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f1fbe99891d4afb9c999a3969e204bc7211e5be5","unresolved":false,"context_lines":[{"line_number":268,"context_line":"\t\tbb.putShort((short)keyBytes.length);"},{"line_number":269,"context_line":"\t\tbb.put((byte)extraLen);"},{"line_number":270,"context_line":"\t\tbb.put((byte)0); // data type"},{"line_number":271,"context_line":"\t\tbb.putShort((short) this.vbucket); // reserved"},{"line_number":272,"context_line":"\t\tbb.putInt(keyBytes.length + val.length + extraLen);"},{"line_number":273,"context_line":"\t\tbb.putInt(opaque);"},{"line_number":274,"context_line":"\t\tbb.putLong(cas);"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F%2B%2Bg%3D","line":271,"updated":"2011-06-07 07:17:59.000000000","message":"Blairs Comment: No need for this.","commit_id":"4dbada90c3054b2d0f11543ccd3a13cd28f69b38"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9675a32cd2fabd31098f5a53e88ef419041ddaab","unresolved":false,"context_lines":[{"line_number":268,"context_line":"\t\tbb.putShort((short)keyBytes.length);"},{"line_number":269,"context_line":"\t\tbb.put((byte)extraLen);"},{"line_number":270,"context_line":"\t\tbb.put((byte)0); // data type"},{"line_number":271,"context_line":"\t\tbb.putShort((short) this.vbucket); // reserved"},{"line_number":272,"context_line":"\t\tbb.putInt(keyBytes.length + val.length + extraLen);"},{"line_number":273,"context_line":"\t\tbb.putInt(opaque);"},{"line_number":274,"context_line":"\t\tbb.putLong(cas);"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F%2B3U%3D","line":271,"in_reply_to":"AAABRn%2F%2F%2B%2Bg%3D","updated":"2011-06-07 23:08:38.000000000","message":"Done","commit_id":"4dbada90c3054b2d0f11543ccd3a13cd28f69b38"}],"src/main/java/net/spy/memcached/vbucket/VBucketNodeLocator.java":[{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"     *"},{"line_number":23,"context_line":"     * @param nodes"},{"line_number":24,"context_line":"     * @param jsonConfig"},{"line_number":25,"context_line":"     */"},{"line_number":26,"context_line":"    public VBucketNodeLocator(List\u003cMemcachedNode\u003e nodes, Config jsonConfig) {"},{"line_number":27,"context_line":"        super();"},{"line_number":28,"context_line":"        setNodes(nodes);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHM%3D","line":25,"updated":"2011-06-06 21:13:57.000000000","message":"Config should be final. Also why do we need a setter function to set the config. Can\u0027t we just set it here (this.config \u003d config). This would be more consistent with the rest of the code.","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"516d7e4232e7ed5afad5eaea5bd96c1b7444dda6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"     *"},{"line_number":23,"context_line":"     * @param nodes"},{"line_number":24,"context_line":"     * @param jsonConfig"},{"line_number":25,"context_line":"     */"},{"line_number":26,"context_line":"    public VBucketNodeLocator(List\u003cMemcachedNode\u003e nodes, Config jsonConfig) {"},{"line_number":27,"context_line":"        super();"},{"line_number":28,"context_line":"        setNodes(nodes);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B3s%3D","line":25,"in_reply_to":"AAABRn%2F%2F%2FHM%3D","updated":"2011-06-07 23:07:50.000000000","message":"can\u0027t, as it is modified.  yes, this a potential issue.  will be tracked and fixed later.","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    public int getVBucketIndex(String key) {"},{"line_number":58,"context_line":"        return config.getVbucketByKey(key);"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    private void setNodes(Collection\u003cMemcachedNode\u003e nodes) {"},{"line_number":61,"context_line":"        Map\u003cString, MemcachedNode\u003e nodesMap \u003d new HashMap\u003cString, MemcachedNode\u003e();"},{"line_number":62,"context_line":"        for (MemcachedNode node : nodes) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHE%3D","line":59,"updated":"2011-06-06 21:13:57.000000000","message":"New Line","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"516d7e4232e7ed5afad5eaea5bd96c1b7444dda6","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    public int getVBucketIndex(String key) {"},{"line_number":58,"context_line":"        return config.getVbucketByKey(key);"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    private void setNodes(Collection\u003cMemcachedNode\u003e nodes) {"},{"line_number":61,"context_line":"        Map\u003cString, MemcachedNode\u003e nodesMap \u003d new HashMap\u003cString, MemcachedNode\u003e();"},{"line_number":62,"context_line":"        for (MemcachedNode node : nodes) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B3o%3D","line":59,"in_reply_to":"AAABRn%2F%2F%2FHE%3D","updated":"2011-06-07 23:07:50.000000000","message":"Addressed in a later commit.","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"16f6802a94397970f9544eb6e163658b78fdeed1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        this.nodesMap \u003d nodesMap;"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    private void setConfig(final Config config) {"},{"line_number":71,"context_line":"        this.config \u003d config;"},{"line_number":72,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FHI%3D","line":69,"updated":"2011-06-06 21:13:57.000000000","message":"We don\u0027t need a setter function for config.","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"516d7e4232e7ed5afad5eaea5bd96c1b7444dda6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        this.nodesMap \u003d nodesMap;"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"    private void setConfig(final Config config) {"},{"line_number":71,"context_line":"        this.config \u003d config;"},{"line_number":72,"context_line":"    }"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B3k%3D","line":69,"in_reply_to":"AAABRn%2F%2F%2FHI%3D","updated":"2011-06-07 23:07:50.000000000","message":"Unfortunately, it\u0027s used later.  Needs to be fixed.  Filing an issue.","commit_id":"03d7a93ee26da76d7d474bab78242c72de263171"},{"author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5243cd6efd9e6952e6f92b714fee4956aaa04a8b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    private Map\u003cString, MemcachedNode\u003e nodesMap;"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    private Config config;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    /**"},{"line_number":21,"context_line":"     * Construct a VBucketNodeLocator over the given JSON configuration string."}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F%2B90%3D","line":18,"updated":"2011-06-07 07:37:49.000000000","message":"These variables are used by multiple threads concurrently, but are mutable and cached.\n\nI know I\u0027m being a pain about this whole \"final\" thing, but I don\u0027t see how this can possibly be done correctly.\n\nFor example...","commit_id":"4dbada90c3054b2d0f11543ccd3a13cd28f69b38"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f1fbe99891d4afb9c999a3969e204bc7211e5be5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    public VBucketNodeLocator(List\u003cMemcachedNode\u003e nodes, Config jsonConfig) {"},{"line_number":27,"context_line":"        super();"},{"line_number":28,"context_line":"        setNodes(nodes);"},{"line_number":29,"context_line":"        setConfig(jsonConfig);"},{"line_number":30,"context_line":"    }"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F%2B%2BY%3D","line":29,"updated":"2011-06-07 07:17:59.000000000","message":"Address my comments from the previous patch set","commit_id":"4dbada90c3054b2d0f11543ccd3a13cd28f69b38"},{"author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5243cd6efd9e6952e6f92b714fee4956aaa04a8b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        int serverNumber \u003d config.getMaster(vbucket);"},{"line_number":36,"context_line":"        String server \u003d config.getServer(serverNumber);"},{"line_number":37,"context_line":"        // choose appropriate MemecachedNode according to config data"},{"line_number":38,"context_line":"        return nodesMap.get(server);"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    public Iterator\u003cMemcachedNode\u003e getSequence(String k) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F%2B9w%3D","line":38,"updated":"2011-06-07 07:37:49.000000000","message":"This method invokes three different methods on the config object (which can very well be three different config objects) before using the result to invoke a method on a map that could\u0027ve also changed at any point during the invocation of this.\n\nI think it\u0027s easy to understand what this will do with a final config and map, but impossible otherwise.","commit_id":"4dbada90c3054b2d0f11543ccd3a13cd28f69b38"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"39bea5a97220e7bfcf8e3120e9793a7b55f922b9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        int serverNumber \u003d config.getMaster(vbucket);"},{"line_number":36,"context_line":"        String server \u003d config.getServer(serverNumber);"},{"line_number":37,"context_line":"        // choose appropriate MemecachedNode according to config data"},{"line_number":38,"context_line":"        return nodesMap.get(server);"},{"line_number":39,"context_line":"    }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    public Iterator\u003cMemcachedNode\u003e getSequence(String k) {"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F%2B3g%3D","line":38,"in_reply_to":"AAABRn%2F%2F%2B9w%3D","updated":"2011-06-07 23:08:00.000000000","message":"Will file an issue and fix in a later commit.  Planning for before GA.","commit_id":"4dbada90c3054b2d0f11543ccd3a13cd28f69b38"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"74f8136a03b1091482a1f7e46813cf8301795894","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"public class VBucketNodeLocator implements NodeLocator {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    private Map\u003cString, MemcachedNode\u003e nodesMap;"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    private Config config;"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABRn%2F%2F%2Bzw%3D","line":16,"updated":"2011-06-08 02:23:49.000000000","message":"Change to HashMap.","commit_id":"95ace7505c56566ce28969fd1ff50710a26ff3c4"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"74f8136a03b1091482a1f7e46813cf8301795894","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        return config.getVbucketByKey(key);"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    private void setNodes(Collection\u003cMemcachedNode\u003e nodes) {"},{"line_number":61,"context_line":"        Map\u003cString, MemcachedNode\u003e nodesMap \u003d new HashMap\u003cString, MemcachedNode\u003e();"},{"line_number":62,"context_line":"        for (MemcachedNode node : nodes) {"},{"line_number":63,"context_line":"            InetSocketAddress addr \u003d (InetSocketAddress) node.getSocketAddress();"},{"line_number":64,"context_line":"            String address \u003d addr.getAddress().getHostAddress() + \":\" + addr.getPort();"}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABRn%2F%2F%2Bz0%3D","line":61,"updated":"2011-06-08 02:23:49.000000000","message":"Suggest renaming to now shadow the instance variable.  Change Map to HashMap.","commit_id":"95ace7505c56566ce28969fd1ff50710a26ff3c4"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"acd735550d12e35f9bdea2795af875af598b1fe4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        return config.getVbucketByKey(key);"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    private void setNodes(Collection\u003cMemcachedNode\u003e nodes) {"},{"line_number":61,"context_line":"        Map\u003cString, MemcachedNode\u003e nodesMap \u003d new HashMap\u003cString, MemcachedNode\u003e();"},{"line_number":62,"context_line":"        for (MemcachedNode node : nodes) {"},{"line_number":63,"context_line":"            InetSocketAddress addr \u003d (InetSocketAddress) node.getSocketAddress();"},{"line_number":64,"context_line":"            String address \u003d addr.getAddress().getHostAddress() + \":\" + addr.getPort();"}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABRn%2F%2F%2ByA%3D","line":61,"in_reply_to":"AAABRn%2F%2F%2Bz0%3D","updated":"2011-06-08 04:59:46.000000000","message":"It is in a later commit.","commit_id":"95ace7505c56566ce28969fd1ff50710a26ff3c4"}]}