)]}'
{"src/main/java/net/spy/memcached/AddrUtil.java":[{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\t}"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\tpublic static List\u003cInetSocketAddress\u003e getAddresses(List\u003cString\u003e servers) {"},{"line_number":54,"context_line":"\t\tArrayList\u003cInetSocketAddress\u003e addrs \u003d new ArrayList\u003cInetSocketAddress\u003e();"},{"line_number":55,"context_line":"\t\tfor (String server : servers) {"},{"line_number":56,"context_line":"\t\t\tint finalColon\u003dserver.lastIndexOf(\u0027:\u0027);"},{"line_number":57,"context_line":"\t\t\tif(finalColon \u003c 1) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEs%3D","line":54,"updated":"2011-06-07 00:04:26.000000000","message":"You can pass in the exact size from servers.size() so the ArrayList doesn\u0027t need to use its default size.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"\t\t\tif(finalColon \u003c 1) {"},{"line_number":58,"context_line":"\t\t\t\tthrow new IllegalArgumentException(\"Invalid server ``\""},{"line_number":59,"context_line":"\t\t\t\t+ server + \"\u0027\u0027 in list:  \" + server);"},{"line_number":60,"context_line":"\t\t}"},{"line_number":61,"context_line":"\t\tString hostPart\u003dserver.substring(0, finalColon);"},{"line_number":62,"context_line":"\t\tString portNum\u003dserver.substring(finalColon+1);"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEw%3D","line":60,"updated":"2011-06-07 00:04:26.000000000","message":"Indentation is off here.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"\t\taddrs.add(new InetSocketAddress(hostPart, Integer.parseInt(portNum)));"},{"line_number":65,"context_line":"\t\t}"},{"line_number":66,"context_line":"\t\tassert !addrs.isEmpty() : \"No addrs found\";"},{"line_number":67,"context_line":"\t\treturn addrs;"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEo%3D","line":66,"updated":"2011-06-07 00:04:26.000000000","message":"addrs will only be empty is servers is empty, so better to throw an IllegalArgumentException, but even there, that may be questionable if it should do that,","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"}],"src/main/java/net/spy/memcached/MemcachedClient.java":[{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"487d2b4ab75d0ad650533fbd0e8b19e1d0fe463b","unresolved":false,"context_lines":[{"line_number":108,"context_line":" *      }"},{"line_number":109,"context_line":" * \u003c/pre\u003e"},{"line_number":110,"context_line":" */"},{"line_number":111,"context_line":"public class MemcachedClient extends SpyThread"},{"line_number":112,"context_line":"\timplements MemcachedClientIF, ConnectionObserver, Reconfigurable {"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"\tprivate volatile boolean running\u003dtrue;"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FF8%3D","line":111,"updated":"2011-06-06 21:45:00.000000000","message":"This entire file needs to be better formatted","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":189,"context_line":"\t\tstart();"},{"line_number":190,"context_line":"\t}"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    public MemcachedClient(final List\u003cURI\u003e baseList,"},{"line_number":193,"context_line":"                           final String bucketName,"},{"line_number":194,"context_line":"                           final String usr, final String pwd,"},{"line_number":195,"context_line":"                           final boolean isVBucketAware) throws IOException, ConfigurationException {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEY%3D","line":192,"updated":"2011-06-07 00:04:26.000000000","message":"It would be great to refactor the class so that much of the code in this constructor isn\u0027t duplicated in the existing constructors, ala DRY principle.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dffeebb9a55b6e2b890ed22e4c3ba4606719de2e","unresolved":false,"context_lines":[{"line_number":189,"context_line":"\t\tstart();"},{"line_number":190,"context_line":"\t}"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    public MemcachedClient(final List\u003cURI\u003e baseList,"},{"line_number":193,"context_line":"                           final String bucketName,"},{"line_number":194,"context_line":"                           final String usr, final String pwd,"},{"line_number":195,"context_line":"                           final boolean isVBucketAware) throws IOException, ConfigurationException {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FA8%3D","line":192,"in_reply_to":"AAABRn%2F%2F%2FEY%3D","updated":"2011-06-07 17:51:15.000000000","message":"agreed, though probably not at the moment.  this ctor is to be killed here soon anyway.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    }"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    public void reconfigure(Bucket bucket) {"},{"line_number":257,"context_line":"        this.reconfiguring \u003d true;"},{"line_number":258,"context_line":"        this.conn.reconfigure(bucket);"},{"line_number":259,"context_line":"        this.reconfiguring \u003d false;"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEg%3D","line":257,"updated":"2011-06-07 00:04:26.000000000","message":"As a style note, removing this. everywhere would be nice.  It really shouldn\u0027t be necessary, as requiring it implies that some shadowing is going on, which isn\u0027t a good pattern.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dffeebb9a55b6e2b890ed22e4c3ba4606719de2e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    }"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    public void reconfigure(Bucket bucket) {"},{"line_number":257,"context_line":"        this.reconfiguring \u003d true;"},{"line_number":258,"context_line":"        this.conn.reconfigure(bucket);"},{"line_number":259,"context_line":"        this.reconfiguring \u003d false;"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B9k%3D","line":257,"in_reply_to":"AAABRn%2F%2F%2FEg%3D","updated":"2011-06-07 17:51:15.000000000","message":"what happened to \u0027read more often than written\u0027?  Style wise, I always thought it was good to see that... especially if you\u0027re not in the IDE where color indicates what\u0027s happening.  That said, it\u0027s not elsewhere in this file, so the precedent should be followed.\n\nWe should come up with some guidelines for the project.  Like \"no tabs\".","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    public void reconfigure(Bucket bucket) {"},{"line_number":257,"context_line":"        this.reconfiguring \u003d true;"},{"line_number":258,"context_line":"        this.conn.reconfigure(bucket);"},{"line_number":259,"context_line":"        this.reconfiguring \u003d false;"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    }"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEc%3D","line":259,"updated":"2011-06-07 00:04:26.000000000","message":"What happens if conn.reconfigure() throws an exception.  Should reconfiguring be in a finally block?","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dffeebb9a55b6e2b890ed22e4c3ba4606719de2e","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    public void reconfigure(Bucket bucket) {"},{"line_number":257,"context_line":"        this.reconfiguring \u003d true;"},{"line_number":258,"context_line":"        this.conn.reconfigure(bucket);"},{"line_number":259,"context_line":"        this.reconfiguring \u003d false;"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    }"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B9g%3D","line":259,"in_reply_to":"AAABRn%2F%2F%2FEc%3D","updated":"2011-06-07 17:51:15.000000000","message":"good catch.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2312046909c15cb9377bd94ffeaca41a47f74e1f","unresolved":false,"context_lines":[{"line_number":189,"context_line":"\t\tsetDaemon(cf.isDaemon());"},{"line_number":190,"context_line":"\t\tstart();"},{"line_number":191,"context_line":"\t}"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    public MemcachedClient(final List\u003cURI\u003e baseList,"},{"line_number":194,"context_line":"                           final String bucketName,"},{"line_number":195,"context_line":"                           final String usr, final String pwd,"}],"source_content_type":"text/x-java","patch_set":5,"id":"AAABRn%2F%2F%2B0Q%3D","line":192,"updated":"2011-06-08 02:11:43.000000000","message":"Formatting","commit_id":"6b15e0d863db427fbdd7bd0fd03e2e0da6927bf0"}],"src/main/java/net/spy/memcached/MemcachedConnection.java":[{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"487d2b4ab75d0ad650533fbd0e8b19e1d0fe463b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"\t\tList\u003cMemcachedNode\u003e connections \u003d createConnections(a);"},{"line_number":106,"context_line":"\t\tlocator\u003df.createLocator(connections);"},{"line_number":107,"context_line":"\t\t}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\tprivate List\u003cMemcachedNode\u003e createConnections(final Collection\u003cInetSocketAddress\u003e a) throws IOException {"},{"line_number":110,"context_line":"\t\tList\u003cMemcachedNode\u003e connections\u003dnew ArrayList\u003cMemcachedNode\u003e(a.size());"},{"line_number":111,"context_line":"\t\tfor(SocketAddress sa : a) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FF4%3D","line":108,"updated":"2011-06-06 21:45:00.000000000","message":"Should be split to two lines","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dffeebb9a55b6e2b890ed22e4c3ba4606719de2e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"\t\tList\u003cMemcachedNode\u003e connections \u003d createConnections(a);"},{"line_number":106,"context_line":"\t\tlocator\u003df.createLocator(connections);"},{"line_number":107,"context_line":"\t\t}"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"\tprivate List\u003cMemcachedNode\u003e createConnections(final Collection\u003cInetSocketAddress\u003e a) throws IOException {"},{"line_number":110,"context_line":"\t\tList\u003cMemcachedNode\u003e connections\u003dnew ArrayList\u003cMemcachedNode\u003e(a.size());"},{"line_number":111,"context_line":"\t\tfor(SocketAddress sa : a) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B9c%3D","line":108,"in_reply_to":"AAABRn%2F%2F%2FF4%3D","updated":"2011-06-07 17:51:15.000000000","message":"Done","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"\t\t\t// get a new collection of addresses from the received config"},{"line_number":147,"context_line":"\t\t\tList\u003cString\u003e servers \u003d bucket.getVbuckets().getServers();"},{"line_number":148,"context_line":"\t\t\tCollection\u003cSocketAddress\u003e newServerAddresses \u003d new HashSet\u003cSocketAddress\u003e();"},{"line_number":149,"context_line":"\t\t\tList\u003cInetSocketAddress\u003e newServers \u003d new ArrayList\u003cInetSocketAddress\u003e();"},{"line_number":150,"context_line":"\t\t\tfor (String server : servers) {"},{"line_number":151,"context_line":"\t\t\t\tint finalColon \u003d server.lastIndexOf(\u0027:\u0027);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEQ%3D","line":148,"updated":"2011-06-07 00:04:26.000000000","message":"Use HashSet\u003cSocketAddress\u003e here.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dffeebb9a55b6e2b890ed22e4c3ba4606719de2e","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"\t\t\t// get a new collection of addresses from the received config"},{"line_number":147,"context_line":"\t\t\tList\u003cString\u003e servers \u003d bucket.getVbuckets().getServers();"},{"line_number":148,"context_line":"\t\t\tCollection\u003cSocketAddress\u003e newServerAddresses \u003d new HashSet\u003cSocketAddress\u003e();"},{"line_number":149,"context_line":"\t\t\tList\u003cInetSocketAddress\u003e newServers \u003d new ArrayList\u003cInetSocketAddress\u003e();"},{"line_number":150,"context_line":"\t\t\tfor (String server : servers) {"},{"line_number":151,"context_line":"\t\t\t\tint finalColon \u003d server.lastIndexOf(\u0027:\u0027);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B9M%3D","line":148,"in_reply_to":"AAABRn%2F%2F%2FEQ%3D","updated":"2011-06-07 17:51:15.000000000","message":"Done","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":146,"context_line":"\t\t\t// get a new collection of addresses from the received config"},{"line_number":147,"context_line":"\t\t\tList\u003cString\u003e servers \u003d bucket.getVbuckets().getServers();"},{"line_number":148,"context_line":"\t\t\tCollection\u003cSocketAddress\u003e newServerAddresses \u003d new HashSet\u003cSocketAddress\u003e();"},{"line_number":149,"context_line":"\t\t\tList\u003cInetSocketAddress\u003e newServers \u003d new ArrayList\u003cInetSocketAddress\u003e();"},{"line_number":150,"context_line":"\t\t\tfor (String server : servers) {"},{"line_number":151,"context_line":"\t\t\t\tint finalColon \u003d server.lastIndexOf(\u0027:\u0027);"},{"line_number":152,"context_line":"\t\t\t\tif (finalColon \u003c 1) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEM%3D","line":149,"updated":"2011-06-07 00:04:26.000000000","message":"Use ArrayList here.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dffeebb9a55b6e2b890ed22e4c3ba4606719de2e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"\t\t\t// get a new collection of addresses from the received config"},{"line_number":147,"context_line":"\t\t\tList\u003cString\u003e servers \u003d bucket.getVbuckets().getServers();"},{"line_number":148,"context_line":"\t\t\tCollection\u003cSocketAddress\u003e newServerAddresses \u003d new HashSet\u003cSocketAddress\u003e();"},{"line_number":149,"context_line":"\t\t\tList\u003cInetSocketAddress\u003e newServers \u003d new ArrayList\u003cInetSocketAddress\u003e();"},{"line_number":150,"context_line":"\t\t\tfor (String server : servers) {"},{"line_number":151,"context_line":"\t\t\t\tint finalColon \u003d server.lastIndexOf(\u0027:\u0027);"},{"line_number":152,"context_line":"\t\t\t\tif (finalColon \u003c 1) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B9I%3D","line":149,"in_reply_to":"AAABRn%2F%2F%2FEM%3D","updated":"2011-06-07 17:51:15.000000000","message":"Done","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000018,"name":"Blair Zajac","username":"blair","avatars":[{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/00000000000000000000000000000000.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"change_message_id":"e5ced19dfb007b118ffd354bebce5c62748bca6f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\t\t\t}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"\t\t\t// split current nodes to \"odd nodes\" and \"stay nodes\""},{"line_number":168,"context_line":"\t\t\tCollection\u003cMemcachedNode\u003e oddNodes \u003d new ArrayList\u003cMemcachedNode\u003e();"},{"line_number":169,"context_line":"\t\t\tCollection\u003cMemcachedNode\u003e stayNodes \u003d new ArrayList\u003cMemcachedNode\u003e();"},{"line_number":170,"context_line":"\t\t\tCollection\u003cInetSocketAddress\u003e stayServers \u003d new ArrayList\u003cInetSocketAddress\u003e();"},{"line_number":171,"context_line":"\t\t\tfor (MemcachedNode current : this.locator.getAll()) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FEI%3D","line":168,"updated":"2011-06-07 00:04:26.000000000","message":"ArrayList here and the next three lines.","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dffeebb9a55b6e2b890ed22e4c3ba4606719de2e","unresolved":false,"context_lines":[{"line_number":165,"context_line":"\t\t\t}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"\t\t\t// split current nodes to \"odd nodes\" and \"stay nodes\""},{"line_number":168,"context_line":"\t\t\tCollection\u003cMemcachedNode\u003e oddNodes \u003d new ArrayList\u003cMemcachedNode\u003e();"},{"line_number":169,"context_line":"\t\t\tCollection\u003cMemcachedNode\u003e stayNodes \u003d new ArrayList\u003cMemcachedNode\u003e();"},{"line_number":170,"context_line":"\t\t\tCollection\u003cInetSocketAddress\u003e stayServers \u003d new ArrayList\u003cInetSocketAddress\u003e();"},{"line_number":171,"context_line":"\t\t\tfor (MemcachedNode current : this.locator.getAll()) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B9Q%3D","line":168,"in_reply_to":"AAABRn%2F%2F%2FEI%3D","updated":"2011-06-07 17:51:15.000000000","message":"Done","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"487d2b4ab75d0ad650533fbd0e8b19e1d0fe463b","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"\t\tassert o.isCancelled() || placeIn !\u003d null"},{"line_number":699,"context_line":"\t\t\t: \"No node found for key \" + key;"},{"line_number":700,"context_line":"\t\tif(placeIn !\u003d null) {"},{"line_number":701,"context_line":"            // add the vbucketIndex to the operation"},{"line_number":702,"context_line":"            if (locator instanceof VBucketNodeLocator) {"},{"line_number":703,"context_line":"                int vbucketIndex \u003d ((VBucketNodeLocator) locator).getVBucketIndex(key);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2FF0%3D","line":700,"updated":"2011-06-06 21:45:00.000000000","message":"Formatting","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"dffeebb9a55b6e2b890ed22e4c3ba4606719de2e","unresolved":false,"context_lines":[{"line_number":697,"context_line":""},{"line_number":698,"context_line":"\t\tassert o.isCancelled() || placeIn !\u003d null"},{"line_number":699,"context_line":"\t\t\t: \"No node found for key \" + key;"},{"line_number":700,"context_line":"\t\tif(placeIn !\u003d null) {"},{"line_number":701,"context_line":"            // add the vbucketIndex to the operation"},{"line_number":702,"context_line":"            if (locator instanceof VBucketNodeLocator) {"},{"line_number":703,"context_line":"                int vbucketIndex \u003d ((VBucketNodeLocator) locator).getVBucketIndex(key);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABRn%2F%2F%2B9A%3D","line":700,"in_reply_to":"AAABRn%2F%2F%2FF0%3D","updated":"2011-06-07 17:51:15.000000000","message":"Done","commit_id":"d53851e3db3b8fc6ff0698e8bc0449039c212e3f"}]}