)]}'
{"id":"spymemcached~72270","triplet_id":"spymemcached~master~Ic0db65f9c7ccc3a7b9738aaff0e3c7e60d7f25c2","project":"spymemcached","branch":"master","hashtags":[],"change_id":"Ic0db65f9c7ccc3a7b9738aaff0e3c7e60d7f25c2","subject":"SPY-192: Ensure connection key is valid before checking if writable.","status":"MERGED","created":"2017-01-20 06:46:40.000000000","updated":"2017-02-01 07:00:00.000000000","submitted":"2017-02-01 07:00:00.000000000","submitter":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"72270-1485932400274-2b130529","meta_rev_id":"8152679d25c7e91838b460a76f44453721d22197","_number":72270,"virtual_id_number":72270,"owner":{"_account_id":1003910,"name":"Graham Grochowski","email":"ggrochow@gmail.com","username":"ggrochow","avatars":[{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Verified":{"approved":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":1,"date":"2017-02-01 07:00:00.000000000","_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0},"Code-Review":{"approved":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"all":[{"value":2,"date":"2017-02-01 07:00:00.000000000","_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Well-Formed":{"all":[{"value":0,"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}],"values":{"-1":"Commit is not well-formed"," 0":"Well-formedness not checked","+1":"Commit is well-formed"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-01 06:59:58.000000000","updated_by":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"reviewer":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"state":"REVIEWER"}],"messages":[{"id":"8147c4c5e7896e0527b63626aa8f6482134e0dfa","author":{"_account_id":1003910,"name":"Graham Grochowski","email":"ggrochow@gmail.com","username":"ggrochow","avatars":[{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-01-20 06:46:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a92a6a7925c56d1a8841a19f62931cccf7597f9","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-01-20 09:56:46.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9d62063e87440e34a79acdf5157958d311313942","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-02-01 06:33:26.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"910aac402ef9f616d44a878cab13a47cbc5cb4f3","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-02-01 06:59:58.000000000","message":"Patch Set 2: Code-Review+2 Verified+1","accounts_in_message":[],"_revision_number":2},{"id":"8152679d25c7e91838b460a76f44453721d22197","author":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2017-02-01 07:00:00.000000000","message":"Change has been successfully cherry-picked as 2b6e3bbc823aa68d7aa5b7f3bb8ece1b2c284d0e by Michael Nitschinger","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2b6e3bbc823aa68d7aa5b7f3bb8ece1b2c284d0e","revisions":{"189d22772e9360a1704622303e1b082594c7bdbb":{"kind":"REWORK","_number":1,"created":"2017-01-20 06:46:40.000000000","uploader":{"_account_id":1003910,"name":"Graham Grochowski","email":"ggrochow@gmail.com","username":"ggrochow","avatars":[{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/38de135625dbd2c719ef99fd2b939fa0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/70/72270/1","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/70/72270/1","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/1 \u0026\u0026 git checkout -b change-72270 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/70/72270/1","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd7e071a418411cf11cc0ddf290aced073412b3b","subject":"SPY-191: Don\u0027t force reconnect on E2BIG with binary protocol."}],"author":{"name":"Graham Grochowski","email":"ggrochow@gmail.com","date":"2017-01-20 06:46:32.000000000","tz":-480},"committer":{"name":"Graham Grochowski","email":"ggrochow@gmail.com","date":"2017-01-20 06:46:32.000000000","tz":-480},"subject":"Ensure connection key is valid before checking if writable","message":"Ensure connection key is valid before checking if writable\n\nChange-Id: Ic0db65f9c7ccc3a7b9738aaff0e3c7e60d7f25c2\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"fd7e071a418411cf11cc0ddf290aced073412b3b","is_merged_in_target_branch":true,"change_id":"Idf392d146d30b2e96dc198a93a3cc6598dae3fc6","change_number":61927,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"5d1a40efe27cb4e120635f9cf48cac9d6bf149ad":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2017-02-01 06:33:26.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/70/72270/2","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/70/72270/2","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/2 \u0026\u0026 git checkout -b change-72270 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/70/72270/2","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd7e071a418411cf11cc0ddf290aced073412b3b","subject":"SPY-191: Don\u0027t force reconnect on E2BIG with binary protocol."}],"author":{"name":"Graham Grochowski","email":"ggrochow@gmail.com","date":"2017-01-20 06:46:32.000000000","tz":-480},"committer":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2017-02-01 06:31:20.000000000","tz":60},"subject":"SPY-192: Ensure connection key is valid before checking if writable.","message":"SPY-192: Ensure connection key is valid before checking if writable.\n\nMotivation\n----------\nIt has been discovered in the wild that sometimes CancelledKeyException are\nreceived even if the key has been checked for validity before. It turns out\nthat the validity can change between the check and the next function call.\n\nModifications\n-------------\nThe changeset makes sure to check if it is valid on both reading and\nsubsequent writing, reducing the chance of race conditions and interleaved\nstate changes.\n\nResult\n------\nMore stable behavior at runtime and less chance of CancelledKeyException.\n\nChange-Id: Ic0db65f9c7ccc3a7b9738aaff0e3c7e60d7f25c2\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"fd7e071a418411cf11cc0ddf290aced073412b3b","is_merged_in_target_branch":true,"change_id":"Idf392d146d30b2e96dc198a93a3cc6598dae3fc6","change_number":61927,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"},"2b6e3bbc823aa68d7aa5b7f3bb8ece1b2c284d0e":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2017-02-01 07:00:00.000000000","uploader":{"_account_id":1000327,"name":"Michael Nitschinger","email":"michael.nitschinger@couchbase.com","username":"daschl","avatars":[{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/ca669dcaa36c077d54b96af979d77b9d.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/70/72270/3","fetch":{"anonymous http":{"url":"https://review.couchbase.org/spymemcached","ref":"refs/changes/70/72270/3","commands":{"Branch":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/3 \u0026\u0026 git checkout -b change-72270 FETCH_HEAD","Checkout":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.couchbase.org/spymemcached refs/changes/70/72270/3","Reset To":"git fetch https://review.couchbase.org/spymemcached refs/changes/70/72270/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"fd7e071a418411cf11cc0ddf290aced073412b3b","subject":"SPY-191: Don\u0027t force reconnect on E2BIG with binary protocol."}],"author":{"name":"Graham Grochowski","email":"ggrochow@gmail.com","date":"2017-01-20 06:46:32.000000000","tz":-480},"committer":{"name":"Michael Nitschinger","email":"michael@nitschinger.at","date":"2017-02-01 07:00:00.000000000","tz":0},"subject":"SPY-192: Ensure connection key is valid before checking if writable.","message":"SPY-192: Ensure connection key is valid before checking if writable.\n\nMotivation\n----------\nIt has been discovered in the wild that sometimes CancelledKeyException are\nreceived even if the key has been checked for validity before. It turns out\nthat the validity can change between the check and the next function call.\n\nModifications\n-------------\nThe changeset makes sure to check if it is valid on both reading and\nsubsequent writing, reducing the chance of race conditions and interleaved\nstate changes.\n\nResult\n------\nMore stable behavior at runtime and less chance of CancelledKeyException.\n\nChange-Id: Ic0db65f9c7ccc3a7b9738aaff0e3c7e60d7f25c2\nReviewed-on: http://review.couchbase.org/72270\nReviewed-by: Michael Nitschinger \u003cmichael@nitschinger.at\u003e\nTested-by: Michael Nitschinger \u003cmichael@nitschinger.at\u003e\n"},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"fd7e071a418411cf11cc0ddf290aced073412b3b","is_merged_in_target_branch":true,"change_id":"Idf392d146d30b2e96dc198a93a3cc6598dae3fc6","change_number":61927,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}