)]}'
{"src/main/java/net/spy/memcached/MemcachedClient.java":[{"author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"53dce7da38618ecde88d8a228e88a62e06681996","unresolved":false,"context_lines":[{"line_number":213,"context_line":"\t */"},{"line_number":214,"context_line":"\tpublic MemcachedClient(final List\u003cURI\u003e baseList, final String bucketName,"},{"line_number":215,"context_line":"\t\tfinal String usr, final String pwd) throws IOException, ConfigurationException {"},{"line_number":216,"context_line":"\t\tthis(null, baseList, bucketName, usr, pwd);"},{"line_number":217,"context_line":"\t}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"\t/**"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F8ks%3D","line":216,"updated":"2011-06-28 22:42:44.000000000","message":"I think it\u0027d simplify the code a lot if you just passed in a new ConnectionFactory here instead of just handling the null case below...","commit_id":"cf06e154755de50b7ee3f686f9b56e99b2f7273f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ef1ec8fded952f08afad5d48d40965a89e5da054","unresolved":false,"context_lines":[{"line_number":213,"context_line":"\t */"},{"line_number":214,"context_line":"\tpublic MemcachedClient(final List\u003cURI\u003e baseList, final String bucketName,"},{"line_number":215,"context_line":"\t\tfinal String usr, final String pwd) throws IOException, ConfigurationException {"},{"line_number":216,"context_line":"\t\tthis(null, baseList, bucketName, usr, pwd);"},{"line_number":217,"context_line":"\t}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"\t/**"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F8kc%3D","line":216,"in_reply_to":"AAABRn%2F%2F8ks%3D","updated":"2011-06-28 22:47:02.000000000","message":"Done","commit_id":"cf06e154755de50b7ee3f686f9b56e99b2f7273f"},{"author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"53dce7da38618ecde88d8a228e88a62e06681996","unresolved":false,"context_lines":[{"line_number":244,"context_line":"\t */"},{"line_number":245,"context_line":"\tpublic MemcachedClient(ConnectionFactory cf, final List\u003cURI\u003e baseList,"},{"line_number":246,"context_line":"\t\t\tfinal String bucketName, final String usr, final String pwd)"},{"line_number":247,"context_line":"\t\t\tthrows IOException, ConfigurationException {"},{"line_number":248,"context_line":"\t\tfor (URI bu : baseList) {"},{"line_number":249,"context_line":"\t\t\tif (!bu.isAbsolute()) {"},{"line_number":250,"context_line":"\t\t\t\tthrow new IllegalArgumentException(\"The base URI must be absolute\");"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F8ko%3D","line":247,"updated":"2011-06-28 22:42:44.000000000","message":"... then we can throw an NPE if cf is null.","commit_id":"cf06e154755de50b7ee3f686f9b56e99b2f7273f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ef1ec8fded952f08afad5d48d40965a89e5da054","unresolved":false,"context_lines":[{"line_number":244,"context_line":"\t */"},{"line_number":245,"context_line":"\tpublic MemcachedClient(ConnectionFactory cf, final List\u003cURI\u003e baseList,"},{"line_number":246,"context_line":"\t\t\tfinal String bucketName, final String usr, final String pwd)"},{"line_number":247,"context_line":"\t\t\tthrows IOException, ConfigurationException {"},{"line_number":248,"context_line":"\t\tfor (URI bu : baseList) {"},{"line_number":249,"context_line":"\t\t\tif (!bu.isAbsolute()) {"},{"line_number":250,"context_line":"\t\t\t\tthrow new IllegalArgumentException(\"The base URI must be absolute\");"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F8kY%3D","line":247,"in_reply_to":"AAABRn%2F%2F8ko%3D","updated":"2011-06-28 22:47:02.000000000","message":"Ok assuming no code changes here.","commit_id":"cf06e154755de50b7ee3f686f9b56e99b2f7273f"},{"author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"53dce7da38618ecde88d8a228e88a62e06681996","unresolved":false,"context_lines":[{"line_number":253,"context_line":"\t\tthis.configurationProvider \u003d new ConfigurationProviderHTTP(baseList, usr, pwd);"},{"line_number":254,"context_line":"\t\tBucket bucket \u003d this.configurationProvider.getBucketConfiguration(bucketName);"},{"line_number":255,"context_line":"\t\tConfig config \u003d bucket.getConfig();"},{"line_number":256,"context_line":"\t\t"},{"line_number":257,"context_line":"\t\tif (cf !\u003d null \u0026\u0026 !(cf instanceof BinaryConnectionFactory)) {"},{"line_number":258,"context_line":"\t\t\tthrow new IllegalArgumentException(\"ConnectionFactory must be of type \" +"},{"line_number":259,"context_line":"\t\t\t\t\t\"BinaryConnectionFactory\");"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F8kw%3D","line":256,"updated":"2011-06-28 22:42:44.000000000","message":"whitespace here.","commit_id":"cf06e154755de50b7ee3f686f9b56e99b2f7273f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ef1ec8fded952f08afad5d48d40965a89e5da054","unresolved":false,"context_lines":[{"line_number":253,"context_line":"\t\tthis.configurationProvider \u003d new ConfigurationProviderHTTP(baseList, usr, pwd);"},{"line_number":254,"context_line":"\t\tBucket bucket \u003d this.configurationProvider.getBucketConfiguration(bucketName);"},{"line_number":255,"context_line":"\t\tConfig config \u003d bucket.getConfig();"},{"line_number":256,"context_line":"\t\t"},{"line_number":257,"context_line":"\t\tif (cf !\u003d null \u0026\u0026 !(cf instanceof BinaryConnectionFactory)) {"},{"line_number":258,"context_line":"\t\t\tthrow new IllegalArgumentException(\"ConnectionFactory must be of type \" +"},{"line_number":259,"context_line":"\t\t\t\t\t\"BinaryConnectionFactory\");"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F8kU%3D","line":256,"in_reply_to":"AAABRn%2F%2F8kw%3D","updated":"2011-06-28 22:47:02.000000000","message":"Done","commit_id":"cf06e154755de50b7ee3f686f9b56e99b2f7273f"},{"author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"53dce7da38618ecde88d8a228e88a62e06681996","unresolved":false,"context_lines":[{"line_number":264,"context_line":"\t\t\tcfb \u003d new ConnectionFactoryBuilder();"},{"line_number":265,"context_line":"\t\t} else {"},{"line_number":266,"context_line":"\t\t\tcfb \u003d new ConnectionFactoryBuilder(cf);"},{"line_number":267,"context_line":"\t\t}"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"\t\tif (config.getConfigType() \u003d\u003d ConfigType.MEMBASE) {"},{"line_number":270,"context_line":"\t\t\tcfb.setFailureMode(FailureMode.Retry)"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F8kk%3D","line":267,"updated":"2011-06-28 22:42:44.000000000","message":"And these five lines can go.  :)","commit_id":"cf06e154755de50b7ee3f686f9b56e99b2f7273f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ef1ec8fded952f08afad5d48d40965a89e5da054","unresolved":false,"context_lines":[{"line_number":264,"context_line":"\t\t\tcfb \u003d new ConnectionFactoryBuilder();"},{"line_number":265,"context_line":"\t\t} else {"},{"line_number":266,"context_line":"\t\t\tcfb \u003d new ConnectionFactoryBuilder(cf);"},{"line_number":267,"context_line":"\t\t}"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"\t\tif (config.getConfigType() \u003d\u003d ConfigType.MEMBASE) {"},{"line_number":270,"context_line":"\t\t\tcfb.setFailureMode(FailureMode.Retry)"}],"source_content_type":"text/x-java","patch_set":3,"id":"AAABRn%2F%2F8kQ%3D","line":267,"in_reply_to":"AAABRn%2F%2F8kk%3D","updated":"2011-06-28 22:47:02.000000000","message":"I think you mean 4 lines can go.","commit_id":"cf06e154755de50b7ee3f686f9b56e99b2f7273f"}]}