)]}'
{"src/main/java/net/spy/memcached/ConnectionFactoryBuilder.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":287,"context_line":"\t\t\t\t}"},{"line_number":288,"context_line":"\t\t\t}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"\t\t\t@Override"},{"line_number":291,"context_line":"\t\t\tpublic Transcoder\u003cObject\u003e getDefaultTranscoder() {"},{"line_number":292,"context_line":"\t\t\t\treturn transcoder \u003d\u003d null ?"},{"line_number":293,"context_line":"\t\t\t\t\t\tsuper.getDefaultTranscoder() : transcoder;"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FaE%3D","side":"PARENT","line":290,"updated":"2011-07-26 01:37:01.000000000","message":"What is this overriding?  Never caught this before, but at the moment it seems wrong.","commit_id":"5583fd0969152b9447eb3f127f3be57e63ae1f98"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":287,"context_line":"\t\t\t\t}"},{"line_number":288,"context_line":"\t\t\t}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"\t\t\t@Override"},{"line_number":291,"context_line":"\t\t\tpublic Transcoder\u003cObject\u003e getDefaultTranscoder() {"},{"line_number":292,"context_line":"\t\t\t\treturn transcoder \u003d\u003d null ?"},{"line_number":293,"context_line":"\t\t\t\t\t\tsuper.getDefaultTranscoder() : transcoder;"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZI%3D","side":"PARENT","line":290,"in_reply_to":"AAABSH%2F%2F%2FaE%3D","updated":"2011-07-26 02:00:27.000000000","message":"I\u0027m pretty sure that there are many random issues like this that should be addressed in a large commit that fixes this type of thing. Let\u0027s have this done with the code formatting.","commit_id":"5583fd0969152b9447eb3f127f3be57e63ae1f98"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":306,"context_line":"\t\t\t\treturn hashAlg \u003d\u003d null ? super.getHashAlg() : hashAlg;"},{"line_number":307,"context_line":"\t\t\t}"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"\t\t\t@Override"},{"line_number":310,"context_line":"\t\t\tpublic Collection\u003cConnectionObserver\u003e getInitialObservers() {"},{"line_number":311,"context_line":"\t\t\t\treturn initialObservers;"},{"line_number":312,"context_line":"\t\t\t}"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FaA%3D","line":309,"updated":"2011-07-26 01:37:01.000000000","message":"What is this overriding?","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":306,"context_line":"\t\t\t\treturn hashAlg \u003d\u003d null ? super.getHashAlg() : hashAlg;"},{"line_number":307,"context_line":"\t\t\t}"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"\t\t\t@Override"},{"line_number":310,"context_line":"\t\t\tpublic Collection\u003cConnectionObserver\u003e getInitialObservers() {"},{"line_number":311,"context_line":"\t\t\t\treturn initialObservers;"},{"line_number":312,"context_line":"\t\t\t}"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZQ%3D","line":309,"in_reply_to":"AAABSH%2F%2F%2FaA%3D","updated":"2011-07-26 02:00:27.000000000","message":"This code is mostly copied so that is why the override is there. I removed it though.","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":411,"context_line":"\t\t\t\tswitch(getLocator()) {"},{"line_number":412,"context_line":"\t\t\t\t\tcase CONSISTENT:"},{"line_number":413,"context_line":"\t\t\t\t\t\treturn new KetamaNodeLocator(nodes, getHashAlg());"},{"line_number":414,"context_line":"\t\t            case VBUCKET:"},{"line_number":415,"context_line":"\t\t                return new VBucketNodeLocator(nodes, getVBucketConfig());"},{"line_number":416,"context_line":"\t\t\t\t\tdefault: throw new IllegalStateException("},{"line_number":417,"context_line":"\t\t\t\t\t\t\t\"Unhandled locator type: \" + locator);"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FaI%3D","line":414,"updated":"2011-07-26 01:37:01.000000000","message":"whitespace funkyness here?","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":411,"context_line":"\t\t\t\tswitch(getLocator()) {"},{"line_number":412,"context_line":"\t\t\t\t\tcase CONSISTENT:"},{"line_number":413,"context_line":"\t\t\t\t\t\treturn new KetamaNodeLocator(nodes, getHashAlg());"},{"line_number":414,"context_line":"\t\t            case VBUCKET:"},{"line_number":415,"context_line":"\t\t                return new VBucketNodeLocator(nodes, getVBucketConfig());"},{"line_number":416,"context_line":"\t\t\t\t\tdefault: throw new IllegalStateException("},{"line_number":417,"context_line":"\t\t\t\t\t\t\t\"Unhandled locator type: \" + locator);"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZM%3D","line":414,"in_reply_to":"AAABSH%2F%2F%2FaI%3D","updated":"2011-07-26 02:00:27.000000000","message":"Again copied, but I will fix it.","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"}],"src/main/java/net/spy/memcached/MembaseClient.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\tprivate volatile boolean reconfiguring \u003d false;"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"\t/**"},{"line_number":27,"context_line":"\t * Get a MemcachedClient based on the REST response from a Membase server."},{"line_number":28,"context_line":"\t *"},{"line_number":29,"context_line":"\t * This constructor is merely a convenience for situations where the bucket"},{"line_number":30,"context_line":"\t * name is the same as the user name.  This is commonly the case."}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZ4%3D","line":27,"updated":"2011-07-26 01:37:01.000000000","message":"Isn\u0027t this a MembaseClient?","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\tprivate volatile boolean reconfiguring \u003d false;"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"\t/**"},{"line_number":27,"context_line":"\t * Get a MemcachedClient based on the REST response from a Membase server."},{"line_number":28,"context_line":"\t *"},{"line_number":29,"context_line":"\t * This constructor is merely a convenience for situations where the bucket"},{"line_number":30,"context_line":"\t * name is the same as the user name.  This is commonly the case."}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FY8%3D","line":27,"in_reply_to":"AAABSH%2F%2F%2FZ4%3D","updated":"2011-07-26 02:00:27.000000000","message":"Done","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"\t/**"},{"line_number":51,"context_line":"\t * Get a MemcachedClient based on the REST response from a Membase server"},{"line_number":52,"context_line":"\t * where the username is different than the bucket name."},{"line_number":53,"context_line":"\t *"},{"line_number":54,"context_line":"\t * To connect to the \"default\" special bucket for a given cluster, use an"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZ0%3D","line":51,"updated":"2011-07-26 01:37:01.000000000","message":"Same comment as above.","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"\t/**"},{"line_number":51,"context_line":"\t * Get a MemcachedClient based on the REST response from a Membase server"},{"line_number":52,"context_line":"\t * where the username is different than the bucket name."},{"line_number":53,"context_line":"\t *"},{"line_number":54,"context_line":"\t * To connect to the \"default\" special bucket for a given cluster, use an"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FY4%3D","line":51,"in_reply_to":"AAABSH%2F%2F%2FZ0%3D","updated":"2011-07-26 02:00:27.000000000","message":"Done","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\t\tsuper(cf, AddrUtil.getAddresses(cf.getVBucketConfig().getServers()), false);"},{"line_number":102,"context_line":"\t\tstart();"},{"line_number":103,"context_line":"\t}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"\tpublic void reconfigure(Bucket bucket) {"},{"line_number":106,"context_line":"\t\treconfiguring \u003d true;"},{"line_number":107,"context_line":"\t\ttry {"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZ8%3D","line":104,"updated":"2011-07-26 01:37:01.000000000","message":"Need minor javadoc here.  This is probably a bug in existing MemcachedClient object, but I think this is effectively something saying this is intended for internal use.","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\t\tsuper(cf, AddrUtil.getAddresses(cf.getVBucketConfig().getServers()), false);"},{"line_number":102,"context_line":"\t\tstart();"},{"line_number":103,"context_line":"\t}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"\tpublic void reconfigure(Bucket bucket) {"},{"line_number":106,"context_line":"\t\treconfiguring \u003d true;"},{"line_number":107,"context_line":"\t\ttry {"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZA%3D","line":104,"in_reply_to":"AAABSH%2F%2F%2FZ8%3D","updated":"2011-07-26 02:00:27.000000000","message":"Done","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":211,"context_line":"\t * Infinitely loop processing IO."},{"line_number":212,"context_line":"\t */"},{"line_number":213,"context_line":"\t@Override"},{"line_number":214,"context_line":"\tpublic void run() {"},{"line_number":215,"context_line":"\t\twhile(running) {"},{"line_number":216,"context_line":"            if (!reconfiguring) {"},{"line_number":217,"context_line":"                try {"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZw%3D","line":214,"updated":"2011-07-26 01:37:01.000000000","message":"Why is this overridden?  Looking at the superclass, the implementation seems the same.","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":211,"context_line":"\t * Infinitely loop processing IO."},{"line_number":212,"context_line":"\t */"},{"line_number":213,"context_line":"\t@Override"},{"line_number":214,"context_line":"\tpublic void run() {"},{"line_number":215,"context_line":"\t\twhile(running) {"},{"line_number":216,"context_line":"            if (!reconfiguring) {"},{"line_number":217,"context_line":"                try {"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FYo%3D","line":214,"in_reply_to":"AAABSH%2F%2F%2FZw%3D","updated":"2011-07-26 02:00:27.000000000","message":"The if statement for reconfiguring isn\u0027t in the superclass.","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":227,"context_line":"                }"},{"line_number":228,"context_line":"\t\t\t}"},{"line_number":229,"context_line":"\t\t}"},{"line_number":230,"context_line":"\t\tgetLogger().info(\"Shut down memcached client\");"},{"line_number":231,"context_line":"\t}"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"\t@Override"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FY0%3D","line":230,"updated":"2011-07-26 02:00:27.000000000","message":"found another memcached here!","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"}],"src/main/java/net/spy/memcached/MemcachedClient.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":112,"context_line":" * \u003c/pre\u003e"},{"line_number":113,"context_line":" */"},{"line_number":114,"context_line":"public class MemcachedClient extends SpyThread"},{"line_number":115,"context_line":"\timplements MemcachedClientIF, ConnectionObserver, Reconfigurable {"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"\tprivate volatile boolean running\u003dtrue;"},{"line_number":118,"context_line":"\tprivate volatile boolean shuttingDown\u003dfalse;"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZo%3D","side":"PARENT","line":115,"updated":"2011-07-26 01:37:01.000000000","message":"Maybe I asked this before, but I think this still needs to be reconfigurable.  What about memcached buckets?  Must they use MembaseClient?","commit_id":"5583fd0969152b9447eb3f127f3be57e63ae1f98"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":112,"context_line":" * \u003c/pre\u003e"},{"line_number":113,"context_line":" */"},{"line_number":114,"context_line":"public class MemcachedClient extends SpyThread"},{"line_number":115,"context_line":"\timplements MemcachedClientIF, ConnectionObserver, Reconfigurable {"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"\tprivate volatile boolean running\u003dtrue;"},{"line_number":118,"context_line":"\tprivate volatile boolean shuttingDown\u003dfalse;"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FYI%3D","side":"PARENT","line":115,"in_reply_to":"AAABSH%2F%2F%2FZo%3D","updated":"2011-07-26 02:00:27.000000000","message":"My understanding is that you use MembaseClient for Membase server and MemcachedClient for memcached server.","commit_id":"5583fd0969152b9447eb3f127f3be57e63ae1f98"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"00d96a8a6d4ba647a367c0145255bf0de7b7d5c8","unresolved":false,"context_lines":[{"line_number":155,"context_line":"\t\tthis(cf, addrs, true);"},{"line_number":156,"context_line":"\t}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"\tprotected MemcachedClient(ConnectionFactory cf, List\u003cInetSocketAddress\u003e addrs,"},{"line_number":159,"context_line":"\t\t\tboolean startIOThread) throws IOException {"},{"line_number":160,"context_line":"\t\tif(cf \u003d\u003d null) {"},{"line_number":161,"context_line":"\t\t\tthrow new NullPointerException(\"Connection factory required\");"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FZs%3D","line":158,"updated":"2011-07-26 01:37:01.000000000","message":"Maybe there\u0027s a good argument for this being public?","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fdd8eb5398a346f1f7cb6136a0638ed4a88d558e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"\t\tthis(cf, addrs, true);"},{"line_number":156,"context_line":"\t}"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"\tprotected MemcachedClient(ConnectionFactory cf, List\u003cInetSocketAddress\u003e addrs,"},{"line_number":159,"context_line":"\t\t\tboolean startIOThread) throws IOException {"},{"line_number":160,"context_line":"\t\tif(cf \u003d\u003d null) {"},{"line_number":161,"context_line":"\t\t\tthrow new NullPointerException(\"Connection factory required\");"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABSH%2F%2F%2FYY%3D","line":158,"in_reply_to":"AAABSH%2F%2F%2FZs%3D","updated":"2011-07-26 02:00:27.000000000","message":"Let\u0027s wait for someone to make that argument since it won\u0027t affect backward compatibility in the future.","commit_id":"095001965e8c409b2d72d4f8987032470a4c6c21"}]}