)]}'
{"src/main/java/net/spy/memcached/MemcachedConnection.java":[{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fc9212a4832bf478bac2f40f1d9048092dadbcc3","unresolved":false,"context_lines":[{"line_number":904,"context_line":"\t\t}"},{"line_number":905,"context_line":"\t\tassert isAlive() : \"IO Thread is not running.\";"},{"line_number":906,"context_line":"\t}"},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"    /**"},{"line_number":909,"context_line":"\t * Infinitely loop processing IO."},{"line_number":910,"context_line":"\t */"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2Ffw%3D","line":907,"updated":"2011-07-25 17:10:40.000000000","message":"Formatting error","commit_id":"a9e2cd0a6ac4a4be468511dde69c0edd76d9abcf"}],"src/main/java/net/spy/memcached/TapConnectionProvider.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"73bf38148ff1b3acef55e30a87715be07e6fc915","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"\tprivate volatile boolean shuttingDown\u003dfalse;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"\tprivate final MemcachedConnection conn;"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"\tfinal OperationFactory opFact;"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FZE%3D","side":"PARENT","line":38,"updated":"2011-07-26 01:49:02.000000000","message":"didn\u0027t I just see this renamed to mconn somewhere else?  Maybe that\u0027s unrelated here.","commit_id":"6927e75f573db07d214be3c48b4fe77b1082f069"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3079be45cea3a0af55d527c88198d83a84ad3f8a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"\tprivate volatile boolean shuttingDown\u003dfalse;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"\tprivate final MemcachedConnection conn;"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"\tfinal OperationFactory opFact;"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXo%3D","side":"PARENT","line":38,"in_reply_to":"AAABSH%2F%2F%2FZE%3D","updated":"2011-07-26 03:13:11.000000000","message":"Yes, it\u0027s unrelated. A tap connection will only make a connection with the Memcached protocol so there is no need to differentiate between connections.","commit_id":"6927e75f573db07d214be3c48b4fe77b1082f069"}],"src/test/java/net/spy/memcached/spring/MemcachedClientFactoryBeanTest.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"73bf38148ff1b3acef55e30a87715be07e6fc915","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    final MemcachedClient memcachedClient \u003d (MemcachedClient)factory.getObject();"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Assert.assertEquals(\"deamon\", true, memcachedClient.isDaemon());"},{"line_number":37,"context_line":"    Assert.assertEquals(\"servers\", 2, memcachedClient.getUnavailableServers().size());"},{"line_number":38,"context_line":"    Assert.assertSame(\"transcoder\", transcoder, memcachedClient.getTranscoder());"},{"line_number":39,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FYw%3D","side":"PARENT","line":36,"updated":"2011-07-26 01:49:02.000000000","message":"Why is this being removed?  It\u0027s misspelled, but it\u0027s correct already, right?\n\nThis also begs, do we need a spring factory bean for the MembaseClient and CouchbaseClient?","commit_id":"6927e75f573db07d214be3c48b4fe77b1082f069"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3079be45cea3a0af55d527c88198d83a84ad3f8a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    final MemcachedClient memcachedClient \u003d (MemcachedClient)factory.getObject();"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Assert.assertEquals(\"deamon\", true, memcachedClient.isDaemon());"},{"line_number":37,"context_line":"    Assert.assertEquals(\"servers\", 2, memcachedClient.getUnavailableServers().size());"},{"line_number":38,"context_line":"    Assert.assertSame(\"transcoder\", transcoder, memcachedClient.getTranscoder());"},{"line_number":39,"context_line":"  }"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXw%3D","side":"PARENT","line":36,"in_reply_to":"AAABSH%2F%2F%2FYw%3D","updated":"2011-07-26 03:13:11.000000000","message":"We moved the thread from MemcachedClient to MembaseClient and therefore are not in the correct scope to make this function call. As a result I removed the test.\n\nAs for the spring factory bean. This makes sense. Can someone verify that we actually need this. Also needing the spring factory bean shouldn\u0027t affect the correctness of this code. The factory bean can be added in another commit.","commit_id":"6927e75f573db07d214be3c48b4fe77b1082f069"}]}
