)]}'
{"buildfile":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":85,"context_line":"               \"org.easymock:easymockclassextension:jar:2.4\","},{"line_number":86,"context_line":"               \"junit-addons:junit-addons:jar:1.4\","},{"line_number":87,"context_line":"               \"cglib:cglib:jar:2.2.2\", \"asm:asm:jar:3.3.1\","},{"line_number":88,"context_line":"               \"org.apache.httpcomponents:httpcore:jar:4.1\","},{"line_number":89,"context_line":"               \"org.apache.httpcomponents:httpcore-nio:jar:4.1.1\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  # Gen build"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAABSH%2F%2F%2FYg%3D","line":88,"updated":"2011-07-26 02:49:32.000000000","message":"Are these the oldest we can rely on?","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"               \"org.easymock:easymockclassextension:jar:2.4\","},{"line_number":86,"context_line":"               \"junit-addons:junit-addons:jar:1.4\","},{"line_number":87,"context_line":"               \"cglib:cglib:jar:2.2.2\", \"asm:asm:jar:3.3.1\","},{"line_number":88,"context_line":"               \"org.apache.httpcomponents:httpcore:jar:4.1\","},{"line_number":89,"context_line":"               \"org.apache.httpcomponents:httpcore-nio:jar:4.1.1\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  # Gen build"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"AAABSH%2F%2F%2FWU%3D","line":88,"in_reply_to":"AAABSH%2F%2F%2FYg%3D","updated":"2011-07-26 06:13:07.000000000","message":"Yeah, I actually saw lots of fixes pertaining to chunk encoding in the 4.1 releases.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"}],"src/main/java/net/spy/memcached/CouchbaseClient.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import net.spy.memcached.vbucket.ConfigurationException;"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"public class CouchbaseClient extends MembaseClient {"},{"line_number":26,"context_line":"\t"},{"line_number":27,"context_line":"\tprivate CouchbaseConnection cconn;"},{"line_number":28,"context_line":"\tprivate final String bucketName;"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FYQ%3D","line":26,"updated":"2011-07-26 02:49:32.000000000","message":"I know this one is first review, but whitespace!","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import net.spy.memcached.vbucket.ConfigurationException;"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"public class CouchbaseClient extends MembaseClient {"},{"line_number":26,"context_line":"\t"},{"line_number":27,"context_line":"\tprivate CouchbaseConnection cconn;"},{"line_number":28,"context_line":"\tprivate final String bucketName;"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FV8%3D","line":26,"in_reply_to":"AAABSH%2F%2F%2FYQ%3D","updated":"2011-07-26 06:13:07.000000000","message":"Done","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\t\t"},{"line_number":42,"context_line":"\t\tList\u003cInetSocketAddress\u003e conv \u003d new LinkedList\u003cInetSocketAddress\u003e();"},{"line_number":43,"context_line":"\t\twhile (!addrs.isEmpty()) { conv.add(addrs.remove(0)); }"},{"line_number":44,"context_line":"\t\twhile (!conv.isEmpty()) { addrs.add(new InetSocketAddress(conv.remove(0).getHostName(), 5984)); }"},{"line_number":45,"context_line":"\t\t"},{"line_number":46,"context_line":"\t\tcconn \u003d cf.createCouchDBConnection(addrs);"},{"line_number":47,"context_line":"\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FX0%3D","line":44,"updated":"2011-07-26 02:49:32.000000000","message":"This is wrong.  The list of servers comes back from the configuration, not from an assumption that all servers have a 5894 you can query.  We\u0027ll have to fetch it out of the configuration.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"\t\t"},{"line_number":42,"context_line":"\t\tList\u003cInetSocketAddress\u003e conv \u003d new LinkedList\u003cInetSocketAddress\u003e();"},{"line_number":43,"context_line":"\t\twhile (!addrs.isEmpty()) { conv.add(addrs.remove(0)); }"},{"line_number":44,"context_line":"\t\twhile (!conv.isEmpty()) { addrs.add(new InetSocketAddress(conv.remove(0).getHostName(), 5984)); }"},{"line_number":45,"context_line":"\t\t"},{"line_number":46,"context_line":"\t\tcconn \u003d cf.createCouchDBConnection(addrs);"},{"line_number":47,"context_line":"\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FU8%3D","line":44,"in_reply_to":"AAABSH%2F%2F%2FX0%3D","updated":"2011-07-26 06:13:07.000000000","message":"Also adding a bug for this, but I plan on having it fixed for the developer preview. Spy-4.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\t\tcconn \u003d cf.createCouchDBConnection(addrs);"},{"line_number":47,"context_line":"\t}"},{"line_number":48,"context_line":"\t"},{"line_number":49,"context_line":"\tpublic View getView(String designDocumentName, String viewName)"},{"line_number":50,"context_line":"\t\t\tthrows InterruptedException, ExecutionException {"},{"line_number":51,"context_line":"\t\tCollection\u003cView\u003e views \u003d getViews(designDocumentName);"},{"line_number":52,"context_line":"\t\tfor (View v : views) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXs%3D","line":49,"updated":"2011-07-26 02:49:32.000000000","message":"public methods need javadoc","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\t\tcconn \u003d cf.createCouchDBConnection(addrs);"},{"line_number":47,"context_line":"\t}"},{"line_number":48,"context_line":"\t"},{"line_number":49,"context_line":"\tpublic View getView(String designDocumentName, String viewName)"},{"line_number":50,"context_line":"\t\t\tthrows InterruptedException, ExecutionException {"},{"line_number":51,"context_line":"\t\tCollection\u003cView\u003e views \u003d getViews(designDocumentName);"},{"line_number":52,"context_line":"\t\tfor (View v : views) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FV0%3D","line":49,"in_reply_to":"AAABSH%2F%2F%2FXs%3D","updated":"2011-07-26 06:13:07.000000000","message":"Done","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\t\t\t\treturn v;"},{"line_number":55,"context_line":"\t\t\t}"},{"line_number":56,"context_line":"\t\t}"},{"line_number":57,"context_line":"\t\tgetLogger().warn(\"No view for design document \" + designDocumentName + \" was found\");"},{"line_number":58,"context_line":"\t\treturn null;"},{"line_number":59,"context_line":"\t}"},{"line_number":60,"context_line":"\t"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXk%3D","line":57,"updated":"2011-07-26 02:49:32.000000000","message":"Maybe this is okay, but why return null here?  This just forces a null check elsewhere?  And should this be error level logging?\n\nAt the moment, I can\u0027t think of a good reason for getting a null View object if the view isn\u0027t there.  You won\u0027t be able to recover later.  Throw an Exception here?","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"\t\t\t\treturn v;"},{"line_number":55,"context_line":"\t\t\t}"},{"line_number":56,"context_line":"\t\t}"},{"line_number":57,"context_line":"\t\tgetLogger().warn(\"No view for design document \" + designDocumentName + \" was found\");"},{"line_number":58,"context_line":"\t\treturn null;"},{"line_number":59,"context_line":"\t}"},{"line_number":60,"context_line":"\t"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVw%3D","line":57,"in_reply_to":"AAABSH%2F%2F%2FXk%3D","updated":"2011-07-26 06:13:07.000000000","message":"To me this is like doing a get in memcached and if the object doesn\u0027t exist in the cache then we return null to the user. In a later commit the view\u0027s will be returned as futures and even in that case if you try to get a non-existent view you will get null. I don\u0027t really see a better way of doing it.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\t\treturn crv;"},{"line_number":91,"context_line":"\t}"},{"line_number":92,"context_line":"\t"},{"line_number":93,"context_line":"\tpublic void addOp(final HttpOperation op) {"},{"line_number":94,"context_line":"\t\tcconn.checkState();"},{"line_number":95,"context_line":"\t\tcconn.addOp(op);"},{"line_number":96,"context_line":"\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXg%3D","line":93,"updated":"2011-07-26 02:49:32.000000000","message":"similar to the other addOp, there should be doc here saying \"don\u0027t use this\".  Also, does it really need to be public?","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"\t\treturn crv;"},{"line_number":91,"context_line":"\t}"},{"line_number":92,"context_line":"\t"},{"line_number":93,"context_line":"\tpublic void addOp(final HttpOperation op) {"},{"line_number":94,"context_line":"\t\tcconn.checkState();"},{"line_number":95,"context_line":"\t\tcconn.addOp(op);"},{"line_number":96,"context_line":"\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FV4%3D","line":93,"in_reply_to":"AAABSH%2F%2F%2FXg%3D","updated":"2011-07-26 06:13:07.000000000","message":"Done","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\tpublic boolean shutdown(long duration, TimeUnit units) {"},{"line_number":105,"context_line":"\t\ttry {"},{"line_number":106,"context_line":"\t\t\tsuper.shutdown(duration, units);"},{"line_number":107,"context_line":"\t\t\tcconn.shutdown();"},{"line_number":108,"context_line":"\t\t\treturn true;"},{"line_number":109,"context_line":"\t\t} catch (IOException e) {"},{"line_number":110,"context_line":"\t\t\tgetLogger().error(\"Error shutting down CouchbaseClient\");"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXc%3D","line":107,"updated":"2011-07-26 02:49:32.000000000","message":"The super class has this check against duplicate attempts to shutdown.  Should that check be here as well?","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\tpublic boolean shutdown(long duration, TimeUnit units) {"},{"line_number":105,"context_line":"\t\ttry {"},{"line_number":106,"context_line":"\t\t\tsuper.shutdown(duration, units);"},{"line_number":107,"context_line":"\t\t\tcconn.shutdown();"},{"line_number":108,"context_line":"\t\t\treturn true;"},{"line_number":109,"context_line":"\t\t} catch (IOException e) {"},{"line_number":110,"context_line":"\t\t\tgetLogger().error(\"Error shutting down CouchbaseClient\");"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVA%3D","line":107,"in_reply_to":"AAABSH%2F%2F%2FXc%3D","updated":"2011-07-26 06:13:07.000000000","message":"I made the couchbase connection check for double shutdown here too, but my solution is not an optimal one. In this case I will file a bug and solve the issue later. Spy-3.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"}],"src/main/java/net/spy/memcached/CouchbaseConnection.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\t}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"\tpublic void addOp(final HttpOperation op) {"},{"line_number":94,"context_line":"\t\tnodes.get(getNextNode()).addOp(op);"},{"line_number":95,"context_line":"\t}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\tpublic void handleIO() {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXU%3D","line":94,"updated":"2011-07-26 02:49:32.000000000","message":"Just round robining here?","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"\t}"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"\tpublic void addOp(final HttpOperation op) {"},{"line_number":94,"context_line":"\t\tnodes.get(getNextNode()).addOp(op);"},{"line_number":95,"context_line":"\t}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"\tpublic void handleIO() {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVs%3D","line":94,"in_reply_to":"AAABSH%2F%2F%2FXU%3D","updated":"2011-07-26 06:13:07.000000000","message":"For now yes. In the future, I plan on doing something better.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\t\treturn nextNode \u003d (++nextNode % nodes.size());"},{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"\tpublic void checkState() {"},{"line_number":108,"context_line":"\t\tif (shutDown) {"},{"line_number":109,"context_line":"\t\t\tthrow new IllegalStateException(\"Shutting down\");"},{"line_number":110,"context_line":"\t\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXM%3D","line":107,"updated":"2011-07-26 02:49:32.000000000","message":"A method to maybe throw an unchecked exception and call an assertion?","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b43e03ca3421ba1d07728e97b025a9c0ba6dd66","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\t\treturn nextNode \u003d (++nextNode % nodes.size());"},{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"\tpublic void checkState() {"},{"line_number":108,"context_line":"\t\tif (shutDown) {"},{"line_number":109,"context_line":"\t\t\tthrow new IllegalStateException(\"Shutting down\");"},{"line_number":110,"context_line":"\t\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FRk%3D","line":107,"in_reply_to":"AAABSH%2F%2F%2FTs%3D","updated":"2011-07-26 07:03:31.000000000","message":"Made it protected.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\t\treturn nextNode \u003d (++nextNode % nodes.size());"},{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"\tpublic void checkState() {"},{"line_number":108,"context_line":"\t\tif (shutDown) {"},{"line_number":109,"context_line":"\t\t\tthrow new IllegalStateException(\"Shutting down\");"},{"line_number":110,"context_line":"\t\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVg%3D","line":107,"in_reply_to":"AAABSH%2F%2F%2FXM%3D","updated":"2011-07-26 06:13:07.000000000","message":"It was in the MemcachedConnection so I brought it over here and I do use it.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ca1893704490cc71c43f0af81789afe87ef266d5","unresolved":false,"context_lines":[{"line_number":104,"context_line":"\t\treturn nextNode \u003d (++nextNode % nodes.size());"},{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"\tpublic void checkState() {"},{"line_number":108,"context_line":"\t\tif (shutDown) {"},{"line_number":109,"context_line":"\t\t\tthrow new IllegalStateException(\"Shutting down\");"},{"line_number":110,"context_line":"\t\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FTs%3D","line":107,"in_reply_to":"AAABSH%2F%2F%2FXM%3D","updated":"2011-07-26 06:50:50.000000000","message":"Not sure what you\u0027re trying to do here, this needs to be addressed.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"\t@Override"},{"line_number":129,"context_line":"\tpublic void reconfigure(Bucket bucket) {"},{"line_number":130,"context_line":"\t\t// TODO Auto-generated method stub"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"\t}"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXY%3D","line":130,"updated":"2011-07-26 02:49:32.000000000","message":"I presume getting rid of nodes needs to go in here yet?","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"\t@Override"},{"line_number":129,"context_line":"\tpublic void reconfigure(Bucket bucket) {"},{"line_number":130,"context_line":"\t\t// TODO Auto-generated method stub"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"\t}"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVo%3D","line":130,"in_reply_to":"AAABSH%2F%2F%2FXY%3D","updated":"2011-07-26 06:13:07.000000000","message":"Yes, we haven\u0027t done any cluster reconfiguration work yet. That will come later.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":137,"context_line":"\t\t\tif (!reconfiguring) {"},{"line_number":138,"context_line":"\t\t\t\ttry {"},{"line_number":139,"context_line":"\t\t\t\t\thandleIO();"},{"line_number":140,"context_line":"\t\t\t\t} catch (Exception e) {"},{"line_number":141,"context_line":"\t\t\t\t\tlogRunException(e);"},{"line_number":142,"context_line":"\t\t\t\t}"},{"line_number":143,"context_line":"\t\t\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FXQ%3D","line":140,"updated":"2011-07-26 02:49:32.000000000","message":"Must not be complete.  I\u0027ll look at API mostly in this review then.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"\t\t\tif (!reconfiguring) {"},{"line_number":138,"context_line":"\t\t\t\ttry {"},{"line_number":139,"context_line":"\t\t\t\t\thandleIO();"},{"line_number":140,"context_line":"\t\t\t\t} catch (Exception e) {"},{"line_number":141,"context_line":"\t\t\t\t\tlogRunException(e);"},{"line_number":142,"context_line":"\t\t\t\t}"},{"line_number":143,"context_line":"\t\t\t}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVk%3D","line":140,"in_reply_to":"AAABSH%2F%2F%2FXQ%3D","updated":"2011-07-26 06:13:07.000000000","message":"No it\u0027s not complete. This will also be handled when I do the operation refactoring.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"}],"src/main/java/net/spy/memcached/CouchbaseNode.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":" * Licensed to the Apache Software Foundation (ASF) under one"},{"line_number":4,"context_line":" * or more contributor license agreements.  See the NOTICE file"},{"line_number":5,"context_line":" * distributed with this work for additional information"},{"line_number":6,"context_line":" * regarding copyright ownership.  The ASF licenses this file"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FWk%3D","line":3,"updated":"2011-07-26 02:49:32.000000000","message":"Definitely wrong.  Feels copy and pasty.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":3,"context_line":" * Licensed to the Apache Software Foundation (ASF) under one"},{"line_number":4,"context_line":" * or more contributor license agreements.  See the NOTICE file"},{"line_number":5,"context_line":" * distributed with this work for additional information"},{"line_number":6,"context_line":" * regarding copyright ownership.  The ASF licenses this file"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVc%3D","line":3,"in_reply_to":"AAABSH%2F%2F%2FWk%3D","updated":"2011-07-26 06:13:07.000000000","message":"I think you told me to do this.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":147,"context_line":"\t}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"\tpublic void shutdown(long time, TimeUnit unit) throws IOException {"},{"line_number":150,"context_line":"\t\tif (unit !\u003d TimeUnit.MICROSECONDS) {"},{"line_number":151,"context_line":"\t\t\tconnMgr.shutdown(TimeUnit.MILLISECONDS.convert(time, unit));"},{"line_number":152,"context_line":"\t\t} else {"},{"line_number":153,"context_line":"\t\t\tconnMgr.shutdown(time);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FWg%3D","line":150,"updated":"2011-07-26 02:49:32.000000000","message":"This seems to say, if it\u0027s not MICROSECONDS, convert it to MILLISECONDS.  So if I say MAX_LONG of microseconds, then it\u0027ll wait a long set of milliseconds?\n\nI may have this wrong, but it\u0027s not clear what you\u0027re trying to do here.  I suspect this was borrowed from an example.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"\t}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"\tpublic void shutdown(long time, TimeUnit unit) throws IOException {"},{"line_number":150,"context_line":"\t\tif (unit !\u003d TimeUnit.MICROSECONDS) {"},{"line_number":151,"context_line":"\t\t\tconnMgr.shutdown(TimeUnit.MILLISECONDS.convert(time, unit));"},{"line_number":152,"context_line":"\t\t} else {"},{"line_number":153,"context_line":"\t\t\tconnMgr.shutdown(time);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVY%3D","line":150,"in_reply_to":"AAABSH%2F%2F%2FWg%3D","updated":"2011-07-26 06:13:07.000000000","message":"Done","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"457da98a94f6de09319b340cf7b8e22557a3aaf6","unresolved":false,"context_lines":[{"line_number":214,"context_line":"\tstatic class EventLogger extends SpyObject implements EventListener {"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"\t\tpublic void connectionOpen(final NHttpConnection conn) {"},{"line_number":217,"context_line":"\t\t\tgetLogger().info(\"Connection open: \" + conn);"},{"line_number":218,"context_line":"\t\t}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"\t\tpublic void connectionTimeout(final NHttpConnection conn) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FWc%3D","line":217,"updated":"2011-07-26 02:49:32.000000000","message":"log levels here need review.  I\u0027m thinking some of these should be more error, and some should be more debug in nature.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f72223ad07974bc137229f5fbef1ad61aef4209a","unresolved":false,"context_lines":[{"line_number":214,"context_line":"\tstatic class EventLogger extends SpyObject implements EventListener {"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"\t\tpublic void connectionOpen(final NHttpConnection conn) {"},{"line_number":217,"context_line":"\t\t\tgetLogger().info(\"Connection open: \" + conn);"},{"line_number":218,"context_line":"\t\t}"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"\t\tpublic void connectionTimeout(final NHttpConnection conn) {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FVU%3D","line":217,"in_reply_to":"AAABSH%2F%2F%2FWc%3D","updated":"2011-07-26 06:13:07.000000000","message":"Done","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"}],"src/main/java/net/spy/memcached/couch/AsyncConnectionManager.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ca1893704490cc71c43f0af81789afe87ef266d5","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"public class AsyncConnectionManager extends SpyObject {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    private final HttpHost target; "},{"line_number":30,"context_line":"    private final int maxConnections; "},{"line_number":31,"context_line":"    private final NHttpClientHandler handler;"},{"line_number":32,"context_line":"    private final HttpParams params;"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FTo%3D","line":29,"updated":"2011-07-26 06:50:50.000000000","message":"whitespace issues all over this file","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b43e03ca3421ba1d07728e97b025a9c0ba6dd66","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"public class AsyncConnectionManager extends SpyObject {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    private final HttpHost target; "},{"line_number":30,"context_line":"    private final int maxConnections; "},{"line_number":31,"context_line":"    private final NHttpClientHandler handler;"},{"line_number":32,"context_line":"    private final HttpParams params;"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FRg%3D","line":29,"in_reply_to":"AAABSH%2F%2F%2FTo%3D","updated":"2011-07-26 07:03:31.000000000","message":"Will address soon.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"}],"src/main/java/net/spy/memcached/protocol/couchdb/View.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"ca1893704490cc71c43f0af81789afe87ef266d5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\tprivate final boolean map;"},{"line_number":8,"context_line":"\tprivate final boolean reduce;"},{"line_number":9,"context_line":"\t"},{"line_number":10,"context_line":"\tpublic View(String dn, String ddn, String vn, boolean m, boolean r) {"},{"line_number":11,"context_line":"\t\tdatabaseName \u003d dn;"},{"line_number":12,"context_line":"\t\tdesignDocumentName \u003d ddn;"},{"line_number":13,"context_line":"\t\tviewName \u003d vn;"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FR8%3D","line":10,"updated":"2011-07-26 06:50:50.000000000","message":"Views should not be public, right?  This should be private I think.\n\nIf it is public, then it should have longer names for the strings.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b43e03ca3421ba1d07728e97b025a9c0ba6dd66","unresolved":false,"context_lines":[{"line_number":7,"context_line":"\tprivate final boolean map;"},{"line_number":8,"context_line":"\tprivate final boolean reduce;"},{"line_number":9,"context_line":"\t"},{"line_number":10,"context_line":"\tpublic View(String dn, String ddn, String vn, boolean m, boolean r) {"},{"line_number":11,"context_line":"\t\tdatabaseName \u003d dn;"},{"line_number":12,"context_line":"\t\tdesignDocumentName \u003d ddn;"},{"line_number":13,"context_line":"\t\tviewName \u003d vn;"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2FRo%3D","line":10,"in_reply_to":"AAABSH%2F%2F%2FR8%3D","updated":"2011-07-26 07:03:31.000000000","message":"It\u0027s protected now.","commit_id":"3c230f4cc3832444f4de79787f7474d5dc06f0b1"}]}