)]}'
{"src/main/java/net/spy/memcached/HashAlgorithmRegistry.java":[{"author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b1df3ac77a1f4f70bde9339945ff9df06ec86b68","unresolved":false,"context_lines":[{"line_number":40,"context_line":"\tpublic static synchronized void registerHashAlgorithm("},{"line_number":41,"context_line":"\t\t\tString name, HashAlgorithm alg) {"},{"line_number":42,"context_line":"\t\tif (name !\u003d null) {"},{"line_number":43,"context_line":"\t\t\tREGISTRY.put(name.toLowerCase(), alg);"},{"line_number":44,"context_line":"\t\t}"},{"line_number":45,"context_line":"\t}"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-java","patch_set":6,"id":"AAABaX%2F%2F%2FCQ%3D","line":43,"updated":"2011-08-13 01:01:55.000000000","message":"I\u0027d rather throw NPE here.","commit_id":"3890e82e1355c2a3e9ec5c184b2b2f2b64eee55f"},{"author":{"_account_id":1000215,"name":"Paul Marynchev","email":"paulisio@gmail.com","username":"paulisio","avatars":[{"url":"https://www.gravatar.com/avatar/06142a145481c5a7de5f03ffaf7568a0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/06142a145481c5a7de5f03ffaf7568a0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/06142a145481c5a7de5f03ffaf7568a0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/06142a145481c5a7de5f03ffaf7568a0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"71dae4cee83a5ee0a380215c7b2a39cf4175cd91","unresolved":false,"context_lines":[{"line_number":40,"context_line":"\tpublic static synchronized void registerHashAlgorithm("},{"line_number":41,"context_line":"\t\t\tString name, HashAlgorithm alg) {"},{"line_number":42,"context_line":"\t\tif (name !\u003d null) {"},{"line_number":43,"context_line":"\t\t\tREGISTRY.put(name.toLowerCase(), alg);"},{"line_number":44,"context_line":"\t\t}"},{"line_number":45,"context_line":"\t}"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-java","patch_set":6,"id":"AAABaX%2F%2F%2FCI%3D","line":43,"in_reply_to":"AAABaX%2F%2F%2FCQ%3D","updated":"2011-08-13 01:51:41.000000000","message":"I\u0027d prefer throwing of IllegalArgumentExpetion here rather then NPE (in case we are going to throw exception here anyway)","commit_id":"3890e82e1355c2a3e9ec5c184b2b2f2b64eee55f"},{"author":{"_account_id":1000000,"name":"Dustin Sallings","email":"dustin@spy.net","username":"dustin","avatars":[{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/995543cb35c3b92a2eb43275116815a7.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b1df3ac77a1f4f70bde9339945ff9df06ec86b68","unresolved":false,"context_lines":[{"line_number":56,"context_line":"\t *         no algorithm with the specified name"},{"line_number":57,"context_line":"\t */"},{"line_number":58,"context_line":"\tpublic static synchronized HashAlgorithm lookupHashAlgorithm(String name) {"},{"line_number":59,"context_line":"\t\treturn name \u003d\u003d null ? null : REGISTRY.get(name.toLowerCase());"},{"line_number":60,"context_line":"\t}"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":6,"id":"AAABaX%2F%2F%2FCU%3D","line":59,"updated":"2011-08-13 01:01:55.000000000","message":"I\u0027d rather throw NPE here.","commit_id":"3890e82e1355c2a3e9ec5c184b2b2f2b64eee55f"},{"author":{"_account_id":1000215,"name":"Paul Marynchev","email":"paulisio@gmail.com","username":"paulisio","avatars":[{"url":"https://www.gravatar.com/avatar/06142a145481c5a7de5f03ffaf7568a0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/06142a145481c5a7de5f03ffaf7568a0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/06142a145481c5a7de5f03ffaf7568a0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/06142a145481c5a7de5f03ffaf7568a0.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"71dae4cee83a5ee0a380215c7b2a39cf4175cd91","unresolved":false,"context_lines":[{"line_number":56,"context_line":"\t *         no algorithm with the specified name"},{"line_number":57,"context_line":"\t */"},{"line_number":58,"context_line":"\tpublic static synchronized HashAlgorithm lookupHashAlgorithm(String name) {"},{"line_number":59,"context_line":"\t\treturn name \u003d\u003d null ? null : REGISTRY.get(name.toLowerCase());"},{"line_number":60,"context_line":"\t}"},{"line_number":61,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":6,"id":"AAABaX%2F%2F%2FCE%3D","line":59,"in_reply_to":"AAABaX%2F%2F%2FCU%3D","updated":"2011-08-13 01:51:41.000000000","message":"Same here","commit_id":"3890e82e1355c2a3e9ec5c184b2b2f2b64eee55f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3a717cf89cbb89f5e44216d9cd103f1d4c1bfab3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\t// initializing with the default algorithms implementation"},{"line_number":23,"context_line":"\tstatic {"},{"line_number":24,"context_line":"\t\tfor (DefaultHashAlgorithm alg : DefaultHashAlgorithm.values()) {"},{"line_number":25,"context_line":"\t\t\tregisterHashAlgorithm("},{"line_number":26,"context_line":"\t\t\t\t\talg.name().replace(\"[_HASH]$\", \"\")"},{"line_number":27,"context_line":"\t\t\t\t\t.toLowerCase(), alg);"},{"line_number":28,"context_line":"\t\t}"}],"source_content_type":"text/x-java","patch_set":9,"id":"AAABan%2F%2F%2FvM%3D","line":25,"updated":"2011-08-16 21:07:52.000000000","message":"Just so you know the [_HASH]$ thing you did here is incorrect. It should just be _HASH since this function takes a CharSequence. I have it fixed in my formatting patch.","commit_id":"42bfe7e889de72cfc790088560a90ef93a98631b"}],"src/main/java/net/spy/memcached/vbucket/config/DefaultConfigFactory.java":[{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d14dba7b52c2445ab78fb78f87c95d1b31abd9ec","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        HashAlgorithm hashAlgorithm \u003d"},{"line_number":89,"context_line":"\t    HashAlgorithmRegistry.lookupHashAlgorithm(algorithm);"},{"line_number":90,"context_line":"\tif (hashAlgorithm \u003d\u003d null) {"},{"line_number":91,"context_line":"\t    throw new IllegalArgumentException("},{"line_number":92,"context_line":"\t\t    \"Unhandled algorithm type: \" + algorithm);"},{"line_number":93,"context_line":"\t}"},{"line_number":94,"context_line":"        int replicasCount \u003d jsonObject.getInt(\"numReplicas\");"}],"source_content_type":"text/x-java","patch_set":4,"id":"AAABSX%2F%2F%2F2E%3D","line":91,"updated":"2011-08-06 01:16:58.000000000","message":"Could this say \"Unhandled hash algorithm type\" or \"Invalid hash algorithm type\". Having the word hash in there will make this more clear.","commit_id":"a76b007f817138329fe93d29e6f41824dc03cfbf"}]}
