)]}'
{"src/main/java/net/spy/memcached/CouchbaseClient.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"37fd20b57c3bc7ddc7b11659605e42e263f3ba9a","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"\t\tString uri \u003d view.getURI() + queryString + params;"},{"line_number":230,"context_line":"\t\tfinal CountDownLatch couchLatch \u003d new CountDownLatch(1);"},{"line_number":231,"context_line":"\t\tfinal ViewFuture crv \u003d new ViewFuture(couchLatch, 60000);"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"\t\tfinal HttpRequest request \u003d new BasicHttpRequest(\"GET\", uri, HttpVersion.HTTP_1_1);"},{"line_number":234,"context_line":"\t\tfinal HttpOperation op \u003d new DocsOperationImpl(request, new DocsCallback() {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2BZI%3D","side":"PARENT","line":231,"updated":"2011-08-02 22:49:31.000000000","message":"This constant should be somewhere else.","commit_id":"e91627bdea4fadff3a2a77798335fd2efca4cb95"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2b0805f9dd44796ea9b70d1fb850cbc601d7e241","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"\t\tString uri \u003d view.getURI() + queryString + params;"},{"line_number":230,"context_line":"\t\tfinal CountDownLatch couchLatch \u003d new CountDownLatch(1);"},{"line_number":231,"context_line":"\t\tfinal ViewFuture crv \u003d new ViewFuture(couchLatch, 60000);"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"\t\tfinal HttpRequest request \u003d new BasicHttpRequest(\"GET\", uri, HttpVersion.HTTP_1_1);"},{"line_number":234,"context_line":"\t\tfinal HttpOperation op \u003d new DocsOperationImpl(request, new DocsCallback() {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2BQQ%3D","side":"PARENT","line":231,"in_reply_to":"AAABSH%2F%2F%2BRQ%3D","updated":"2011-08-04 20:36:59.000000000","message":"Got it.  I still would have stuck it in a constant or changed it in the config, but that\u0027s fine.  In that case, probably good to mark it as todo \u0026\u0026 file a bug.","commit_id":"e91627bdea4fadff3a2a77798335fd2efca4cb95"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"47c5dc9556acc4452ceecf0c591424f29abe3d8e","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"\t\tString uri \u003d view.getURI() + queryString + params;"},{"line_number":230,"context_line":"\t\tfinal CountDownLatch couchLatch \u003d new CountDownLatch(1);"},{"line_number":231,"context_line":"\t\tfinal ViewFuture crv \u003d new ViewFuture(couchLatch, 60000);"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"\t\tfinal HttpRequest request \u003d new BasicHttpRequest(\"GET\", uri, HttpVersion.HTTP_1_1);"},{"line_number":234,"context_line":"\t\tfinal HttpOperation op \u003d new DocsOperationImpl(request, new DocsCallback() {"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2BRQ%3D","side":"PARENT","line":231,"in_reply_to":"AAABSH%2F%2F%2BZI%3D","updated":"2011-08-04 18:23:31.000000000","message":"I would put it somewhere else if were going to be there permanently. What \"should\" be here is the operationTimeout variable. Since Couchbase isn\u0027t ready for a lower timeout I have this hardcoded. I would like to keep it this way because it is so obviously wrong that I will easily notice it in the future and change it back to operationTimeout.","commit_id":"e91627bdea4fadff3a2a77798335fd2efca4cb95"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"37fd20b57c3bc7ddc7b11659605e42e263f3ba9a","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\t * @param query the type of query to run against the view."},{"line_number":223,"context_line":"\t * @return a Future containing the results of the query."},{"line_number":224,"context_line":"\t */"},{"line_number":225,"context_line":"\tpublic ViewFuture asyncQuery(View view, Query query) {"},{"line_number":226,"context_line":"\t\tString queryString \u003d query.toString();"},{"line_number":227,"context_line":"\t\tString params \u003d (queryString.length() \u003e 0) ? \"\u0026reduce\u003dfalse\" : \"?reduce\u003dfalse\";"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2BZE%3D","line":225,"updated":"2011-08-02 22:49:31.000000000","message":"should the timeout on these be per method invocation, following a default?  \n\nfor instance, should this really be \nasyncQuery(View view, Query query, int timeval, TimeUnit)\n\nfor the method that does stuff, and there is one that just uses the default?","commit_id":"15a404705a5747e32411d93baaeaa84cf67833b5"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"138db41f4c713e685c813f911b9138c5516e7acd","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\t * @param query the type of query to run against the view."},{"line_number":223,"context_line":"\t * @return a Future containing the results of the query."},{"line_number":224,"context_line":"\t */"},{"line_number":225,"context_line":"\tpublic ViewFuture asyncQuery(View view, Query query) {"},{"line_number":226,"context_line":"\t\tString queryString \u003d query.toString();"},{"line_number":227,"context_line":"\t\tString params \u003d (queryString.length() \u003e 0) ? \"\u0026reduce\u003dfalse\" : \"?reduce\u003dfalse\";"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSX%2F%2F%2F2s%3D","line":225,"in_reply_to":"AAABSH%2F%2F%2BQE%3D","updated":"2011-08-06 01:01:57.000000000","message":"Yep, agreed.  We\u0027ll come back to that later if needed.  Ideally, views will be quick.","commit_id":"15a404705a5747e32411d93baaeaa84cf67833b5"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"36b336141d1d8e030e5539b2f8842cb7956d4b75","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\t * @param query the type of query to run against the view."},{"line_number":223,"context_line":"\t * @return a Future containing the results of the query."},{"line_number":224,"context_line":"\t */"},{"line_number":225,"context_line":"\tpublic ViewFuture asyncQuery(View view, Query query) {"},{"line_number":226,"context_line":"\t\tString queryString \u003d query.toString();"},{"line_number":227,"context_line":"\t\tString params \u003d (queryString.length() \u003e 0) ? \"\u0026reduce\u003dfalse\" : \"?reduce\u003dfalse\";"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2BQE%3D","line":225,"in_reply_to":"AAABSH%2F%2F%2BQM%3D","updated":"2011-08-04 20:43:17.000000000","message":"There isn\u0027t a way to make individual memcached calls and specify the timeout in the function parameters. We could add it, but the we begin getting into having a lot of query call permutations (Async vs Sync, Return with errors/Retun without errors, Specify a timeout per operation/ don\u0027t specify a timeout per operation)","commit_id":"15a404705a5747e32411d93baaeaa84cf67833b5"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2b0805f9dd44796ea9b70d1fb850cbc601d7e241","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\t * @param query the type of query to run against the view."},{"line_number":223,"context_line":"\t * @return a Future containing the results of the query."},{"line_number":224,"context_line":"\t */"},{"line_number":225,"context_line":"\tpublic ViewFuture asyncQuery(View view, Query query) {"},{"line_number":226,"context_line":"\t\tString queryString \u003d query.toString();"},{"line_number":227,"context_line":"\t\tString params \u003d (queryString.length() \u003e 0) ? \"\u0026reduce\u003dfalse\" : \"?reduce\u003dfalse\";"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2BQM%3D","line":225,"in_reply_to":"AAABSH%2F%2F%2BRU%3D","updated":"2011-08-04 20:36:59.000000000","message":"Even with the connection wide default timeout, there may be times you want to call with a larger timeout.  We do that in the main client (I think).  This is particularly important in views, since they may go quite long.","commit_id":"15a404705a5747e32411d93baaeaa84cf67833b5"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"47c5dc9556acc4452ceecf0c591424f29abe3d8e","unresolved":false,"context_lines":[{"line_number":222,"context_line":"\t * @param query the type of query to run against the view."},{"line_number":223,"context_line":"\t * @return a Future containing the results of the query."},{"line_number":224,"context_line":"\t */"},{"line_number":225,"context_line":"\tpublic ViewFuture asyncQuery(View view, Query query) {"},{"line_number":226,"context_line":"\t\tString queryString \u003d query.toString();"},{"line_number":227,"context_line":"\t\tString params \u003d (queryString.length() \u003e 0) ? \"\u0026reduce\u003dfalse\" : \"?reduce\u003dfalse\";"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABSH%2F%2F%2BRU%3D","line":225,"in_reply_to":"AAABSH%2F%2F%2BZE%3D","updated":"2011-08-04 18:23:31.000000000","message":"This can be configured through the connection factory. It might look slightly confusing because I hardcoded the timeout.","commit_id":"15a404705a5747e32411d93baaeaa84cf67833b5"}]}