)]}'
{"src/main/java/net/spy/memcached/CouchbaseClient.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e3fd20a72b3fd8a0ba17c629320ef256da49e160","unresolved":false,"context_lines":[{"line_number":224,"context_line":"\t */"},{"line_number":225,"context_line":"\tpublic HttpFuture\u003cViewResponseWithDocs\u003e asyncQuery(View view, Query query) {"},{"line_number":226,"context_line":"\t\tString queryString \u003d query.toString();"},{"line_number":227,"context_line":"\t\tString params \u003d (queryString.length() \u003e 0) ? \"\u0026reduce\u003dfalse\" : \"?reduce\u003dfalse\";"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"\t\tString uri \u003d view.getURI() + queryString + params;"},{"line_number":230,"context_line":"\t\tfinal CountDownLatch couchLatch \u003d new CountDownLatch(1);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABin%2F%2F%2F6A%3D","side":"PARENT","line":227,"updated":"2011-08-17 16:13:03.000000000","message":"out of curiosity, you have include_docs false below, but it\u0027s equally valid here since we\u0027re going back in over memcached protocol, right?  Why wouldn\u0027t we use it here?","commit_id":"c6827b422cbf7032217d7f0817dac93baafe141a"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a3076bd06a4c4b84dd5368b8691b2bd374afa8d2","unresolved":false,"context_lines":[{"line_number":224,"context_line":"\t */"},{"line_number":225,"context_line":"\tpublic HttpFuture\u003cViewResponseWithDocs\u003e asyncQuery(View view, Query query) {"},{"line_number":226,"context_line":"\t\tString queryString \u003d query.toString();"},{"line_number":227,"context_line":"\t\tString params \u003d (queryString.length() \u003e 0) ? \"\u0026reduce\u003dfalse\" : \"?reduce\u003dfalse\";"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"\t\tString uri \u003d view.getURI() + queryString + params;"},{"line_number":230,"context_line":"\t\tfinal CountDownLatch couchLatch \u003d new CountDownLatch(1);"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABin%2F%2F%2F38%3D","side":"PARENT","line":227,"in_reply_to":"AAABin%2F%2F%2F6A%3D","updated":"2011-08-17 18:25:11.000000000","message":"It\u0027s actually false by default and there is no way to set it in the Query class (So technically it\u0027s redundant below.). Let\u0027s leave this as is for now since in a future commit I remove the two lines of code above this comment anyways.","commit_id":"c6827b422cbf7032217d7f0817dac93baafe141a"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e3fd20a72b3fd8a0ba17c629320ef256da49e160","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import net.spy.memcached.protocol.couch.DocsOperation.DocsCallback;"},{"line_number":24,"context_line":"import net.spy.memcached.protocol.couch.DocsOperationImpl;"},{"line_number":25,"context_line":"import net.spy.memcached.protocol.couch.HttpOperation;"},{"line_number":26,"context_line":"import net.spy.memcached.protocol.couch.NoDocsOperation.NoDocsCallback;"},{"line_number":27,"context_line":"import net.spy.memcached.protocol.couch.NoDocsOperationImpl;"},{"line_number":28,"context_line":"import net.spy.memcached.protocol.couch.Query;"},{"line_number":29,"context_line":"import net.spy.memcached.protocol.couch.ReducedOperation.ReducedCallback;"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABin%2F%2F%2F6Q%3D","line":26,"updated":"2011-08-17 16:13:03.000000000","message":"namespacing wise, isn\u0027t this NoDocsOperations  (with an s?).  I\u0027m not sure it needs to be namespaced this deep anyway.","commit_id":"c38655412ec956262dfd862ac2de0355f80b2bed"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a3076bd06a4c4b84dd5368b8691b2bd374afa8d2","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import net.spy.memcached.protocol.couch.DocsOperation.DocsCallback;"},{"line_number":24,"context_line":"import net.spy.memcached.protocol.couch.DocsOperationImpl;"},{"line_number":25,"context_line":"import net.spy.memcached.protocol.couch.HttpOperation;"},{"line_number":26,"context_line":"import net.spy.memcached.protocol.couch.NoDocsOperation.NoDocsCallback;"},{"line_number":27,"context_line":"import net.spy.memcached.protocol.couch.NoDocsOperationImpl;"},{"line_number":28,"context_line":"import net.spy.memcached.protocol.couch.Query;"},{"line_number":29,"context_line":"import net.spy.memcached.protocol.couch.ReducedOperation.ReducedCallback;"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABin%2F%2F%2F34%3D","line":26,"in_reply_to":"AAABin%2F%2F%2F6Q%3D","updated":"2011-08-17 18:25:11.000000000","message":"I think the way this is named is consistent with the project. For example in the memcached protocol we have an Operation class, not an Operations class. I am open for renaming of any of my new classes, but I think it should happen in a future commit.","commit_id":"c38655412ec956262dfd862ac2de0355f80b2bed"}],"src/test/java/net/spy/memcached/couch/CouchbaseClientTest.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e3fd20a72b3fd8a0ba17c629320ef256da49e160","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\t\tQuery query \u003d new Query();"},{"line_number":151,"context_line":"\t\tView view \u003d client.getView(DESIGN_DOC_W_REDUCE, VIEW_NAME_W_REDUCE);"},{"line_number":152,"context_line":"\t\tHttpFuture\u003cViewResponse\u003e future \u003d client.asyncQuery(view, query);"},{"line_number":153,"context_line":"\t\tViewResponse response \u003d future.get();"},{"line_number":154,"context_line":"\t\tassert future.getStatus().isSuccess() : future.getStatus();"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"\t\tIterator\u003cViewRow\u003e itr \u003d response.iterator();"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABin%2F%2F%2F6E%3D","line":153,"updated":"2011-08-17 16:13:03.000000000","message":"definitely cleaner looking.  I like it.","commit_id":"c38655412ec956262dfd862ac2de0355f80b2bed"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a3076bd06a4c4b84dd5368b8691b2bd374afa8d2","unresolved":false,"context_lines":[{"line_number":150,"context_line":"\t\tQuery query \u003d new Query();"},{"line_number":151,"context_line":"\t\tView view \u003d client.getView(DESIGN_DOC_W_REDUCE, VIEW_NAME_W_REDUCE);"},{"line_number":152,"context_line":"\t\tHttpFuture\u003cViewResponse\u003e future \u003d client.asyncQuery(view, query);"},{"line_number":153,"context_line":"\t\tViewResponse response \u003d future.get();"},{"line_number":154,"context_line":"\t\tassert future.getStatus().isSuccess() : future.getStatus();"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"\t\tIterator\u003cViewRow\u003e itr \u003d response.iterator();"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABin%2F%2F%2F30%3D","line":153,"in_reply_to":"AAABin%2F%2F%2F6E%3D","updated":"2011-08-17 18:25:11.000000000","message":"And it gets better after a few more commits.","commit_id":"c38655412ec956262dfd862ac2de0355f80b2bed"}]}