)]}'
{"src/main/java/net/spy/memcached/protocol/binary/ConcatenationOperationImpl.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aa7965707077142a7b7db71d1405f14ec2b486c7","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\t\t\tcase prepend: rv\u003dPREPEND; break;"},{"line_number":22,"context_line":"\t\t}"},{"line_number":23,"context_line":"\t\t// Check fall-through."},{"line_number":24,"context_line":"\t\tassert rv !\u003d -1 : \"Unhandled store type:  \" + t;"},{"line_number":25,"context_line":"\t\treturn rv;"},{"line_number":26,"context_line":"\t}"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABjX%2F%2F%2BvI%3D","side":"PARENT","line":24,"updated":"2011-09-09 18:13:30.000000000","message":"you need to update the assertion too.  I\u0027m surprised the IDE didn\u0027t catch this one.","commit_id":"193a684209041b2e2f0cae97d0955e0c6c8703fb"}],"src/main/java/net/spy/memcached/protocol/binary/DeleteOperationImpl.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e9975e78d01140809b12de1c041ad8dda9a7e03f","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\t@Override"},{"line_number":28,"context_line":"\tpublic String toString() {"},{"line_number":29,"context_line":"\t\treturn super.toString() + \" Cas: \" + cas;"},{"line_number":30,"context_line":"\t}"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABjX%2F%2F%2BrA%3D","line":29,"updated":"2011-09-09 22:06:20.000000000","message":"This snuck into the wrong changeset.","commit_id":"66e57add861d6eb27a3a8ba0aa78d7e14f9fc06f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"571180db75b4d3b99ff48abf7ba760a6ae3582f8","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\t@Override"},{"line_number":28,"context_line":"\tpublic String toString() {"},{"line_number":29,"context_line":"\t\treturn super.toString() + \" Cas: \" + cas;"},{"line_number":30,"context_line":"\t}"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABjX%2F%2F%2Bgk%3D","line":29,"in_reply_to":"AAABjX%2F%2F%2BrA%3D","updated":"2011-09-12 17:36:53.000000000","message":"This is not part of this change set. (Not in green)","commit_id":"66e57add861d6eb27a3a8ba0aa78d7e14f9fc06f"}],"src/main/java/net/spy/memcached/protocol/binary/FlushOperationImpl.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e9975e78d01140809b12de1c041ad8dda9a7e03f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\t}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\t@Override"},{"line_number":26,"context_line":"\tpublic String toString() {"},{"line_number":27,"context_line":"\t\treturn super.toString() + \" Delay: \" + delay;"},{"line_number":28,"context_line":"\t}"},{"line_number":29,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABjX%2F%2F%2Bq8%3D","line":26,"updated":"2011-09-09 22:06:20.000000000","message":"wrong changeset, there are probably some others too","commit_id":"66e57add861d6eb27a3a8ba0aa78d7e14f9fc06f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"571180db75b4d3b99ff48abf7ba760a6ae3582f8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"\t}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"\t@Override"},{"line_number":26,"context_line":"\tpublic String toString() {"},{"line_number":27,"context_line":"\t\treturn super.toString() + \" Delay: \" + delay;"},{"line_number":28,"context_line":"\t}"},{"line_number":29,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABjX%2F%2F%2Bgg%3D","line":26,"in_reply_to":"AAABjX%2F%2F%2Bq8%3D","updated":"2011-09-12 17:36:53.000000000","message":"This is not part of this change set. (Not in green)","commit_id":"66e57add861d6eb27a3a8ba0aa78d7e14f9fc06f"}],"src/main/java/net/spy/memcached/protocol/binary/MultiKeyOperationImpl.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e9975e78d01140809b12de1c041ad8dda9a7e03f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\t}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"\t@Override"},{"line_number":52,"context_line":"\tpublic String toString() {"},{"line_number":53,"context_line":"\t\treturn super.toString() + \" Keys: \" + StringUtils.join(getKeys(), \" \");"},{"line_number":54,"context_line":"\t}"},{"line_number":55,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABjX%2F%2F%2Bq4%3D","line":52,"updated":"2011-09-09 22:06:20.000000000","message":"wrong changeset","commit_id":"66e57add861d6eb27a3a8ba0aa78d7e14f9fc06f"},{"author":{"_account_id":1000136,"name":"Mike Wiederhold","email":"mike@couchbase.com","username":"mikewied","avatars":[{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/337c57dab3946ecdea245eaabfe99a17.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"571180db75b4d3b99ff48abf7ba760a6ae3582f8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\t}"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"\t@Override"},{"line_number":52,"context_line":"\tpublic String toString() {"},{"line_number":53,"context_line":"\t\treturn super.toString() + \" Keys: \" + StringUtils.join(getKeys(), \" \");"},{"line_number":54,"context_line":"\t}"},{"line_number":55,"context_line":"}"}],"source_content_type":"text/x-java","patch_set":2,"id":"AAABjX%2F%2F%2Bgc%3D","line":52,"in_reply_to":"AAABjX%2F%2F%2Bq4%3D","updated":"2011-09-12 17:36:53.000000000","message":"This is not part of this change set. (Not in green)","commit_id":"66e57add861d6eb27a3a8ba0aa78d7e14f9fc06f"}],"src/main/java/net/spy/memcached/protocol/binary/OperationImpl.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aa7965707077142a7b7db71d1405f14ec2b486c7","unresolved":false,"context_lines":[{"line_number":109,"context_line":"\t\t\t\tint magic\u003dheader[0];"},{"line_number":110,"context_line":"\t\t\t\tassert magic \u003d\u003d RES_MAGIC : \"Invalid magic:  \" + magic;"},{"line_number":111,"context_line":"\t\t\t\tresponseCmd\u003dheader[1];"},{"line_number":112,"context_line":"\t\t\t\tassert cmd \u003d\u003d (byte)0xFF || responseCmd \u003d\u003d cmd"},{"line_number":113,"context_line":"\t\t\t\t\t: \"Unexpected response command value\";"},{"line_number":114,"context_line":"\t\t\t\tkeyLen\u003ddecodeShort(header, 2);"},{"line_number":115,"context_line":"\t\t\t\t// TODO:  Examine extralen and datatype"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABjX%2F%2F%2Bu8%3D","line":112,"updated":"2011-09-09 18:13:30.000000000","message":"This may be able to be replaced by a constant","commit_id":"61da1c8bda73909bacca6c5f006af7b4dbea0d28"}],"src/main/java/net/spy/memcached/protocol/binary/OptimizedSetImpl.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aa7965707077142a7b7db71d1405f14ec2b486c7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"\t * Construct an optimized get starting with the given get operation."},{"line_number":33,"context_line":"\t */"},{"line_number":34,"context_line":"\tpublic OptimizedSetImpl(CASOperation firstStore) {"},{"line_number":35,"context_line":"\t\tsuper((byte)0xFF, -1, NOOP_CALLBACK);"},{"line_number":36,"context_line":"\t\taddOperation(firstStore);"},{"line_number":37,"context_line":"\t}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABjX%2F%2F%2Bu4%3D","line":35,"updated":"2011-09-09 18:13:30.000000000","message":"Another possible constant to use?","commit_id":"61da1c8bda73909bacca6c5f006af7b4dbea0d28"},{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aa7965707077142a7b7db71d1405f14ec2b486c7","unresolved":false,"context_lines":[{"line_number":105,"context_line":"\t}"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"\tprivate static int cmdMap(StoreType t) {"},{"line_number":108,"context_line":"\t\tint rv\u003d0xFF;"},{"line_number":109,"context_line":"\t\tswitch(t) {"},{"line_number":110,"context_line":"\t\t\tcase set: rv\u003dStoreOperationImpl.SETQ; break;"},{"line_number":111,"context_line":"\t\t\tcase add: rv\u003dStoreOperationImpl.ADDQ; break;"}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABjX%2F%2F%2Bu0%3D","line":108,"updated":"2011-09-09 18:13:30.000000000","message":"I don\u0027t think a change is called for here.  You\u0027re sticking with int, not using byte here.  -1 as a sentinel is fine.  Here, you\u0027re using 148 as a sentinel.","commit_id":"61da1c8bda73909bacca6c5f006af7b4dbea0d28"}],"src/main/java/net/spy/memcached/protocol/binary/StoreOperationImpl.java":[{"author":{"_account_id":1000013,"name":"Matt Ingenthron","email":"ingenthr@gmail.com","username":"ingenthr","avatars":[{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/dface45e4481ef6bd571492fa3b4ef8c.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"aa7965707077142a7b7db71d1405f14ec2b486c7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"\t\t\tcase replace: rv\u003dREPLACE; break;"},{"line_number":34,"context_line":"\t\t}"},{"line_number":35,"context_line":"\t\t// Check fall-through."},{"line_number":36,"context_line":"\t\tassert rv !\u003d -1 : \"Unhandled store type:  \" + t;"},{"line_number":37,"context_line":"\t\treturn rv;"},{"line_number":38,"context_line":"\t}"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-java","patch_set":1,"id":"AAABjX%2F%2F%2Bus%3D","side":"PARENT","line":36,"updated":"2011-09-09 18:13:30.000000000","message":"another incorrect check here.","commit_id":"193a684209041b2e2f0cae97d0955e0c6c8703fb"}]}